Convert ReviewReply.discardIfEmpty to use promises.
Review Request #11633 — Created May 28, 2021 and submitted — Latest diff uploaded
This change updates the ReviewReply.discardIfEmpty logic to use promises
instead of success/error callbacks.
- Ran js-tests.
- Verified that the draft reply object was properly discarded when there
were no more comments attached.
Diff Revision 5 (Latest)
orig
1
2
3
4
5
Commits
Files
| reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js |
|---|
| reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js |
|---|
| reviewboard/static/rb/js/reviewRequestPage/models/reviewReplyEditorModel.es6.js |
|---|
| reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js |
|---|
| reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyEditorViewTests.es6.js |
|---|
| reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js |
|---|