- Download Diff

Summary:

Convert ReviewReply.discardIfEmpty to use promises.

Review Request #11633 — Created May 28, 2021 and submitted Dec. 3, 2021, 3:48 p.m.

Information
Owner:	david
Repository:	Review Board
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

This change updates the ReviewReply.discardIfEmpty logic to use promises
instead of success/error callbacks.

Testing Done


Ran js-tests.
Verified that the draft reply object was properly discarded when there

  were no more comments attached.

Commits

Summary
	Convert ReviewReply.discardIfEmpty to use promises.

Screenshots

Issues

Description	From	Last Updated
Col: 53 Missing semicolon.	reviewbot	May 28, 2021, 2:14 p.m.
Col: 57 Missing semicolon.	reviewbot	May 28, 2021, 2:14 p.m.
Think this can be .and.resolveTo(true).	chipx86	Oct. 18, 2021, 3:30 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js (Diff revision 1)
Show all issues
```
Col: 53
 Missing semicolon.
```
reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js (Diff revision 1)
Show all issues
```
Col: 57
 Missing semicolon.
```

Commits:

	Summary
-		Convert ReviewReply.discardIfEmpty to use promises.
+		Convert ReviewReply.discardIfEmpty to use promises.

Diff:

Revision 2 (+300 -290)

Show changes

	reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewReplyEditorModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyEditorViewTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

~		This change updates the `ReviewReply.discardIfEmpty` logic to use promises
	~	This change updates the ReviewReply.discardIfEmpty logic to use promises
		instead of success/error callbacks.

Commits:

	Summary
-		Convert ReviewReply.discardIfEmpty to use promises.
+		Convert ReviewReply.discardIfEmpty to use promises.

Diff:

Revision 3 (+360 -276)

Show changes

	reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewReplyEditorModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyEditorViewTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js (Diff revision 3)
Show all issues
```
Think this can be .and.resolveTo(true).
```

Commits:

	Summary
-		Convert ReviewReply.discardIfEmpty to use promises.
+		Convert ReviewReply.discardIfEmpty to use promises.

Diff:

Revision 4 (+354 -276)

Show changes

	reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewReplyEditorModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyEditorViewTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary
-		Convert ReviewReply.discardIfEmpty to use promises.
+		Convert ReviewReply.discardIfEmpty to use promises.

Diff:

Revision 5 (+348 -276)

Show changes

	reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewReplyEditorModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyEditorViewTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (941ada1)

You have a pending review.

Review Board 5.0.2 alpha 0 (dev)

Convert ReviewReply.discardIfEmpty to use promises.

JSHint

Commits:

Diff:

Checks run (2 succeeded)

Description:

Commits:

Diff:

Checks run (2 succeeded)

Commits:

Diff:

Checks run (2 succeeded)

Commits:

Diff:

Checks run (2 succeeded)

Status: Closed (submitted)

Change Summary: