Convert ReviewReply.discardIfEmpty to use promises.

Review Request #11633 — Created May 28, 2021 and submitted

Information

Review Board
master

Reviewers

This change updates the ReviewReply.discardIfEmpty logic to use promises
instead of success/error callbacks.

  • Ran js-tests.
  • Verified that the draft reply object was properly discarded when there
    were no more comments attached.
Summary ID
Convert ReviewReply.discardIfEmpty to use promises.
This change updates the ReviewReply.discardIfEmpty logic to use promises instead of success/error callbacks. Testing Done: - Ran js-tests. - Verified that the draft reply object was properly discarded when there were no more comments attached.
3ba3be0e0b18ee94511e3ea5a9156e106c16de5c
Description From Last Updated

Col: 53 Missing semicolon.

reviewbotreviewbot

Col: 57 Missing semicolon.

reviewbotreviewbot

Think this can be .and.resolveTo(true).

chipx86chipx86
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

david
david
chipx86
  1. 
      
  2. Show all issues

    Think this can be .and.resolveTo(true).

  3. 
      
david
david
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to master (941ada1)