Convert ReviewReply.discardIfEmpty to use promises.

 






 

 


  Review Request #11633
  —
  Created May 28, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
This change updates the ReviewReply.discardIfEmpty logic to use promises

instead of success/error callbacks.

 








  


 
 

  
    

  • Ran js-tests.
    • 

  • Verified that the draft reply object was properly discarded when there
    
  were no more comments attached.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 4 and 5



    

 

 

 

 
orig
1
2
3
4
5

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Convert ReviewReply.discardIfEmpty to use promises.
     
This change updates the ReviewReply.discardIfEmpty logic to use promises
instead of success/error callbacks.

Testing Done:
- Ran js-tests.
- Verified that the draft reply object was properly discarded when there
  were no more comments attached.

    

   
  		
  88f81396cf3cdf52a6e1b985d2511d73a7f96429
  David Trowbridge
 


 
  
 
 
  
   
    

     Convert ReviewReply.discardIfEmpty to use promises.
     
This change updates the ReviewReply.discardIfEmpty logic to use promises
instead of success/error callbacks.

Testing Done:
- Ran js-tests.
- Verified that the draft reply object was properly discarded when there
  were no more comments attached.

    

   
  		
  3ba3be0e0b18ee94511e3ea5a9156e106c16de5c
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...