This change has been marked as completed.

Describe the completed change (optional):

Pushed to master (941ada1)

Summary

Convert ReviewReply.discardIfEmpty to use promises.

Review Request #11633 — Created May 28, 2021 and submitted 3 years, 5 months ago — Latest diff uploaded 3 years, 7 months ago

Owner

Repository

Review Board

Branch

master

Bugs

Depends On

Groups

People

Description*

This change updates the ReviewReply.discardIfEmpty logic to use promises
instead of success/error callbacks.

Testing Done


Ran js-tests.
Verified that the draft reply object was properly discarded when there

  were no more comments attached.

orig

	Summary	ID	Author
	Convert ReviewReply.discardIfEmpty to use promises. This change updates the ReviewReply.discardIfEmpty logic to use promises instead of success/error callbacks. Testing Done: - Ran js-tests. - Verified that the draft reply object was properly discarded when there were no more comments attached.	3f6b8762d5154292f9f9877815f2914ef886d6fe	David Trowbridge
	Convert ReviewReply.discardIfEmpty to use promises. This change updates the ReviewReply.discardIfEmpty logic to use promises instead of success/error callbacks. Testing Done: - Ran js-tests. - Verified that the draft reply object was properly discarded when there were no more comments attached.	88f81396cf3cdf52a6e1b985d2511d73a7f96429	David Trowbridge

	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyEditorViewTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js

reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyEditorViewTests.es6.js

reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js