Summary

Convert ReviewReply.discardIfEmpty to use promises.

Review Request #11633 — Created May 28, 2021 and submitted Dec. 3, 2021, 3:48 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change updates the ReviewReply.discardIfEmpty logic to use promises
instead of success/error callbacks.

Testing Done


Ran js-tests.
Verified that the draft reply object was properly discarded when there

  were no more comments attached.

Commits

Summary	ID
Convert ReviewReply.discardIfEmpty to use promises. This change updates the ReviewReply.discardIfEmpty logic to use promises instead of success/error callbacks. Testing Done: - Ran js-tests. - Verified that the draft reply object was properly discarded when there were no more comments attached.	3ba3be0e0b18ee94511e3ea5a9156e106c16de5c

Issues

Description	From	Last Updated
Col: 53 Missing semicolon.	reviewbot	May 28, 2021, 2:14 p.m.
Col: 57 Missing semicolon.	reviewbot	May 28, 2021, 2:14 p.m.
Think this can be .and.resolveTo(true).	chipx86	Oct. 18, 2021, 3:30 p.m.

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Col: 53
 Missing semicolon.

reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js (Diff revision 1)

The issue has been resolved. Show all issues

Col: 57
 Missing semicolon.

Commits:

	Summary	ID
	Convert ReviewReply.discardIfEmpty to use promises. This change updates the ReviewReply.discardIfEmpty logic to use promises instead of success/error callbacks. Testing Done: - Ran js-tests. - Verified that the draft reply object was properly discarded when there were no more comments attached.	e9c0791870d47c38a780eb7abdfabecb0cbe9fc2
	Convert ReviewReply.discardIfEmpty to use promises. This change updates the ReviewReply.discardIfEmpty logic to use promises instead of success/error callbacks. Testing Done: - Ran js-tests. - Verified that the draft reply object was properly discarded when there were no more comments attached.	cb7bf98fc2df44e009e60730bb37083d53b86c14

Diff:

Revision 2 (+300 -290)

Show changes

	reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewReplyEditorModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyEditorViewTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

~		This change updates the `ReviewReply.discardIfEmpty` logic to use promises
	~	This change updates the ReviewReply.discardIfEmpty logic to use promises
		instead of success/error callbacks.

Commits:

	Summary	ID
	Convert ReviewReply.discardIfEmpty to use promises. This change updates the ReviewReply.discardIfEmpty logic to use promises instead of success/error callbacks. Testing Done: - Ran js-tests. - Verified that the draft reply object was properly discarded when there were no more comments attached.	cb7bf98fc2df44e009e60730bb37083d53b86c14
	Convert ReviewReply.discardIfEmpty to use promises. This change updates the ReviewReply.discardIfEmpty logic to use promises instead of success/error callbacks. Testing Done: - Ran js-tests. - Verified that the draft reply object was properly discarded when there were no more comments attached.	3f6b8762d5154292f9f9877815f2914ef886d6fe

Diff:

Revision 3 (+360 -276)

Show changes

	reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewReplyEditorModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyEditorViewTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js (Diff revision 3)

The issue has been resolved. Show all issues

Think this can be .and.resolveTo(true).

Commits:

	Summary	ID
	Convert ReviewReply.discardIfEmpty to use promises. This change updates the ReviewReply.discardIfEmpty logic to use promises instead of success/error callbacks. Testing Done: - Ran js-tests. - Verified that the draft reply object was properly discarded when there were no more comments attached.	3f6b8762d5154292f9f9877815f2914ef886d6fe
	Convert ReviewReply.discardIfEmpty to use promises. This change updates the ReviewReply.discardIfEmpty logic to use promises instead of success/error callbacks. Testing Done: - Ran js-tests. - Verified that the draft reply object was properly discarded when there were no more comments attached.	88f81396cf3cdf52a6e1b985d2511d73a7f96429

Diff:

Revision 4 (+354 -276)

Show changes

	reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewReplyEditorModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyEditorViewTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Convert ReviewReply.discardIfEmpty to use promises. This change updates the ReviewReply.discardIfEmpty logic to use promises instead of success/error callbacks. Testing Done: - Ran js-tests. - Verified that the draft reply object was properly discarded when there were no more comments attached.	88f81396cf3cdf52a6e1b985d2511d73a7f96429
	Convert ReviewReply.discardIfEmpty to use promises. This change updates the ReviewReply.discardIfEmpty logic to use promises instead of success/error callbacks. Testing Done: - Ran js-tests. - Verified that the draft reply object was properly discarded when there were no more comments attached.	3ba3be0e0b18ee94511e3ea5a9156e106c16de5c

Diff:

Revision 5 (+348 -276)

Show changes

	reviewboard/static/rb/js/resources/models/reviewReplyModel.es6.js
	reviewboard/static/rb/js/resources/models/tests/reviewReplyModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewReplyEditorModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/tests/reviewReplyEditorModelTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewReplyEditorViewTests.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/reviewViewTests.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (941ada1)