Assume Subversion "nonexistent" destination revisions are deleted files.

Review Request #11602 — Created May 11, 2021 and submitted

Information

Review Board
release-3.0.x

Reviewers

Subversion has a couple different ways it can represent deleted files,
and they're not always consistent. It's also changed throughout
Subversion development, meaning that our deleted file logic worked fine
on some versions, and less so on others, depending.

We weren't handling the case where a file was listed as deleted using a
destination revision of (nonexistent). We did handle this for the
source revision, and we handled Index: ... (deleted), but not this
version.

This change implements this support, checking for this revision
identifier and flagging the file as deleted. This only affects
newly-uploaded diffs.

Unit tests pass. Waiting on feedback from a user who reported the issue.

Summary ID
Assume Subversion "nonexistent" destination revisions are deleted files.
Subversion has a couple different ways it can represent deleted files, and they're not always consistent. It's also changed throughout Subversion development, meaning that our deleted file logic worked fine on some versions, and less so on others, depending. We weren't handling the case where a file was listed as deleted using a destination revision of `(nonexistent)`. We did handle this for the source revision, and we handled `Index: ... (deleted)`, but not this version. This change implements this support, checking for this revision identifier and flagging the file as deleted. This only affects newly-uploaded diffs.
a7ec33ae6a50d1d078ea33cad83ef3089c6d91a4
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (7b5215c)