Summary:

Hide ResourceWarning when running rbt post

Review Request #11600 — Created May 8, 2021 and submitted July 6, 2021, 10:37 p.m.

Information
Owner:	torcolvin
Repository:	RBTools
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	rbtools
People:

Description

We often run rbt post in an environment with environment variables PYTHONWARNINGS=default to help discover errors. This spits a lot of subprocess errors when running.

ResourceWarning: Enable tracemalloc to get the object allocation traceback
/usr/local/Cellar/python@3.9/3.9.4/Frameworks/Python.framework/Versions/3.9/lib/python3.9/subprocess.py:765: ResourceWarning: unclosed file <_io.BufferedReader name=13>
  _cleanup()

Testing Done

These errors stop showing up in unit tests and in rbt post in a private git repo.

Commits

Summary
Hide ResourceWarning when running rbt post

Screenshots

Issues

Description	From	Last Updated
E261 at least two spaces before inline comment	reviewbot	May 8, 2021, 3:47 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/utils/checks.py (Diff revision 1)
Show all issues
```
E261 at least two spaces before inline comment
```

Change Summary:

fixed flake8 error

Commits:

	Summary
-	Hide ResourceWarning when running rbt post
+	Hide ResourceWarning when running rbt post

Diff:

Revision 2 (+4 -2)

Show changes

rbtools/utils/checks.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

Thanks for the contribution! We'll have this in RBTools 2.0.1 (this week).

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (ae92446)

rbtools/utils/checks.py (Diff revision 1)