Catch and log on-the-fly indexing errors instead of crashing.

 






 

 


  Review Request #11596
  —
  Created April 13, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
When failing to communicate with a search backend, operations that

would modify the search index would lead to a crash. The backend would

raise an exception, which never got caught anywhere. That could break

all manner of operations.


This change sandboxes any errors, logging the error messages when they

occur and preventing them from bubbling up.

 








  


 
 

  
Unit tests pass.

 







 









 





  








 




 







   

    
    
Diff Revision 1 (Latest)



    

    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Catch and log on-the-fly indexing errors instead of crashing.
     
When failing to communicate with a search backend, operations that
would modify the search index would lead to a crash. The backend would
raise an exception, which never got caught anywhere. That could break
all manner of operations.

This change sandboxes any errors, logging the error messages when they
occur and preventing them from bubbling up.

    

   
  		
  cb5d87192f0c103f4a48640d2c37f554ab84c8c5
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/search/signal_processor.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/search/tests/test_signal_processor.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...