• 
      

    Catch and log on-the-fly indexing errors instead of crashing.

    Review Request #11596 — Created April 13, 2021 and submitted

    Information

    Review Board
    release-4.0.x

    Reviewers

    When failing to communicate with a search backend, operations that
    would modify the search index would lead to a crash. The backend would
    raise an exception, which never got caught anywhere. That could break
    all manner of operations.

    This change sandboxes any errors, logging the error messages when they
    occur and preventing them from bubbling up.

    Unit tests pass.

    Summary ID
    Catch and log on-the-fly indexing errors instead of crashing.
    When failing to communicate with a search backend, operations that would modify the search index would lead to a crash. The backend would raise an exception, which never got caught anywhere. That could break all manner of operations. This change sandboxes any errors, logging the error messages when they occur and preventing them from bubbling up.
    cb5d87192f0c103f4a48640d2c37f554ab84c8c5
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to master (6b370d2)