This change has been marked as completed.

Describe the completed change (optional):

Pushed to master (3ad879d)

Summary

JSON Output for RBTools Close Command

Review Request #11590 — Created April 11, 2021 and submitted 3 years, 4 months ago

Owner

Repository

RBTools

Branch

master

Bugs

Depends On

~~11521~~

Groups

People

Description*

Depends on JSON output object from r#11521.

JSON object includes:

review_request: id of review request being closed
review_request_status: new status of the review request

Testing Done

Ran unit tests in Commands and passed all tests

Commits

Summary	ID
Added review_request_id and review_request.status to JSON output	e4eea752a767258cb28e3859b7bea5d6404885d9
Added new line at end of close.py	6b2cd8c68dcca1099d72cc3d9ee9bfa446aa0300

Issues

Description	From	Last Updated
W292 no newline at end of file	reviewbot	3 years, 11 months ago
There are no open issues

flake8 failed.

JSHint passed.

rbtools/commands/close.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W292 no newline at end of file
```

Commits:

	Summary	ID
	Added review_request_id and review_request.status to JSON output	e4eea752a767258cb28e3859b7bea5d6404885d9
	Added review_request_id and review_request.status to JSON output	e4eea752a767258cb28e3859b7bea5d6404885d9
	Added new line at end of close.py	6b2cd8c68dcca1099d72cc3d9ee9bfa446aa0300

Diff:

flake8 passed.

JSHint passed.

rbtools/commands/close.py (Diff revision 1)