Update rust fmt for new tool support and code parse error handling.

Review Request #11577 — Created April 6, 2021 and updated

chipx86
ReviewBot
release-3.0.x
reviewbot

This updates RustfmtTool to subclass the newer BaseTool, and to use
the newer features it offers (dependencies, improved file extension
handling, and centralized base command building).

The new version of the tool also handles the case where a .rs file
can't be parsed due to a syntax error. Previously, we'd log the error
but the tool would claim it passed without issues. The new version
parses any error lines it finds and reports them as comments.

Unit tests pass on Python 2.7 and 3.x.

Summary
Update rust fmt for new tool support and code parse error handling.
Description From Last Updated

Copy-pasteo: pyflakes -> rustfmt

daviddavid
Checks run (2 succeeded)
flake8 passed.
JSHint passed.
david
  1. 
      
  2. bot/reviewbot/tools/rustfmt.py (Diff revision 1)
     
     

    Copy-pasteo: pyflakes -> rustfmt

  3. 
      
Loading...