Summary:

Update rust fmt for new tool support and code parse error handling.

Review Request #11577 — Created April 6, 2021 and submitted June 9, 2021, 1:07 a.m.

Information
Owner:	chipx86
Repository:	ReviewBot
Branch:	release-3.0.x
Bugs:
Depends On:
Reviewers
Groups:	reviewbot
People:

Description

This updates RustfmtTool to subclass the newer BaseTool, and to use
the newer features it offers (dependencies, improved file extension
handling, and centralized base command building).

The new version of the tool also handles the case where a .rs file
can't be parsed due to a syntax error. Previously, we'd log the error
but the tool would claim it passed without issues. The new version
parses any error lines it finds and reports them as comments.

Testing Done

Unit tests pass on Python 2.7 and 3.x.

Commits

Summary
	Update rust fmt for new tool support and code parse error handling.

Screenshots

Issues

Description	From	Last Updated
Copy-pasteo: pyflakes -> rustfmt	david	June 2, 2021, 6:24 p.m.

flake8 passed.

JSHint passed.

bot/reviewbot/tools/rustfmt.py (Diff revision 1)
Show all issues
```
Copy-pasteo: pyflakes -> rustfmt
```

Change Summary:

Fixed documentation to reference rustfmt instead of pyflakes.

Commits:

	Summary
-		Update rust fmt for new tool support and code parse error handling.
+		Update rust fmt for new tool support and code parse error handling.

Diff:

Revision 2 (+428 -82)

Show changes

	bot/reviewbot/tools/rustfmt.py
	bot/reviewbot/tools/tests/test_rustfmt.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (85a2360)