Summary

Update go fmt for new tool support and code parse error handling.

Review Request #11569 — Created April 2, 2021 and submitted June 2, 2021, 6:22 p.m.

Information

Owner

chipx86

Repository

ReviewBot

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

This updates GofmtTool to subclass the newer BaseTool, and to use
the newer features it offers (dependencies, improved file extension
handling, and centralized base command building).

The new version of the tool also handles the case where a .go file
can't be parsed. Previously, we'd log the error but the tool would claim
it passed without issues. The new version parses any error lines it
finds and reports them as comments.

Testing Done

Unit tests pass on Python 2.7 and 3.x.

Commits

Summary	ID
Update go fmt for new tool support and code parse error handling. This updates `GofmtTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved file extension handling, and centralized base command building). The new version of the tool also handles the case where a `.go` file can't be parsed. Previously, we'd log the error but the tool would claim it passed without issues. The new version parses any error lines it finds and reports them as comments.	2828889a3ace0d5f6e2dd2ea51122ea7d8180807

Summary

Update go fmt for new tool support and code parse error handling.

This updates `GofmtTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved file extension handling, and centralized base command building). The new version of the tool also handles the case where a `.go` file can't be parsed. Previously, we'd log the error but the tool would claim it passed without issues. The new version parses any error lines it finds and reports them as comments.

2828889a3ace0d5f6e2dd2ea51122ea7d8180807

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (3d64600)