Summary

Update cppcheck for new tool support and improve output parsing.

Review Request #11565 — Created March 30, 2021 and submitted June 2, 2021, 6:15 p.m.

Information

Owner

chipx86

Repository

ReviewBot

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

This updates CPPCheckTool to subclass the newer BaseTool, and to
use the newer features it offers (dependencies, improved configurable
file extension handling, centralized base command building, and
standardized column/severity/error code output).

The new version of the tool has safer error report parsing. The old
version used manual string parsing, and had the potential to get
confused. The new version uses a regex to better match lines.

There are a couple changes in behavior:

1) Comments on non-errors (those marked as style, performance, etc.) no
longer have issues turned off. We just use the default for the tool,
no matter what.

2) "Category" has been renamed to "Severity" and "Sub Category" to
"Error code" in the output.

Unit tests were added to cover the new parsing, and to provide
integration tests.

Testing Done

All unit tests pass on Python 2.7 and 3.x.

Commits

Summary	ID
Update cppcheck for new tool support and improve output parsing. This updates `CPPCheckTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved configurable file extension handling, centralized base command building, and standardized column/severity/error code output). The new version of the tool has safer error report parsing. The old version used manual string parsing, and had the potential to get confused. The new version uses a regex to better match lines. There are a couple changes in behavior: 1) Comments on non-errors (those marked as style, performance, etc.) no longer have issues turned off. We just use the default for the tool, no matter what. 2) "Category" has been renamed to "Severity" and "Sub Category" to "Error code" in the output. Unit tests were added to cover the new parsing, and to provide integration tests.	ec863b8e5ba1e4f863d5a98768107ccf75276ff7

Summary

Update cppcheck for new tool support and improve output parsing.

This updates `CPPCheckTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved configurable file extension handling, centralized base command building, and standardized column/severity/error code output). The new version of the tool has safer error report parsing. The old version used manual string parsing, and had the potential to get confused. The new version uses a regex to better match lines. There are a couple changes in behavior: 1) Comments on non-errors (those marked as style, performance, etc.) no longer have issues turned off. We just use the default for the tool, no matter what. 2) "Category" has been renamed to "Severity" and "Sub Category" to "Error code" in the output. Unit tests were added to cover the new parsing, and to provide integration tests.

ec863b8e5ba1e4f863d5a98768107ccf75276ff7

Issues

Description	From	Last Updated
E999 SyntaxError: invalid syntax	reviewbot	March 30, 2021, 6:24 p.m.

flake8 failed.

JSHint passed.

flake8

bot/reviewbot/tools/cppcheck.py (Diff revision 1)
Show all issues
```
E999 SyntaxError: invalid syntax
```

Change Summary:

Fixed a syntax error that didn't make it into the commit.

Commits:

	Summary	ID
	Update cppcheck for new tool support and improve output parsing. This updates `CPPCheckTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved configurable file extension handling, centralized base command building, and standardized column/severity/error code output). The new version of the tool has safer error report parsing. The old version used manual string parsing, and had the potential to get confused. The new version uses a regex to better match lines. There are a couple changes in behavior: 1) Comments on non-errors (those marked as style, performance, etc.) no longer have issues turned off. We just use the default for the tool, no matter what. 2) "Category" has been renamed to "Severity" and "Sub Category" to "Error code" in the output. Unit tests were added to cover the new parsing, and to provide integration tests.	ca8e8eee92d2842239b196a0ce50c689ccd1e660
	Update cppcheck for new tool support and improve output parsing. This updates `CPPCheckTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved configurable file extension handling, centralized base command building, and standardized column/severity/error code output). The new version of the tool has safer error report parsing. The old version used manual string parsing, and had the potential to get confused. The new version uses a regex to better match lines. There are a couple changes in behavior: 1) Comments on non-errors (those marked as style, performance, etc.) no longer have issues turned off. We just use the default for the tool, no matter what. 2) "Category" has been renamed to "Severity" and "Sub Category" to "Error code" in the output. Unit tests were added to cover the new parsing, and to provide integration tests.	6de60d8820931e8e1ea7f8109ee298a7abbe590e

Diff:

Revision 2 (+702 -170)

Show changes

	bot/reviewbot/tools/cppcheck.py
	bot/reviewbot/tools/tests/test_cppcheck.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Added some missing assertSpyCalledWith() assertions.

Commits:

	Summary	ID
	Update cppcheck for new tool support and improve output parsing. This updates `CPPCheckTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved configurable file extension handling, centralized base command building, and standardized column/severity/error code output). The new version of the tool has safer error report parsing. The old version used manual string parsing, and had the potential to get confused. The new version uses a regex to better match lines. There are a couple changes in behavior: 1) Comments on non-errors (those marked as style, performance, etc.) no longer have issues turned off. We just use the default for the tool, no matter what. 2) "Category" has been renamed to "Severity" and "Sub Category" to "Error code" in the output. Unit tests were added to cover the new parsing, and to provide integration tests.	6de60d8820931e8e1ea7f8109ee298a7abbe590e
	Update cppcheck for new tool support and improve output parsing. This updates `CPPCheckTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved configurable file extension handling, centralized base command building, and standardized column/severity/error code output). The new version of the tool has safer error report parsing. The old version used manual string parsing, and had the potential to get confused. The new version uses a regex to better match lines. There are a couple changes in behavior: 1) Comments on non-errors (those marked as style, performance, etc.) no longer have issues turned off. We just use the default for the tool, no matter what. 2) "Category" has been renamed to "Severity" and "Sub Category" to "Error code" in the output. Unit tests were added to cover the new parsing, and to provide integration tests.	ec863b8e5ba1e4f863d5a98768107ccf75276ff7

Diff:

Revision 3 (+810 -170)

Show changes

	bot/reviewbot/tools/cppcheck.py
	bot/reviewbot/tools/tests/test_cppcheck.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (7792343)