Summary:

Update doc8 for new tool support and more reliable output parsing.

Review Request #11562 — Created March 30, 2021 and submitted June 2, 2021, 6:15 p.m.

Information
Owner:	chipx86
Repository:	ReviewBot
Branch:	release-3.0.x
Bugs:
Depends On:
Reviewers
Groups:	reviewbot
People:

Description

This updates Doc8Tool to subclass the newer BaseTool, and to use the
newer features it offers (dependencies, improved configurable file
extension handling, centralized base command building, and standardized
error code output).

The new version of the tool has safer report parsing, using a regex
rather than manual string splitting and parsing to match lines. This
simplifies things quite a bit and avoids possible errors, or crashes if
doc8 changes output someday.

Unit tests were added to cover the new doc8 parsing, and to provide
integration tests.

Testing Done

Unit tests pass on Python 2.7 and 3.x.

Commits

Summary
	Update doc8 for new tool support and more reliable output parsing.

Screenshots

Issues

Description	From	Last Updated
E251 unexpected spaces around keyword / parameter equals	reviewbot	March 30, 2021, 1:34 a.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	March 30, 2021, 1:34 a.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	March 30, 2021, 1:34 a.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	March 30, 2021, 1:34 a.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	March 30, 2021, 1:34 a.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	March 30, 2021, 1:34 a.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	March 30, 2021, 1:34 a.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	March 30, 2021, 1:34 a.m.

flake8 failed.

JSHint passed.

flake8

bot/reviewbot/tools/tests/test_doc8.py (Diff revision 1)
Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
bot/reviewbot/tools/tests/test_doc8.py (Diff revision 1)
Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
bot/reviewbot/tools/tests/test_doc8.py (Diff revision 1)
Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
bot/reviewbot/tools/tests/test_doc8.py (Diff revision 1)
Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
bot/reviewbot/tools/tests/test_doc8.py (Diff revision 1)
Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
bot/reviewbot/tools/tests/test_doc8.py (Diff revision 1)
Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
bot/reviewbot/tools/tests/test_doc8.py (Diff revision 1)
Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
bot/reviewbot/tools/tests/test_doc8.py (Diff revision 1)
Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```

Change Summary:

Fixed a bad copy/paste leading to a keyword argument in keyword = value form.

Commits:

	Summary
-		Update doc8 for new tool support and more reliable output parsing.
+		Update doc8 for new tool support and more reliable output parsing.

Diff:

Revision 2 (+558 -74)

Show changes

	bot/reviewbot/tools/doc8.py
	bot/reviewbot/tools/tests/test_doc8.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Fixed a couple issues in a unit test docstring.

Commits:

	Summary
-		Update doc8 for new tool support and more reliable output parsing.
+		Update doc8 for new tool support and more reliable output parsing.

Diff:

Revision 3 (+558 -74)

Show changes

	bot/reviewbot/tools/doc8.py
	bot/reviewbot/tools/tests/test_doc8.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (74e5024)