Update doc8 for new tool support and more reliable output parsing.

Review Request #11562 — Created March 30, 2021 and updated

chipx86
ReviewBot
release-3.0.x
reviewbot

This updates Doc8Tool to subclass the newer BaseTool, and to use the
newer features it offers (dependencies, improved configurable file
extension handling, centralized base command building, and standardized
error code output).

The new version of the tool has safer report parsing, using a regex
rather than manual string splitting and parsing to match lines. This
simplifies things quite a bit and avoids possible errors, or crashes if
doc8 changes output someday.

Unit tests were added to cover the new doc8 parsing, and to provide
integration tests.

Unit tests pass on Python 2.7 and 3.x.

Summary
Update doc8 for new tool support and more reliable output parsing.
Description From Last Updated

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
chipx86
Review request changed

Change Summary:

Fixed a couple issues in a unit test docstring.

Commits:

Summary
-
Update doc8 for new tool support and more reliable output parsing.
+
Update doc8 for new tool support and more reliable output parsing.

Diff:

Revision 3 (+558 -74)

Show changes

Checks run (2 succeeded)

flake8 passed.
JSHint passed.
david
  1. Ship It!
  2. 
      
Loading...