[WIP] Visual Impairment Selector

Review Request #11559 — Created March 27, 2021 and updated

Information

Review Board
master

Reviewers

The visual impairment selector menu will provide reviewers the
opportunity to view an image with a filter applied that will
simulate specific visual impairment conditions that center on how
an indivudal percieves colour. This menu and the image resolution
menu will exist on an image menu toolbar below the caption to prevent
conflicts with long captions when the screen is small.

Currently the VIS has been modelled after the image resolution/zoom
menu. Images have been attached to demonstrate the different simulations
for the Achromatopsia, Deuteranopia, Protanopia, and Tritanopia
conditions in the Attachment, Onion Skin, Split and Two-Up image views.

Outstanding Tasks:
-Apply conditions to the "Difference" revision view
-Create the Presbyopia filter

For more details of the implementation that has been completed and the
outstanding tasks for the project please refer to my notion page of the
implementation progress of the project:
https://www.notion.so/reviewboard/Implementation-Progress-90c20f28cdfc4398a502e1496fc354ab

Manual testing was conducted on the attachment, two-up, split, and onion
skin view for the Achromatopsia, Deuteranopia, Protanopia, and Tritanopia
conditions

Summary ID Author
Initial image review menu setup
382076f51259d9cf35d4ef8308f29f70a415506e mderose123
Continued implementation of the visual impairment user interface menu
4ed7c79d9237eb4873d560e02d9090a988c366b1 mderose123
Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend
70286e017d6f2717da29eac440673f3491fcd3fa mderose123
Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu
6586e69cdd68f717d130ea1462115cd0a6adde40 mderose123
Added visual impairment simultor for attachment, two up and split diff view of image(s)
107841ed883b5c1a5e61fc67c8da6d9a019172d8 mderose123
Added visual impairment filters for the remaining image difference views
db7bc24885be1915570137cf2777b97125755f20 mderose123
Addendum removed unecessary comments
cae82d675a02e142ea780eda7f0a59dd3b2ac22c mderose123
Addendum Added missing semicolons
ac876a3e6b8ac9de249a4929cc3b08e01eeecae8 mderose123
Addendum removed incorrectly named method
7c5c15bd762b89125204e22be962320ef1fa33e3 mderose123
Addendum added missing less properties for canvases used
2638bee9bb02394583e11f26d46c667f2c0604dd mderose123
Addendum removed unneccessary spacess and reduced line length
8304a88c261569ee811877fc3aa659648883a5c0 mderose123
Referenced the source of scaling factors and matrices used to simulate various visual impairment conditions
7814775289819eae8b02181782806bbbc11527b8 mderose123
Addendum removed extra spaces
35ccc6fbcb7de02c1eac665358e11e5b45885f55 mderose123
Removed unneccessary class and commented out the Presbyopia VI Simulator Menu option
e57928ed2cca27fe0e2baf9c4e349a63c13b2b47 mderose123

Description From Last Updated

Col: 2 Missing semicolon.

reviewbotreviewbot

Col: 69 Missing semicolon.

reviewbotreviewbot

Col: 33 Missing semicolon.

reviewbotreviewbot

Col: 62 Missing semicolon.

reviewbotreviewbot

Col: 10 Missing semicolon.

reviewbotreviewbot

Col: 10 Missing semicolon.

reviewbotreviewbot

Col: 62 Missing semicolon.

reviewbotreviewbot

Col: 10 Missing semicolon.

reviewbotreviewbot

Col: 10 Missing semicolon.

reviewbotreviewbot

Col: 62 Missing semicolon.

reviewbotreviewbot

Col: 10 Missing semicolon.

reviewbotreviewbot

Col: 10 Missing semicolon.

reviewbotreviewbot

Col: 7 'ImageDiffView' is defined but never used.

reviewbotreviewbot

Col: 7 'ImageDiffView' is defined but never used.

reviewbotreviewbot

Col: 7 'ImageDiffView' is defined but never used.

reviewbotreviewbot
mderose
  1. 
      
  2. 
      
mderose
mderose
mderose
mderose
mderose
mderose
  1. 
      
  2. 
      
mderose
mderose
mderose
Review request changed
Commits:
Summary ID Author
Initial image review menu setup
382076f51259d9cf35d4ef8308f29f70a415506e mderose123
Continued implementation of the visual impairment user interface menu
4ed7c79d9237eb4873d560e02d9090a988c366b1 mderose123
Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend
70286e017d6f2717da29eac440673f3491fcd3fa mderose123
Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu
6586e69cdd68f717d130ea1462115cd0a6adde40 mderose123
Initial image review menu setup
382076f51259d9cf35d4ef8308f29f70a415506e mderose123
Continued implementation of the visual impairment user interface menu
4ed7c79d9237eb4873d560e02d9090a988c366b1 mderose123
Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend
70286e017d6f2717da29eac440673f3491fcd3fa mderose123
Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu
6586e69cdd68f717d130ea1462115cd0a6adde40 mderose123
Added visual impairment simultor for attachment, two up and split diff view of image(s)
107841ed883b5c1a5e61fc67c8da6d9a019172d8 mderose123
Added visual impairment filters for the remaining image difference views
db7bc24885be1915570137cf2777b97125755f20 mderose123
Addendum removed unecessary comments
cae82d675a02e142ea780eda7f0a59dd3b2ac22c mderose123

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

mderose
mderose
mderose
mderose
Review request changed
Description:
   

The visual impairment selector menu will provide reviewers the

    opportunity to view an image with a filter applied that will
    simulate specific visual impairment conditions that center on how
    an indivudal percieves colour. This menu and the image resolution
    menu will exist on an image menu toolbar below the caption to prevent
    conflicts with long captions when the screen is small.

   
   

Currently the VIS has been modelled after the image resolution/zoom

~   menu. Images have been attached to demonstrate what this menu looks
~   like in its default state (when the page is loaded) and when a condition
~   is clicked on.

  ~ menu. Images have been attached to demonstrate the different simulations
  ~ for the Achromatopsia, Deuteranopia, Protanopia, and Tritanopia
  ~ conditions in the Attachment, Onion Skin, Split and Two-Up image views.

  +
  +

Outstanding Tasks:

  + -Apply conditions to the "Difference" revision view
  + -Create the Presbyopia filter

Commits:
Summary ID Author
Initial image review menu setup
382076f51259d9cf35d4ef8308f29f70a415506e mderose123
Continued implementation of the visual impairment user interface menu
4ed7c79d9237eb4873d560e02d9090a988c366b1 mderose123
Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend
70286e017d6f2717da29eac440673f3491fcd3fa mderose123
Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu
6586e69cdd68f717d130ea1462115cd0a6adde40 mderose123
Added visual impairment simultor for attachment, two up and split diff view of image(s)
107841ed883b5c1a5e61fc67c8da6d9a019172d8 mderose123
Added visual impairment filters for the remaining image difference views
db7bc24885be1915570137cf2777b97125755f20 mderose123
Addendum removed unecessary comments
cae82d675a02e142ea780eda7f0a59dd3b2ac22c mderose123
Addendum Added missing semicolons
ac876a3e6b8ac9de249a4929cc3b08e01eeecae8 mderose123
Addendum removed incorrectly named method
7c5c15bd762b89125204e22be962320ef1fa33e3 mderose123
Addendum added missing less properties for canvases used
2638bee9bb02394583e11f26d46c667f2c0604dd mderose123
Initial image review menu setup
382076f51259d9cf35d4ef8308f29f70a415506e mderose123
Continued implementation of the visual impairment user interface menu
4ed7c79d9237eb4873d560e02d9090a988c366b1 mderose123
Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend
70286e017d6f2717da29eac440673f3491fcd3fa mderose123
Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu
6586e69cdd68f717d130ea1462115cd0a6adde40 mderose123
Added visual impairment simultor for attachment, two up and split diff view of image(s)
107841ed883b5c1a5e61fc67c8da6d9a019172d8 mderose123
Added visual impairment filters for the remaining image difference views
db7bc24885be1915570137cf2777b97125755f20 mderose123
Addendum removed unecessary comments
cae82d675a02e142ea780eda7f0a59dd3b2ac22c mderose123
Addendum Added missing semicolons
ac876a3e6b8ac9de249a4929cc3b08e01eeecae8 mderose123
Addendum removed incorrectly named method
7c5c15bd762b89125204e22be962320ef1fa33e3 mderose123
Addendum added missing less properties for canvases used
2638bee9bb02394583e11f26d46c667f2c0604dd mderose123
Addendum removed unneccessary spacess and reduced line length
8304a88c261569ee811877fc3aa659648883a5c0 mderose123
Removed Files:
Added Files:

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

mderose
Review request changed
Commits:
Summary ID Author
Initial image review menu setup
382076f51259d9cf35d4ef8308f29f70a415506e mderose123
Continued implementation of the visual impairment user interface menu
4ed7c79d9237eb4873d560e02d9090a988c366b1 mderose123
Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend
70286e017d6f2717da29eac440673f3491fcd3fa mderose123
Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu
6586e69cdd68f717d130ea1462115cd0a6adde40 mderose123
Added visual impairment simultor for attachment, two up and split diff view of image(s)
107841ed883b5c1a5e61fc67c8da6d9a019172d8 mderose123
Added visual impairment filters for the remaining image difference views
db7bc24885be1915570137cf2777b97125755f20 mderose123
Addendum removed unecessary comments
cae82d675a02e142ea780eda7f0a59dd3b2ac22c mderose123
Addendum Added missing semicolons
ac876a3e6b8ac9de249a4929cc3b08e01eeecae8 mderose123
Addendum removed incorrectly named method
7c5c15bd762b89125204e22be962320ef1fa33e3 mderose123
Addendum added missing less properties for canvases used
2638bee9bb02394583e11f26d46c667f2c0604dd mderose123
Addendum removed unneccessary spacess and reduced line length
8304a88c261569ee811877fc3aa659648883a5c0 mderose123
Initial image review menu setup
382076f51259d9cf35d4ef8308f29f70a415506e mderose123
Continued implementation of the visual impairment user interface menu
4ed7c79d9237eb4873d560e02d9090a988c366b1 mderose123
Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend
70286e017d6f2717da29eac440673f3491fcd3fa mderose123
Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu
6586e69cdd68f717d130ea1462115cd0a6adde40 mderose123
Added visual impairment simultor for attachment, two up and split diff view of image(s)
107841ed883b5c1a5e61fc67c8da6d9a019172d8 mderose123
Added visual impairment filters for the remaining image difference views
db7bc24885be1915570137cf2777b97125755f20 mderose123
Addendum removed unecessary comments
cae82d675a02e142ea780eda7f0a59dd3b2ac22c mderose123
Addendum Added missing semicolons
ac876a3e6b8ac9de249a4929cc3b08e01eeecae8 mderose123
Addendum removed incorrectly named method
7c5c15bd762b89125204e22be962320ef1fa33e3 mderose123
Addendum added missing less properties for canvases used
2638bee9bb02394583e11f26d46c667f2c0604dd mderose123
Addendum removed unneccessary spacess and reduced line length
8304a88c261569ee811877fc3aa659648883a5c0 mderose123
Referenced the source of scaling factors and matrices used to simulate various visual impairment conditions
7814775289819eae8b02181782806bbbc11527b8 mderose123

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

mderose
Review request changed
Commits:
Summary ID Author
Initial image review menu setup
382076f51259d9cf35d4ef8308f29f70a415506e mderose123
Continued implementation of the visual impairment user interface menu
4ed7c79d9237eb4873d560e02d9090a988c366b1 mderose123
Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend
70286e017d6f2717da29eac440673f3491fcd3fa mderose123
Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu
6586e69cdd68f717d130ea1462115cd0a6adde40 mderose123
Added visual impairment simultor for attachment, two up and split diff view of image(s)
107841ed883b5c1a5e61fc67c8da6d9a019172d8 mderose123
Added visual impairment filters for the remaining image difference views
db7bc24885be1915570137cf2777b97125755f20 mderose123
Addendum removed unecessary comments
cae82d675a02e142ea780eda7f0a59dd3b2ac22c mderose123
Addendum Added missing semicolons
ac876a3e6b8ac9de249a4929cc3b08e01eeecae8 mderose123
Addendum removed incorrectly named method
7c5c15bd762b89125204e22be962320ef1fa33e3 mderose123
Addendum added missing less properties for canvases used
2638bee9bb02394583e11f26d46c667f2c0604dd mderose123
Addendum removed unneccessary spacess and reduced line length
8304a88c261569ee811877fc3aa659648883a5c0 mderose123
Referenced the source of scaling factors and matrices used to simulate various visual impairment conditions
7814775289819eae8b02181782806bbbc11527b8 mderose123
Initial image review menu setup
382076f51259d9cf35d4ef8308f29f70a415506e mderose123
Continued implementation of the visual impairment user interface menu
4ed7c79d9237eb4873d560e02d9090a988c366b1 mderose123
Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend
70286e017d6f2717da29eac440673f3491fcd3fa mderose123
Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu
6586e69cdd68f717d130ea1462115cd0a6adde40 mderose123
Added visual impairment simultor for attachment, two up and split diff view of image(s)
107841ed883b5c1a5e61fc67c8da6d9a019172d8 mderose123
Added visual impairment filters for the remaining image difference views
db7bc24885be1915570137cf2777b97125755f20 mderose123
Addendum removed unecessary comments
cae82d675a02e142ea780eda7f0a59dd3b2ac22c mderose123
Addendum Added missing semicolons
ac876a3e6b8ac9de249a4929cc3b08e01eeecae8 mderose123
Addendum removed incorrectly named method
7c5c15bd762b89125204e22be962320ef1fa33e3 mderose123
Addendum added missing less properties for canvases used
2638bee9bb02394583e11f26d46c667f2c0604dd mderose123
Addendum removed unneccessary spacess and reduced line length
8304a88c261569ee811877fc3aa659648883a5c0 mderose123
Referenced the source of scaling factors and matrices used to simulate various visual impairment conditions
7814775289819eae8b02181782806bbbc11527b8 mderose123
Addendum removed extra spaces
35ccc6fbcb7de02c1eac665358e11e5b45885f55 mderose123

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

mderose
mderose
Review request changed
Description:
   

The visual impairment selector menu will provide reviewers the

    opportunity to view an image with a filter applied that will
    simulate specific visual impairment conditions that center on how
    an indivudal percieves colour. This menu and the image resolution
    menu will exist on an image menu toolbar below the caption to prevent
    conflicts with long captions when the screen is small.

   
   

Currently the VIS has been modelled after the image resolution/zoom

    menu. Images have been attached to demonstrate the different simulations
    for the Achromatopsia, Deuteranopia, Protanopia, and Tritanopia
    conditions in the Attachment, Onion Skin, Split and Two-Up image views.

   
   

Outstanding Tasks:

    -Apply conditions to the "Difference" revision view
    -Create the Presbyopia filter

  +
  +

For more details of the implementation that has been completed and the

  + outstanding tasks for the project please refer to my notion page of the
  + implementation progress of the project:
  + https://www.notion.so/reviewboard/Implementation-Progress-90c20f28cdfc4398a502e1496fc354ab

Testing Done:
  +

Manual testing was conducted on the attachment, two-up, split, and onion

  + skin view for the Achromatopsia, Deuteranopia, Protanopia, and Tritanopia
  + conditions