- Download Diff

Summary:

[WIP] Visual Impairment Selector

Review Request #11559 — Created March 27, 2021 and updated April 9, 2021, 9:43 p.m.

Information
Owner:	mderose
Repository:	Review Board
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	reviewboard, students
People:

Description

The visual impairment selector menu will provide reviewers the
opportunity to view an image with a filter applied that will
simulate specific visual impairment conditions that center on how
an indivudal percieves colour. This menu and the image resolution
menu will exist on an image menu toolbar below the caption to prevent
conflicts with long captions when the screen is small.

Currently the VIS has been modelled after the image resolution/zoom
menu. Images have been attached to demonstrate the different simulations
for the Achromatopsia, Deuteranopia, Protanopia, and Tritanopia
conditions in the Attachment, Onion Skin, Split and Two-Up image views.

Outstanding Tasks:
-Apply conditions to the "Difference" revision view
-Create the Presbyopia filter

For more details of the implementation that has been completed and the
outstanding tasks for the project please refer to my notion page of the
implementation progress of the project:
https://www.notion.so/reviewboard/Implementation-Progress-90c20f28cdfc4398a502e1496fc354ab

Testing Done

Manual testing was conducted on the attachment, two-up, split, and onion
skin view for the Achromatopsia, Deuteranopia, Protanopia, and Tritanopia
conditions

Commits

Summary	Author
Initial image review menu setup	mderose123
Continued implementation of the visual impairment user interface menu	mderose123
Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
Added visual impairment filters for the remaining image difference views	mderose123
Addendum removed unecessary comments	mderose123
Addendum Added missing semicolons	mderose123
Addendum removed incorrectly named method	mderose123
Addendum added missing less properties for canvases used	mderose123
Addendum removed unneccessary spacess and reduced line length	mderose123
Referenced the source of scaling factors and matrices used to simulate various visual impairment conditions	mderose123
Addendum removed extra spaces	mderose123
Removed unneccessary class and commented out the Presbyopia VI Simulator Menu option	mderose123

Screenshots

Files

Issues

Description	From	Last Updated
Col: 2 Missing semicolon.	reviewbot	April 6, 2021, 5:52 p.m.
Col: 69 Missing semicolon.	reviewbot	April 6, 2021, 5:52 p.m.
Col: 33 Missing semicolon.	reviewbot	April 6, 2021, 5:52 p.m.
Col: 62 Missing semicolon.	reviewbot	April 6, 2021, 5:52 p.m.
Col: 10 Missing semicolon.	reviewbot	April 6, 2021, 5:52 p.m.
Col: 10 Missing semicolon.	reviewbot	April 6, 2021, 5:52 p.m.
Col: 62 Missing semicolon.	reviewbot	April 6, 2021, 5:52 p.m.
Col: 10 Missing semicolon.	reviewbot	April 6, 2021, 5:52 p.m.
Col: 10 Missing semicolon.	reviewbot	April 6, 2021, 5:52 p.m.
Col: 62 Missing semicolon.	reviewbot	April 6, 2021, 5:52 p.m.
Col: 10 Missing semicolon.	reviewbot	April 6, 2021, 5:52 p.m.
Col: 10 Missing semicolon.	reviewbot	April 6, 2021, 5:52 p.m.
Col: 7 'ImageDiffView' is defined but never used.	reviewbot	April 9, 2021, 1:28 p.m.
Col: 7 'ImageDiffView' is defined but never used.	reviewbot	April 9, 2021, 1:28 p.m.
Col: 7 'ImageDiffView' is defined but never used.	reviewbot	April 9, 2021, 1:28 p.m.

flake8 passed.

JSHint passed.

Commits:

	Summary	Author
-	Initial image review menu setup	mderose123
+	Initial image review menu setup	mderose123
+	Continued implementation of the visual impairment user interface menu	mderose123
+	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123

Diff:

Revision 2 (+232 -102)

Show changes

	.browserslistrc
	reviewboard/static/rb/css/pages/image-review-ui.less
	reviewboard/static/rb/css/ui/buttons.less
	reviewboard/static/rb/js/models/imageReviewableModel.es6.js
	reviewboard/static/rb/js/views/draftReviewBannerView.es6.js
	reviewboard/static/rb/js/views/imageReviewableView.es6.js
	reviewboard/static/rb/js/views/tests/draftReviewBannerViewTests.es6.js
	reviewboard/templates/reviews/reviewable_base.html

Added Files:

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

~		Test
	~	The visual impairment selector menu will provide reviewers the
	+	opportunity to view an image with a filter applied that will
	+	simulate specific visual impairment conditions that center on how
	+	an indivudal percieves colour.

Groups:

+	students

Description:

		The visual impairment selector menu will provide reviewers the
		opportunity to view an image with a filter applied that will
		simulate specific visual impairment conditions that center on how
		an indivudal percieves colour.
	+
	+	Currently the VIS has been modelled after the image resolution/zoom
	+	menu. Images have been attached to demonstrate what this menu looks
	+	like in its default state (when the page is loaded) and when a condition
	+	is clicked on.

Description:

		The visual impairment selector menu will provide reviewers the
		opportunity to view an image with a filter applied that will
		simulate specific visual impairment conditions that center on how
~		an indivudal percieves colour.
	~	an indivudal percieves colour. This menu and the image resolution
	+	menu will exist on an image menu toolbar below the caption to prevent
	+	conflicts with long captions when the screen is small.

		Currently the VIS has been modelled after the image resolution/zoom
		menu. Images have been attached to demonstrate what this menu looks
		like in its default state (when the page is loaded) and when a condition
		is clicked on.

Commits:

	Summary	Author
-	Initial image review menu setup	mderose123
-	Continued implementation of the visual impairment user interface menu	mderose123
-	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
+	Initial image review menu setup	mderose123
+	Continued implementation of the visual impairment user interface menu	mderose123
+	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
+	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123

Diff:

Revision 3 (+223 -81)

Show changes

	reviewboard/static/rb/css/pages/image-review-ui.less
	reviewboard/static/rb/js/models/imageReviewableModel.es6.js
	reviewboard/static/rb/js/views/imageReviewableView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Removed Files:
Added Files:

Removed Files:
Added Files:

Commits:

	Summary	Author
-	Initial image review menu setup	mderose123
-	Continued implementation of the visual impairment user interface menu	mderose123
-	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
-	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
+	Initial image review menu setup	mderose123
+	Continued implementation of the visual impairment user interface menu	mderose123
+	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
+	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
+	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
+	Added visual impairment filters for the remaining image difference views	mderose123
+	Addendum removed unecessary comments	mderose123

Diff:

Revision 4 (+2300 -294)

Show changes

	reviewboard/static/rb/css/pages/image-review-ui.less
	reviewboard/static/rb/js/models/imageReviewableModel.es6.js
	reviewboard/static/rb/js/views/imageReviewableView.es6.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 4)
Show all issues
```
Col: 2
 Missing semicolon.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 4)
Show all issues
```
Col: 69
 Missing semicolon.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 4)
Show all issues
```
Col: 33
 Missing semicolon.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 4)
Show all issues
```
Col: 62
 Missing semicolon.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 4)
Show all issues
```
Col: 10
 Missing semicolon.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 4)
Show all issues
```
Col: 10
 Missing semicolon.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 4)
Show all issues
```
Col: 62
 Missing semicolon.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 4)
Show all issues
```
Col: 10
 Missing semicolon.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 4)
Show all issues
```
Col: 10
 Missing semicolon.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 4)
Show all issues
```
Col: 62
 Missing semicolon.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 4)
Show all issues
```
Col: 10
 Missing semicolon.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 4)
Show all issues
```
Col: 10
 Missing semicolon.
```

Commits:

	Summary	Author
-	Initial image review menu setup	mderose123
-	Continued implementation of the visual impairment user interface menu	mderose123
-	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
-	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
-	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
-	Added visual impairment filters for the remaining image difference views	mderose123
-	Addendum removed unecessary comments	mderose123
+	Initial image review menu setup	mderose123
+	Continued implementation of the visual impairment user interface menu	mderose123
+	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
+	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
+	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
+	Added visual impairment filters for the remaining image difference views	mderose123
+	Addendum removed unecessary comments	mderose123
+	Addendum Added missing semicolons	mderose123

Diff:

Revision 5 (+2312 -306)

Show changes

	reviewboard/static/rb/css/pages/image-review-ui.less
	reviewboard/static/rb/js/models/imageReviewableModel.es6.js
	reviewboard/static/rb/js/views/imageReviewableView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	Author
-	Initial image review menu setup	mderose123
-	Continued implementation of the visual impairment user interface menu	mderose123
-	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
-	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
-	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
-	Added visual impairment filters for the remaining image difference views	mderose123
-	Addendum removed unecessary comments	mderose123
-	Addendum Added missing semicolons	mderose123
+	Initial image review menu setup	mderose123
+	Continued implementation of the visual impairment user interface menu	mderose123
+	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
+	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
+	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
+	Added visual impairment filters for the remaining image difference views	mderose123
+	Addendum removed unecessary comments	mderose123
+	Addendum Added missing semicolons	mderose123
+	Addendum removed incorrectly named method	mderose123

Diff:

Revision 6 (+2312 -306)

Show changes

	reviewboard/static/rb/css/pages/image-review-ui.less
	reviewboard/static/rb/js/models/imageReviewableModel.es6.js
	reviewboard/static/rb/js/views/imageReviewableView.es6.js

Added Files:

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	Author
-	Initial image review menu setup	mderose123
-	Continued implementation of the visual impairment user interface menu	mderose123
-	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
-	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
-	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
-	Added visual impairment filters for the remaining image difference views	mderose123
-	Addendum removed unecessary comments	mderose123
-	Addendum Added missing semicolons	mderose123
-	Addendum removed incorrectly named method	mderose123
+	Initial image review menu setup	mderose123
+	Continued implementation of the visual impairment user interface menu	mderose123
+	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
+	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
+	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
+	Added visual impairment filters for the remaining image difference views	mderose123
+	Addendum removed unecessary comments	mderose123
+	Addendum Added missing semicolons	mderose123
+	Addendum removed incorrectly named method	mderose123
+	Addendum added missing less properties for canvases used	mderose123

Diff:

Revision 7 (+2324 -306)

Show changes

	reviewboard/static/rb/css/pages/image-review-ui.less
	reviewboard/static/rb/js/models/imageReviewableModel.es6.js
	reviewboard/static/rb/js/views/imageReviewableView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

		The visual impairment selector menu will provide reviewers the
		opportunity to view an image with a filter applied that will
		simulate specific visual impairment conditions that center on how
		an indivudal percieves colour. This menu and the image resolution
		menu will exist on an image menu toolbar below the caption to prevent
		conflicts with long captions when the screen is small.

		Currently the VIS has been modelled after the image resolution/zoom
~		menu. Images have been attached to demonstrate what this menu looks
~		like in its default state (when the page is loaded) and when a condition
~		is clicked on.
	~	menu. Images have been attached to demonstrate the different simulations
	~	for the Achromatopsia, Deuteranopia, Protanopia, and Tritanopia
	~	conditions in the Attachment, Onion Skin, Split and Two-Up image views.
	+
	+	Outstanding Tasks:
	+	-Apply conditions to the "Difference" revision view
	+	-Create the Presbyopia filter

Commits:

	Summary	Author
-	Initial image review menu setup	mderose123
-	Continued implementation of the visual impairment user interface menu	mderose123
-	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
-	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
-	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
-	Added visual impairment filters for the remaining image difference views	mderose123
-	Addendum removed unecessary comments	mderose123
-	Addendum Added missing semicolons	mderose123
-	Addendum removed incorrectly named method	mderose123
-	Addendum added missing less properties for canvases used	mderose123
+	Initial image review menu setup	mderose123
+	Continued implementation of the visual impairment user interface menu	mderose123
+	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
+	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
+	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
+	Added visual impairment filters for the remaining image difference views	mderose123
+	Addendum removed unecessary comments	mderose123
+	Addendum Added missing semicolons	mderose123
+	Addendum removed incorrectly named method	mderose123
+	Addendum added missing less properties for canvases used	mderose123
+	Addendum removed unneccessary spacess and reduced line length	mderose123

Diff:

Revision 8 (+2854 -424)

Show changes

	reviewboard/static/rb/css/pages/image-review-ui.less
	reviewboard/static/rb/js/models/imageReviewableModel.es6.js
	reviewboard/static/rb/js/views/imageReviewableView.es6.js

Removed Files:

Added Files:

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 8)
Show all issues
```
Col: 7
 'ImageDiffView' is defined but never used.
```

Commits:

	Summary	Author
-	Initial image review menu setup	mderose123
-	Continued implementation of the visual impairment user interface menu	mderose123
-	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
-	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
-	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
-	Added visual impairment filters for the remaining image difference views	mderose123
-	Addendum removed unecessary comments	mderose123
-	Addendum Added missing semicolons	mderose123
-	Addendum removed incorrectly named method	mderose123
-	Addendum added missing less properties for canvases used	mderose123
-	Addendum removed unneccessary spacess and reduced line length	mderose123
+	Initial image review menu setup	mderose123
+	Continued implementation of the visual impairment user interface menu	mderose123
+	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
+	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
+	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
+	Added visual impairment filters for the remaining image difference views	mderose123
+	Addendum removed unecessary comments	mderose123
+	Addendum Added missing semicolons	mderose123
+	Addendum removed incorrectly named method	mderose123
+	Addendum added missing less properties for canvases used	mderose123
+	Addendum removed unneccessary spacess and reduced line length	mderose123
+	Referenced the source of scaling factors and matrices used to simulate various visual impairment conditions	mderose123

Diff:

Revision 9 (+2890 -424)

Show changes

	reviewboard/static/rb/css/pages/image-review-ui.less
	reviewboard/static/rb/js/models/imageReviewableModel.es6.js
	reviewboard/static/rb/js/views/imageReviewableView.es6.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 9)
Show all issues
```
Col: 7
 'ImageDiffView' is defined but never used.
```

Commits:

	Summary	Author
-	Initial image review menu setup	mderose123
-	Continued implementation of the visual impairment user interface menu	mderose123
-	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
-	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
-	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
-	Added visual impairment filters for the remaining image difference views	mderose123
-	Addendum removed unecessary comments	mderose123
-	Addendum Added missing semicolons	mderose123
-	Addendum removed incorrectly named method	mderose123
-	Addendum added missing less properties for canvases used	mderose123
-	Addendum removed unneccessary spacess and reduced line length	mderose123
-	Referenced the source of scaling factors and matrices used to simulate various visual impairment conditions	mderose123
+	Initial image review menu setup	mderose123
+	Continued implementation of the visual impairment user interface menu	mderose123
+	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
+	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
+	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
+	Added visual impairment filters for the remaining image difference views	mderose123
+	Addendum removed unecessary comments	mderose123
+	Addendum Added missing semicolons	mderose123
+	Addendum removed incorrectly named method	mderose123
+	Addendum added missing less properties for canvases used	mderose123
+	Addendum removed unneccessary spacess and reduced line length	mderose123
+	Referenced the source of scaling factors and matrices used to simulate various visual impairment conditions	mderose123
+	Addendum removed extra spaces	mderose123

Diff:

Revision 10 (+2955 -495)

Show changes

	reviewboard/static/rb/css/pages/image-review-ui.less
	reviewboard/static/rb/js/models/imageReviewableModel.es6.js
	reviewboard/static/rb/js/views/imageReviewableView.es6.js

Checks run (1 failed, 1 succeeded)

flake8 passed.

JSHint failed.

JSHint

reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 10)
Show all issues
```
Col: 7
 'ImageDiffView' is defined but never used.
```

Commits:

	Summary	Author
-	Initial image review menu setup	mderose123
-	Continued implementation of the visual impairment user interface menu	mderose123
-	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
-	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
-	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
-	Added visual impairment filters for the remaining image difference views	mderose123
-	Addendum removed unecessary comments	mderose123
-	Addendum Added missing semicolons	mderose123
-	Addendum removed incorrectly named method	mderose123
-	Addendum added missing less properties for canvases used	mderose123
-	Addendum removed unneccessary spacess and reduced line length	mderose123
-	Referenced the source of scaling factors and matrices used to simulate various visual impairment conditions	mderose123
-	Addendum removed extra spaces	mderose123
+	Initial image review menu setup	mderose123
+	Continued implementation of the visual impairment user interface menu	mderose123
+	Created a visual impairment condition selector modelled after the image resolution menu and created the image-review-menu class that both the visual impairment menu and image resolution menu now extend	mderose123
+	Addendum added a space before declaration of the minimum width in the image-resolution-menu and the rb-c-visual-impairment-menu	mderose123
+	Added visual impairment simultor for attachment, two up and split diff view of image(s)	mderose123
+	Added visual impairment filters for the remaining image difference views	mderose123
+	Addendum removed unecessary comments	mderose123
+	Addendum Added missing semicolons	mderose123
+	Addendum removed incorrectly named method	mderose123
+	Addendum added missing less properties for canvases used	mderose123
+	Addendum removed unneccessary spacess and reduced line length	mderose123
+	Referenced the source of scaling factors and matrices used to simulate various visual impairment conditions	mderose123
+	Addendum removed extra spaces	mderose123
+	Removed unneccessary class and commented out the Presbyopia VI Simulator Menu option	mderose123

Diff:

Revision 11 (+2734 -694)

Show changes

	reviewboard/static/rb/css/pages/image-review-ui.less
	reviewboard/static/rb/js/models/imageReviewableModel.es6.js
	reviewboard/static/rb/js/views/imageReviewableView.es6.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

		The visual impairment selector menu will provide reviewers the
		opportunity to view an image with a filter applied that will
		simulate specific visual impairment conditions that center on how
		an indivudal percieves colour. This menu and the image resolution
		menu will exist on an image menu toolbar below the caption to prevent
		conflicts with long captions when the screen is small.

		Currently the VIS has been modelled after the image resolution/zoom
		menu. Images have been attached to demonstrate the different simulations
		for the Achromatopsia, Deuteranopia, Protanopia, and Tritanopia
		conditions in the Attachment, Onion Skin, Split and Two-Up image views.

		Outstanding Tasks:
		-Apply conditions to the "Difference" revision view
		-Create the Presbyopia filter
	+
	+	For more details of the implementation that has been completed and the
	+	outstanding tasks for the project please refer to my notion page of the
	+	implementation progress of the project:
	+	https://www.notion.so/reviewboard/Implementation-Progress-90c20f28cdfc4398a502e1496fc354ab

Testing Done:

	+	Manual testing was conducted on the attachment, two-up, split, and onion
	+	skin view for the Achromatopsia, Deuteranopia, Protanopia, and Tritanopia
	+	conditions

You have a pending review.

[WIP] Visual Impairment Selector

Commits:

Diff:

Added Files:

Checks run (2 succeeded)

Description:

Groups:

Description:

Description:

Commits:

Diff:

Checks run (2 succeeded)

Removed Files:

Added Files:

Removed Files:

Added Files:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

JSHint

Commits:

Diff:

Checks run (2 succeeded)

Commits:

Diff:

Added Files:

Checks run (2 succeeded)

Commits:

Diff:

Checks run (2 succeeded)

Description:

Commits:

Diff:

Removed Files:

Added Files:

Checks run (1 failed, 1 succeeded)

JSHint

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

JSHint

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

JSHint

Commits:

Diff:

Checks run (2 succeeded)

Description:

Testing Done: