Update pycodestyle for new tool support and more reliable output parsing.

 






 

 


  Review Request #11551
  —
  Created March 23, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  ReviewBot
 









 
 

  release-3.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewbot
 









 
 

  
 






 








 





  


 
 

  
This updates PycodestyleTool to subclass the newer BaseTool, and to use

the newer features it offers (dependencies, improved centralized base

command building, and standardized error code/column output).


The output from pycodestyle is now explicitly set, so we won't be

susceptible to any changes in pycodestyle in the future.


Unit tests were added to cover the new parsing, and to peform

integration testing with the command line tool.

 








  


 
 

  
Unit tests pass on Python 2.7 and 3.x.

 







 









 





  








 




 







   

    
    
Diff Revision 2


This is not the most recent revision of the diff. The latest diff is revision 3. See what's changed.

    

 

 

 

 
orig
1
2
3

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Update pycodestyle for new tool support and more reliable output parsing.
     
This updates `PycodestyleTool` to subclass the newer `BaseTool`, and to use
the newer features it offers (dependencies, improved centralized base
command building, and standardized error code/column output).

The output from `pycodestyle` is now explicitly set, so we won't be
susceptible to any changes in `pycodestyle` in the future.

Unit tests were added to cover the new parsing, and to peform
integration testing with the command line tool.

    

   
  		
  c6969ad07ef57b9608ebc3539dc03931843c9b42
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      bot/reviewbot/tools/pycodestyle.py
     
    

   
  

 



 

  

   
    

     
      
      bot/reviewbot/tools/tests/test_pycodestyle.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...