Summary

Update pycodestyle for new tool support and more reliable output parsing.

Review Request #11551 — Created March 23, 2021 and submitted March 25, 2021, 4:12 p.m.

Information

Owner

chipx86

Repository

ReviewBot

Branch

release-3.0.x

Bugs

Depends On

Reviewers

Groups

reviewbot

People

Description

This updates PycodestyleTool to subclass the newer BaseTool, and to use
the newer features it offers (dependencies, improved centralized base
command building, and standardized error code/column output).

The output from pycodestyle is now explicitly set, so we won't be
susceptible to any changes in pycodestyle in the future.

Unit tests were added to cover the new parsing, and to peform
integration testing with the command line tool.

Testing Done

Unit tests pass on Python 2.7 and 3.x.

Commits

Summary	ID
Update pycodestyle for new tool support and more reliable output parsing. This updates `PycodestyleTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved centralized base command building, and standardized error code/column output). The output from `pycodestyle` is now explicitly set, so we won't be susceptible to any changes in `pycodestyle` in the future. Unit tests were added to cover the new parsing, and to peform integration testing with the command line tool.	52554a344a404ab49170be340603aac00b6de428

Summary

Update pycodestyle for new tool support and more reliable output parsing.

This updates `PycodestyleTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved centralized base command building, and standardized error code/column output). The output from `pycodestyle` is now explicitly set, so we won't be susceptible to any changes in `pycodestyle` in the future. Unit tests were added to cover the new parsing, and to peform integration testing with the command line tool.

52554a344a404ab49170be340603aac00b6de428

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:


Removed the unwanted double quotes around pycodestyle.
Added integration unit tests.

Description:

		This updates `PycodestyleTool` to subclass the newer `BaseTool`, and to use
		the newer features it offers (dependencies, improved centralized base
		command building, and standardized error code/column output).

		The output from `pycodestyle` is now explicitly set, so we won't be
		susceptible to any changes in `pycodestyle` in the future.

~		Unit tests were added to cover the new parsing.
	~	Unit tests were added to cover the new parsing, and to peform
	+	integration testing with the command line tool.

Commits:

	Summary	ID
	Update pycodestyle for new tool support and more reliable output parsing. This updates `PycodestyleTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved centralized base command building, and standardized error code/column output). The output from `pycodestyle` is now explicitly set, so we won't be susceptible to any changes in `pycodestyle` in the future. Unit tests were added to cover the new parsing.	7ae158b6d6bfca4261d7343e440b33e1c653ba8a
	Update pycodestyle for new tool support and more reliable output parsing. This updates `PycodestyleTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved centralized base command building, and standardized error code/column output). The output from `pycodestyle` is now explicitly set, so we won't be susceptible to any changes in `pycodestyle` in the future. Unit tests were added to cover the new parsing, and to peform integration testing with the command line tool.	c6969ad07ef57b9608ebc3539dc03931843c9b42

Diff:

Revision 2 (+518 -74)

Show changes

	bot/reviewbot/tools/pycodestyle.py
	bot/reviewbot/tools/tests/test_pycodestyle.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Fixed the integration test docstrings.

Commits:

	Summary	ID
	Update pycodestyle for new tool support and more reliable output parsing. This updates `PycodestyleTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved centralized base command building, and standardized error code/column output). The output from `pycodestyle` is now explicitly set, so we won't be susceptible to any changes in `pycodestyle` in the future. Unit tests were added to cover the new parsing, and to peform integration testing with the command line tool.	c6969ad07ef57b9608ebc3539dc03931843c9b42
	Update pycodestyle for new tool support and more reliable output parsing. This updates `PycodestyleTool` to subclass the newer `BaseTool`, and to use the newer features it offers (dependencies, improved centralized base command building, and standardized error code/column output). The output from `pycodestyle` is now explicitly set, so we won't be susceptible to any changes in `pycodestyle` in the future. Unit tests were added to cover the new parsing, and to peform integration testing with the command line tool.	52554a344a404ab49170be340603aac00b6de428

Diff:

Revision 3 (+528 -74)

Show changes

	bot/reviewbot/tools/pycodestyle.py
	bot/reviewbot/tools/tests/test_pycodestyle.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (8c0a063)