Summary

abc

Review Request #11523 — Created March 14, 2021 and discarded March 14, 2021, 1:49 p.m.

Information

Owner

qianxi

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.


[WIP]Add api.py file, forget to stage this file in the last commit.


[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.


Refactor methods in api class. Now support use --header option to add customized header in a request.


[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings


Remove redundant print statements from api-get.py


Fix coding style problems.


Fix more coding style problems.


Add a newline character.


Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.


Api testing

Testing Done

12312312312kkk3

Commits

Summary	ID
Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
Add a newline character.	3058676f474918449c806faea1fe1787e168e659
Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e

Issues

Description	From	Last Updated
W291 trailing whitespace	reviewbot	March 14, 2021, 1:44 p.m.
W293 blank line contains whitespace	reviewbot	March 14, 2021, 1:44 p.m.
W291 trailing whitespace	reviewbot	March 14, 2021, 1:44 p.m.
W291 trailing whitespace	reviewbot	March 14, 2021, 1:44 p.m.
W293 blank line contains whitespace	reviewbot	March 14, 2021, 1:44 p.m.
E305 expected 2 blank lines after class or function definition, found 0	reviewbot	March 14, 2021, 1:44 p.m.
E261 at least two spaces before inline comment	reviewbot	March 14, 2021, 1:44 p.m.
E262 inline comment should start with '# '	reviewbot	March 14, 2021, 1:44 p.m.
E302 expected 2 blank lines, found 1	reviewbot	March 14, 2021, 1:44 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 14, 2021, 1:44 p.m.
W291 trailing whitespace	reviewbot	March 14, 2021, 1:44 p.m.
W291 trailing whitespace	reviewbot	March 14, 2021, 1:44 p.m.
W291 trailing whitespace	reviewbot	March 14, 2021, 1:44 p.m.
F401 'rbtools.utils.appdirs.user_config_dir' imported but unused	reviewbot	March 14, 2021, 1:44 p.m.
W293 blank line contains whitespace	reviewbot	March 14, 2021, 1:44 p.m.
F401 'rbtools.utils.appdirs.user_config_dir' imported but unused	reviewbot	March 14, 2021, 1:44 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 14, 2021, 1:44 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/api/request.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
rbtools/api/request.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```
rbtools/api/request.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
rbtools/api/request.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
rbtools/api/request.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```

rbtools/api/request.py (Diff revision 1)

Show all issues

E305 expected 2 blank lines after class or function definition, found 0

rbtools/api/tests/test_http_request.py (Diff revision 1)
Show all issues
```
E261 at least two spaces before inline comment
```
rbtools/api/tests/test_http_request.py (Diff revision 1)
Show all issues
```
E262 inline comment should start with '# '
```
rbtools/api/tests/test_http_request.py (Diff revision 1)
Show all issues
```
E302 expected 2 blank lines, found 1
```
rbtools/api/tests/test_http_request.py (Diff revision 1)
Show all issues
```
E501 line too long (80 > 79 characters)
```
rbtools/api/tests/test_http_request.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
rbtools/api/tests/test_http_request.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
rbtools/api/tests/test_http_request.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```

rbtools/commands/setup_repo.py (Diff revision 1)

Show all issues

F401 'rbtools.utils.appdirs.user_config_dir' imported but unused

rbtools/commands/setup_repo.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/tests/test_setup_repo.py (Diff revision 1)
Show all issues
```
F401 'rbtools.utils.appdirs.user_config_dir' imported but unused
```

rbtools/utils/filesystem.py (Diff revision 1)

Show all issues

E127 continuation line over-indented for visual indent

Review Board 6.0.1 alpha 0 (dev)

abc

Information

Reviewers

flake8

Status: Discarded