flake8
-
rbtools/clients/__init__.py (Diff revision 1) Show all issues -
Review Request #11520 — Created March 12, 2021 and submitted
RepositoryInfo
had two old flags for indicating support for features,
supports_changesets
andsupports_parent_diffs
. Having these in
theRepositoryInfo
class was weird, since we have a bunch of other
support flags that live on theSCMClient
class. Whether a client
supports these isn't something that might change from repository to
repository, so these should live on the client too.This change moves those flags over. Unfortunately, unlike a lot of the
recent cleanups, this isn't something that can be done in a soft
deprecation. It seems pretty unlikely that there are custom SCMClient
implementations floating around which use these, but just in case, if
they try to use it after upgrading to RBTools 3.0, it'll spit out a
useful error message telling them how to fix it.
Ran unit tests.
Summary | ID |
---|---|
d0f7498a683486bcbd8449f3da537b12d72b8f93 |
Description | From | Last Updated |
---|---|---|
F821 undefined name 'CommandError' |
reviewbot | |
F821 undefined name 'CommandError' |
reviewbot | |
Can you add Type: to each of these? |
chipx86 | |
Can you add Version Added and Type here (in that order)? |
chipx86 | |
Rather than outright quit, can we have this raise an exception instead? That'll be a lot nicer on anyone who … |
chipx86 | |
To avoid any confusion, let's say "must instead set the supports_changesets attribute on the class." |
chipx86 | |
Same note here. |
chipx86 | |
While here, can we move this to super()? |
chipx86 |
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+116 -82) |
rbtools/clients/__init__.py (Diff revision 2) |
---|
Can you add
Version Added
andType
here (in that order)?
rbtools/clients/__init__.py (Diff revision 2) |
---|
Rather than outright quit, can we have this raise an exception instead? That'll be a lot nicer on anyone who may hit this.
Same below.
rbtools/clients/__init__.py (Diff revision 2) |
---|
To avoid any confusion, let's say "must instead set the supports_changesets attribute on the class."
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+250 -82) |