Summary

Move support flags out of RepositoryInfo into SCMClient.

Review Request #11520 — Created March 12, 2021 and submitted March 28, 2021, 10:32 a.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

RepositoryInfo had two old flags for indicating support for features,

supports_changesets and supports_parent_diffs. Having these in

the RepositoryInfo class was weird, since we have a bunch of other

support flags that live on the SCMClient class. Whether a client

supports these isn't something that might change from repository to

repository, so these should live on the client too.
This change moves those flags over. Unfortunately, unlike a lot of the

recent cleanups, this isn't something that can be done in a soft

deprecation. It seems pretty unlikely that there are custom SCMClient

implementations floating around which use these, but just in case, if

they try to use it after upgrading to RBTools 3.0, it'll spit out a

useful error message telling them how to fix it.

Testing Done

Ran unit tests.

Commits

Summary	ID
Move support flags out of RepositoryInfo into SCMClient. `RepositoryInfo` had two old flags for indicating support for features, `supports_changesets` and `supports_parent_diffs`. Having these in the `RepositoryInfo` class was weird, since we have a bunch of other support flags that live on the `SCMClient` class. Whether a client supports these isn't something that might change from repository to repository, so these should live on the client too. This change moves those flags over. Unfortunately, unlike a lot of the recent cleanups, this isn't something that can be done in a soft deprecation. It seems pretty unlikely that there are custom SCMClient implementations floating around which use these, but just in case, if they try to use it after upgrading to RBTools 3.0, it'll spit out a useful error message telling them how to fix it. Testing Done: Ran unit tests.	d0f7498a683486bcbd8449f3da537b12d72b8f93

Summary

Move support flags out of RepositoryInfo into SCMClient.

`RepositoryInfo` had two old flags for indicating support for features, `supports_changesets` and `supports_parent_diffs`. Having these in the `RepositoryInfo` class was weird, since we have a bunch of other support flags that live on the `SCMClient` class. Whether a client supports these isn't something that might change from repository to repository, so these should live on the client too. This change moves those flags over. Unfortunately, unlike a lot of the recent cleanups, this isn't something that can be done in a soft deprecation. It seems pretty unlikely that there are custom SCMClient implementations floating around which use these, but just in case, if they try to use it after upgrading to RBTools 3.0, it'll spit out a useful error message telling them how to fix it. Testing Done: Ran unit tests.

d0f7498a683486bcbd8449f3da537b12d72b8f93

Issues

Description	From	Last Updated
F821 undefined name 'CommandError'	reviewbot	March 15, 2021, 2:44 p.m.
F821 undefined name 'CommandError'	reviewbot	March 15, 2021, 2:44 p.m.
Can you add Type: to each of these?	chipx86	March 23, 2021, 11:02 p.m.
Can you add Version Added and Type here (in that order)?	chipx86	March 23, 2021, 11:02 p.m.
Rather than outright quit, can we have this raise an exception instead? That'll be a lot nicer on anyone who …	chipx86	March 23, 2021, 11:05 p.m.
To avoid any confusion, let's say "must instead set the supports_changesets attribute on the class."	chipx86	March 23, 2021, 11:04 p.m.
Same note here.	chipx86	March 23, 2021, 11:04 p.m.
While here, can we move this to super()?	chipx86	March 28, 2021, 10:32 a.m.

flake8 failed.

JSHint passed.

flake8

rbtools/clients/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'CommandError'
```
rbtools/clients/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'CommandError'
```

Commits:

	Summary	ID
	Move support flags out of RepositoryInfo into SCMClient. `RepositoryInfo` had two old flags for indicating support for features, `supports_changesets` and `supports_parent_diffs`. Having these in the `RepositoryInfo` class was weird, since we have a bunch of other support flags that live on the `SCMClient` class. Whether a client supports these isn't something that might change from repository to repository, so these should live on the client too. This change moves those flags over. Unfortunately, unlike a lot of the recent cleanups, this isn't something that can be done in a soft deprecation. It seems pretty unlikely that there are custom SCMClient implementations floating around which use these, but just in case, if they try to use it after upgrading to RBTools 3.0, it'll spit out a useful error message telling them how to fix it. Testing Done: Ran unit tests.	316ab1f06d40502ffa29404a9d57e2c799b3c99d
	Move support flags out of RepositoryInfo into SCMClient. `RepositoryInfo` had two old flags for indicating support for features, `supports_changesets` and `supports_parent_diffs`. Having these in the `RepositoryInfo` class was weird, since we have a bunch of other support flags that live on the `SCMClient` class. Whether a client supports these isn't something that might change from repository to repository, so these should live on the client too. This change moves those flags over. Unfortunately, unlike a lot of the recent cleanups, this isn't something that can be done in a soft deprecation. It seems pretty unlikely that there are custom SCMClient implementations floating around which use these, but just in case, if they try to use it after upgrading to RBTools 3.0, it'll spit out a useful error message telling them how to fix it. Testing Done: Ran unit tests.	e36bde23f6815e441356bc9233949df43287c045

Diff:

Revision 2 (+116 -82)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/bazaar.py
	rbtools/clients/clearcase.py
	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/plastic.py
	rbtools/clients/svn.py
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

rbtools/clients/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you add Type: to each of these?
```
rbtools/clients/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can you add Version Added and Type here (in that order)?
```

rbtools/clients/__init__.py (Diff revision 2)

The issue has been resolved. Show all issues

Rather than outright quit, can we have this raise an exception instead? That'll be a lot nicer on anyone who may hit this.

Same below.

rbtools/clients/__init__.py (Diff revision 2)

The issue has been resolved. Show all issues

To avoid any confusion, let's say "must instead set the supports_changesets attribute on the class."

rbtools/clients/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Same note here.
```

Commits:

	Summary	ID
	Move support flags out of RepositoryInfo into SCMClient. `RepositoryInfo` had two old flags for indicating support for features, `supports_changesets` and `supports_parent_diffs`. Having these in the `RepositoryInfo` class was weird, since we have a bunch of other support flags that live on the `SCMClient` class. Whether a client supports these isn't something that might change from repository to repository, so these should live on the client too. This change moves those flags over. Unfortunately, unlike a lot of the recent cleanups, this isn't something that can be done in a soft deprecation. It seems pretty unlikely that there are custom SCMClient implementations floating around which use these, but just in case, if they try to use it after upgrading to RBTools 3.0, it'll spit out a useful error message telling them how to fix it. Testing Done: Ran unit tests.	e36bde23f6815e441356bc9233949df43287c045
	Move support flags out of RepositoryInfo into SCMClient. `RepositoryInfo` had two old flags for indicating support for features, `supports_changesets` and `supports_parent_diffs`. Having these in the `RepositoryInfo` class was weird, since we have a bunch of other support flags that live on the `SCMClient` class. Whether a client supports these isn't something that might change from repository to repository, so these should live on the client too. This change moves those flags over. Unfortunately, unlike a lot of the recent cleanups, this isn't something that can be done in a soft deprecation. It seems pretty unlikely that there are custom SCMClient implementations floating around which use these, but just in case, if they try to use it after upgrading to RBTools 3.0, it'll spit out a useful error message telling them how to fix it. Testing Done: Ran unit tests.	d0f7498a683486bcbd8449f3da537b12d72b8f93

Diff:

Revision 3 (+250 -82)

Show changes

	rbtools/clients/__init__.py
	rbtools/clients/bazaar.py
	rbtools/clients/clearcase.py
	rbtools/clients/git.py
	rbtools/clients/mercurial.py
	rbtools/clients/perforce.py
	rbtools/clients/plastic.py
	rbtools/clients/svn.py
	5 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

rbtools/clients/clearcase.py (Diff revision 3)
The issue has been resolved. Show all issues
```
While here, can we move this to super()?
```

Status:: Completed
Change Summary:: Pushed to master (e55e0b6)