Adding Review Commands

 






 

 


  Review Request #11502
  —
  Created March 3, 2021 and discarded  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  amohapatra
 









 
 

  RBTools
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
We'd like to add a new command to RBTools for performing reviews, which

itself would actually be several commands. This might be useful for some

users who are super heavy command-line users, and would definitely be

useful for people who want to add automation of various sorts (such as

adding reviews after running custom CI tools that we don't have

integrations for). This review request is dependent upon the JSON output object from r#11521.

 








  


 
 

  
Manually tested all commands so far and documented on Notion. Also added and ran new tests in rbtools/commands/tests/test_review.py.

 







 









 





  








 




 







   

    
    
Changes between revision 28 and 29



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Adding helpful hints for rbt commands
     
RBTools current must scan the filesystem when a user does not specify a
repository name or repository type which is very slow. In order to optimize
RBTools, we will log hints that recommends setting repository name or type
when it already has not been specified. An option --no-hints is added so
users can disable hints if desired.

I ran ./tests/runtests.py rbtools/ and have 263 tests passing and have done
manual testing on different rbtools commands to ensure that the --no-hints
option is working and is also presented as a global option to the user when
they type .

    

   
  		
  f476ee907f86595e0cb8b34fe6412641ed35157b
  anahita-m
 


 
  
 
 
  
   
    

     [WIP] Adding Review Commands
     
We'd like to add a new command to RBTools for performing reviews, which
itself would actually be several commands. This might be useful for some
users who are super heavy command-line users, and would definitely be
useful for people who want to add automation of various sorts (such as
adding reviews after running custom CI tools that we don't have
integrations for).

    

   
  		
  4d965957f5cf3844fb9f5491949e3a4169a47d91
  anahita-m
 


 
  
 
 
  
   
    

     [WIP] Adding Review Commands
     
We'd like to add a new command to RBTools for performing reviews, which
itself would actually be several commands. This might be useful for some
users who are super heavy command-line users, and would definitely be
useful for people who want to add automation of various sorts (such as
adding reviews after running custom CI tools that we don't have
integrations for).

    

   
  		
  1af7b76735880743668361c1948703444a698748
  anahita-m
 


 
  
 
 
  
   
    
Adding subcommand class and restructuring review command with subparsers

   
  		
  47712bc2b2d49190b841fe97e4266511ac870742
  anahita-m
 


 
  
 
 
  
   
    
fixing flake8 issues on test_review.py

   
  		
  0edcd34d84c0c769bc7e5381b9ac8d60698f3518
  anahita-m
 


 
  
 
 
  
   
    
Added misssing options for File Attachment Comments

   
  		
  d9b7b1304c35c596af90b8a9043884aca220caee
  anahita-m
 


 
  
 
 
  
   
    
Editing review tests based off command restructuring

   
  		
  2b7db12273ca222863f9c1f98d3b51e9ecfbbbd9
  anahita-m
 


 
  
 
 
  
   
    
Adding repository, server, and global options to subparsers as well

   
  		
  b7511b79eb538f19d569b8260bce7d86de0a1da5
  anahita-m
 


 
  
 
 
  
   
    
ensuring that empty comments can't be added

   
  		
  1373b3d26d834fa1a3d6412606c683459e6bc2f8
  anahita-m
 


 
  
 
 
  
   
    
adding temporary a check for an empty review so that empty reviews cannot be ...

   
  		
  337290f1dd6f62f80a8e579221947c52974764a4
  anahita-m
 


 
  
 
 
  
   
    
adding temporary a check for an empty review so that empty reviews cannot be ...

   
  		
  7745522b8daf3587aad16fb6095a9693cfebf5ce
  anahita-m
 


 
  
 
 
  
   
    

     Adding helpful hints for rbt commands
     
RBTools current must scan the filesystem when a user does not specify a
repository name or repository type which is very slow. In order to optimize
RBTools, we will log hints that recommends setting repository name or type
when it already has not been specified. An option --no-hints is added so
users can disable hints if desired.

I ran ./tests/runtests.py rbtools/ and have 263 tests passing and have done
manual testing on different rbtools commands to ensure that the --no-hints
option is working and is also presented as a global option to the user when
they type .

    

   
  		
  71326e2dc6bc97a01030de44affe588b9f21a7e1
  anahita-m
 


 
  
 
 
  
   
    

     [WIP] Adding Review Commands
     
We'd like to add a new command to RBTools for performing reviews, which
itself would actually be several commands. This might be useful for some
users who are super heavy command-line users, and would definitely be
useful for people who want to add automation of various sorts (such as
adding reviews after running custom CI tools that we don't have
integrations for).

    

   
  		
  195de49d5a5ce6b1979556f85ed9b31b0e7da06a
  anahita-m
 


 
  
 
 
  
   
    

     [WIP] Adding Review Commands
     
We'd like to add a new command to RBTools for performing reviews, which
itself would actually be several commands. This might be useful for some
users who are super heavy command-line users, and would definitely be
useful for people who want to add automation of various sorts (such as
adding reviews after running custom CI tools that we don't have
integrations for).

    

   
  		
  3c36f63b5ae8e656f55c01d0ce335bf119e9a61b
  anahita-m
 


 
  
 
 
  
   
    
Adding subcommand class and restructuring review command with subparsers

   
  		
  5f802fb4a6be325044800fb4cf7d757314dde9ac
  anahita-m
 


 
  
 
 
  
   
    
fixing flake8 issues on test_review.py

   
  		
  d064c6470393a840b48132175529c84efe9be196
  anahita-m
 


 
  
 
 
  
   
    
Added misssing options for File Attachment Comments

   
  		
  7b70b35e7fed9cb97c0219d277d3d91270d6e95f
  anahita-m
 


 
  
 
 
  
   
    
Editing review tests based off command restructuring

   
  		
  5ec4fdc3608d67ab2698ed0cf94684b06170171b
  anahita-m
 


 
  
 
 
  
   
    
Adding repository, server, and global options to subparsers as well

   
  		
  84c9bc49e456170fc573aae84d1d9289363d6640
  anahita-m
 


 
  
 
 
  
   
    
ensuring that empty comments can't be added

   
  		
  d04c4bc18e0c5cd2b3f3e175a9832bcd66603c26
  anahita-m
 


 
  
 
 
  
   
    
adding temporary a check for an empty review so that empty reviews cannot be ...

   
  		
  d1fb4c9b4a2ac41622e2d069dbc1df728af79b54
  anahita-m
 


 
  
 
 
  
   
    
adding temporary a check for an empty review so that empty reviews cannot be ...

   
  		
  4f7bb7547af17cd64280cf65f701139cf5e0e446
  anahita-m
 


 
  
 
 
  
   
    
Adding --json output on subparsers

   
  		
  1e5f3c0a3e1dab8ba83e98dfe756d37ef46841ea
  anahita-m
 


 
  
 
 
  
   
    
fixing flake8 issues

   
  		
  8401d70d9ff2f9c17ebe5d472fa85e950da12b4d
  anahita-m
 


 
  
 
 
  
   
    
fixing error message for matching files > 1 for add-diff-comment subcommand t...

   
  		
  81c91d321e6acdb7f74d7a58d1fd478f946c38c9
  anahita-m
 


 
  
 
 
  
   
    
fixing flake8 issues in __init__.py

   
  		
  74be2931d947a5d9865b4ad05809ad49d6c1215d
  anahita-m
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/commands/__init__.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/commands/review.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...