Adding Review Commands

Review Request #11502 — Created March 3, 2021 and discarded

amohapatra
RBTools
master
rbtools

We'd like to add a new command to RBTools for performing reviews, which
itself would actually be several commands. This might be useful for some
users who are super heavy command-line users, and would definitely be
useful for people who want to add automation of various sorts (such as
adding reviews after running custom CI tools that we don't have
integrations for). This review request is dependent upon the JSON output object from r#11521.

Manually tested all commands so far and documented on Notion. Also added and ran new tests in rbtools/commands/tests/test_review.py.

Summary Author
Adding helpful hints for rbt commands
anahita-m
[WIP] Adding Review Commands
anahita-m
[WIP] Adding Review Commands
anahita-m
Adding subcommand class and restructuring review command with subparsers
anahita-m
fixing flake8 issues on test_review.py
anahita-m
Added misssing options for File Attachment Comments
anahita-m
Editing review tests based off command restructuring
anahita-m
Adding repository, server, and global options to subparsers as well
anahita-m
ensuring that empty comments can't be added
anahita-m
adding temporary a check for an empty review so that empty reviews cannot be published
anahita-m
adding temporary a check for an empty review so that empty reviews cannot be published
anahita-m
Adding --json output on subparsers
anahita-m
fixing flake8 issues
anahita-m
fixing error message for matching files > 1 for add-diff-comment subcommand to include the passed filename
anahita-m
fixing flake8 issues in __init__.py
anahita-m
making minor edit to error message
anahita-m
Description From Last Updated

testComment1

amohapatraamohapatra

F401 'rbtools.commands.Option' imported but unused

reviewbotreviewbot

F401 'rbtools.utils.review_request.get_revisions' imported but unused

reviewbotreviewbot

F401 'rbtools.utils.review_request.guess_existing_review_request' imported but unused

reviewbotreviewbot

F401 'rbtools.utils.review_request.get_draft_or_current_value' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 0

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

F841 local variable 'review' is assigned to but never used

reviewbotreviewbot

F821 undefined name 'e'

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E225 missing whitespace around operator

reviewbotreviewbot

E501 line too long (106 > 79 characters)

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

F401 'rbtools.commands.Option' imported but unused

reviewbotreviewbot

F401 'rbtools.utils.review_request.get_revisions' imported but unused

reviewbotreviewbot

F401 'rbtools.utils.review_request.guess_existing_review_request' imported but unused

reviewbotreviewbot

F401 'rbtools.utils.review_request.get_draft_or_current_value' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 0

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

F841 local variable 'review' is assigned to but never used

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

E501 line too long (106 > 79 characters)

reviewbotreviewbot

E225 missing whitespace around operator

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

F821 undefined name 'e'

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E122 continuation line missing indentation or outdented

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

E501 line too long (82 > 79 characters)

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F841 local variable 'review_draft' is assigned to but never used

reviewbotreviewbot

F841 local variable 'e' is assigned to but never used

reviewbotreviewbot

F841 local variable 'e' is assigned to but never used

reviewbotreviewbot

F841 local variable 'review_draft' is assigned to but never used

reviewbotreviewbot

F841 local variable 'e' is assigned to but never used

reviewbotreviewbot

E303 too many blank lines (4)

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F841 local variable 'e' is assigned to but never used

reviewbotreviewbot

F841 local variable 'e' is assigned to but never used

reviewbotreviewbot

F841 local variable 'review' is assigned to but never used

reviewbotreviewbot

F841 local variable 'e' is assigned to but never used

reviewbotreviewbot

E501 line too long (85 > 79 characters)

reviewbotreviewbot

E501 line too long (120 > 79 characters)

reviewbotreviewbot

F841 local variable 'e' is assigned to but never used

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (85 > 79 characters)

reviewbotreviewbot

E225 missing whitespace around operator

reviewbotreviewbot

E225 missing whitespace around operator

reviewbotreviewbot

E225 missing whitespace around operator

reviewbotreviewbot

E225 missing whitespace around operator

reviewbotreviewbot

E225 missing whitespace around operator

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (94 > 79 characters)

reviewbotreviewbot

E501 line too long (81 > 79 characters)

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

E501 line too long (90 > 79 characters)

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E501 line too long (98 > 79 characters)

reviewbotreviewbot

E501 line too long (84 > 79 characters)

reviewbotreviewbot

E501 line too long (83 > 79 characters)

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E722 do not use bare except'

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E722 do not use bare except'

reviewbotreviewbot

E225 missing whitespace around operator

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E225 missing whitespace around operator

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E999 IndentationError: expected an indented block

reviewbotreviewbot

E112 expected an indented block

reviewbotreviewbot

E113 unexpected indentation

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

This should be in sentence case. But even better would be to use option groups to keep things together. See ...

daviddavid

When we include short options, we only do single characters. Given how rare it is to set a review footer, ...

daviddavid

Maybe -h here?

daviddavid

These two options are for all types of comments, not just general comments.

daviddavid

Help text should be in sentence case. This should probably also mention that if not specified, the comment will cover ...

daviddavid

I don't think this one needs a short option.

daviddavid

If we don't use -f for file attachments, let's use it for this one.

daviddavid

I don't think this one needs a short option.

daviddavid

Method docstrings should be written in the imperative mood ("Discard a review draft"). There's also an extra space between the ...

daviddavid

This text needs to come before the "Args" section.

daviddavid

This should be a comment (#) rather than a string.

daviddavid

This should be a comment (#) rather than a string.

daviddavid

Same comments about the docstring here.

daviddavid

This should be a comment (#) rather than a string.

daviddavid

Same comments about the docstring.

daviddavid

I feel like it might be nicer to set default=None for these options, and then only include them in the ...

daviddavid

E122 continuation line missing indentation or outdented

reviewbotreviewbot

Hi Anahita, one little thing I noticed from your code is that you are using """""" for comments. Last time ...

qianxiqianxi

Let's wrap this a little differently to make it a bit more compact: raise CommandError( '...' '...')

daviddavid

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E201 whitespace after '('

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E131 continuation line unaligned for hanging indent

reviewbotreviewbot

E265 block comment should start with '# '

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

F401 'rbtools.commands.CommandError' imported but unused

reviewbotreviewbot

F401 'rbtools.commands.post.Post' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (128 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E303 too many blank lines (2)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (133 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (118 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (109 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot

W503 line break before binary operator

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m

Diff:

Revision 2 (+179 -75)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m

Diff:

Revision 4 (+194 -90)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m

Diff:

Revision 6 (+219 -91)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m

Diff:

Revision 7 (+219 -91)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m

Diff:

Revision 9 (+219 -91)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m

Diff:

Revision 11 (+267 -99)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m

Diff:

Revision 12 (+503 -101)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m

Diff:

Revision 13 (+519 -101)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m

Diff:

Revision 15 (+624 -106)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m

Diff:

Revision 17 (+714 -106)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m

Diff:

Revision 18 (+818 -106)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m

Diff:

Revision 19 (+1026 -106)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m

Diff:

Revision 20 (+1030 -106)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

qianxi
  1. 
      
  2. rbtools/commands/review.py (Diff revision 20)
     
     

    Hi Anahita, one little thing I noticed from your code is that you are using """""" for comments. Last time I remember David told me that we should mainly use # comments in our code but use """""" comments for docstring like function description, args, raise errors and return at the beginning of each function.

  3. 
      
amohapatra
  1. this is a review header
  2. testComment1
  3. testComment1
  4. setup.py (Diff revision 20)
     
     
    testComment2
  5. this is a review footer
amohapatra
  1. 
      
  2. 
      
amohapatra
  1. 
      
  2. 
      
amohapatra
  1. None
  2. None
amohapatra
  1. this is a review header
  2. this is a review footer
amohapatra
  1. this is a review header
  2. testDemoComment1
  3. setup.py (Diff revision 20)
     
     
    testDemoCommentDiff
  4. this is a review footer
amohapatra
  1. demo
  2. None
amohapatra
  1. demo
  2. None
amohapatra
  1. this is a review header demo
  2. testCommentDemo1
  3. setup.py (Diff revision 20)
     
     
    testDemoDiffComment2
  4. this is a review footer demo
amohapatra
  1. this is a demo of review header
  2. demoGeneralComment
  3. setup.py (Diff revision 20)
     
     
    demoDiffComment
  4. this is a demo of review footer
david
  1. This is looking pretty solid. There are a few stylistic things related to docstrings that I marked, and a lot of places where you're using triple-quoted strings which instead should be comments (using #).

  2. rbtools/commands/review.py (Diff revision 20)
     
     

    This should be in sentence case.

    But even better would be to use option groups to keep things together. See commands/post.py for an example.

  3. rbtools/commands/review.py (Diff revision 20)
     
     

    When we include short options, we only do single characters. Given how rare it is to set a review footer, I think thisk one probably doesn't need a short version.

  4. rbtools/commands/review.py (Diff revision 20)
     
     

    Maybe -h here?

  5. rbtools/commands/review.py (Diff revision 20)
     
     

    These two options are for all types of comments, not just general comments.

  6. rbtools/commands/review.py (Diff revision 20)
     
     

    Help text should be in sentence case. This should probably also mention that if not specified, the comment will cover a single line.

  7. rbtools/commands/review.py (Diff revision 20)
     
     

    I don't think this one needs a short option.

  8. rbtools/commands/review.py (Diff revision 20)
     
     

    If we don't use -f for file attachments, let's use it for this one.

  9. rbtools/commands/review.py (Diff revision 20)
     
     

    I don't think this one needs a short option.

  10. rbtools/commands/review.py (Diff revision 20)
     
     

    Method docstrings should be written in the imperative mood ("Discard a review draft"). There's also an extra space between the """ and the description.

  11. rbtools/commands/review.py (Diff revision 20)
     
     

    This text needs to come before the "Args" section.

  12. rbtools/commands/review.py (Diff revision 20)
     
     
     
     
     

    This should be a comment (#) rather than a string.

  13. rbtools/commands/review.py (Diff revision 20)
     
     
     
     

    This should be a comment (#) rather than a string.

  14. rbtools/commands/review.py (Diff revision 20)
     
     

    Same comments about the docstring here.

  15. rbtools/commands/review.py (Diff revision 20)
     
     
     
     
     

    This should be a comment (#) rather than a string.

  16. rbtools/commands/review.py (Diff revision 20)
     
     

    Same comments about the docstring.

  17. rbtools/commands/review.py (Diff revision 20)
     
     
     
     
     
     
     

    I feel like it might be nicer to set default=None for these options, and then only include them in the API requests to create/update the review if they're non-None.

  18. rbtools/commands/review.py (Diff revision 20)
     
     
     
     
     
     
     

    Let's wrap this a little differently to make it a bit more compact:

    raise CommandError(
        '...'
        '...')
    
  19. 
      
amohapatra
Review request changed

Change Summary:

Fixing docustring and comment formatting. Organized options via option groups. Added some basic tests. Added check for multiple matches for file name.

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
fixing docustring formatting and creating option groups
anahita-m
+
fixing spacing errors
anahita-m

Diff:

Revision 21 (+1467 -463)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
Review request changed

Summary:

-[WIP] Adding Review Commands
+Adding Review Commands

Testing Done:

  +

Manually tested all commands so far and documented on Notion

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
fixing docustring formatting and creating option groups
anahita-m
-
fixing spacing errors
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
Adding subcommand class and restructuring review command with subparsers
anahita-m

Diff:

Revision 22 (+2286 -452)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
amohapatra
amohapatra
amohapatra
amohapatra
amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
Adding subcommand class and restructuring review command with subparsers
anahita-m
-
fixing flake8 issues on test_review.py
anahita-m
-
Added misssing options for File Attachment Comments
anahita-m
-
Editing review tests based off command restructuring
anahita-m
-
Adding repository, server, and global options to subparsers as well
anahita-m
-
ensuring that empty comments can't be added
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
Adding subcommand class and restructuring review command with subparsers
anahita-m
+
fixing flake8 issues on test_review.py
anahita-m
+
Added misssing options for File Attachment Comments
anahita-m
+
Editing review tests based off command restructuring
anahita-m
+
Adding repository, server, and global options to subparsers as well
anahita-m
+
ensuring that empty comments can't be added
anahita-m
+
adding temporary a check for an empty review so that empty reviews cannot be published
anahita-m
+
adding temporary a check for an empty review so that empty reviews cannot be published
anahita-m

Diff:

Revision 28 (+2478 -520)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
Review request changed

Description:

   

We'd like to add a new command to RBTools for performing reviews, which

    itself would actually be several commands. This might be useful for some
    users who are super heavy command-line users, and would definitely be
    useful for people who want to add automation of various sorts (such as
    adding reviews after running custom CI tools that we don't have
~   integrations for).

  ~ integrations for). This review request is dependent upon the JSON output object from r#11521.

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
Adding subcommand class and restructuring review command with subparsers
anahita-m
-
fixing flake8 issues on test_review.py
anahita-m
-
Added misssing options for File Attachment Comments
anahita-m
-
Editing review tests based off command restructuring
anahita-m
-
Adding repository, server, and global options to subparsers as well
anahita-m
-
ensuring that empty comments can't be added
anahita-m
-
adding temporary a check for an empty review so that empty reviews cannot be published
anahita-m
-
adding temporary a check for an empty review so that empty reviews cannot be published
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
Adding subcommand class and restructuring review command with subparsers
anahita-m
+
fixing flake8 issues on test_review.py
anahita-m
+
Added misssing options for File Attachment Comments
anahita-m
+
Editing review tests based off command restructuring
anahita-m
+
Adding repository, server, and global options to subparsers as well
anahita-m
+
ensuring that empty comments can't be added
anahita-m
+
adding temporary a check for an empty review so that empty reviews cannot be published
anahita-m
+
adding temporary a check for an empty review so that empty reviews cannot be published
anahita-m
+
Adding --json output on subparsers
anahita-m
+
fixing flake8 issues
anahita-m
+
fixing error message for matching files > 1 for add-diff-comment subcommand to include the passed filename
anahita-m
+
fixing flake8 issues in __init__.py
anahita-m

Diff:

Revision 29 (+2636 -572)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

amohapatra
amohapatra
Review request changed

Commits:

Summary Author
-
Adding helpful hints for rbt commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
[WIP] Adding Review Commands
anahita-m
-
Adding subcommand class and restructuring review command with subparsers
anahita-m
-
fixing flake8 issues on test_review.py
anahita-m
-
Added misssing options for File Attachment Comments
anahita-m
-
Editing review tests based off command restructuring
anahita-m
-
Adding repository, server, and global options to subparsers as well
anahita-m
-
ensuring that empty comments can't be added
anahita-m
-
adding temporary a check for an empty review so that empty reviews cannot be published
anahita-m
-
adding temporary a check for an empty review so that empty reviews cannot be published
anahita-m
-
Adding --json output on subparsers
anahita-m
-
fixing flake8 issues
anahita-m
-
fixing error message for matching files > 1 for add-diff-comment subcommand to include the passed filename
anahita-m
-
fixing flake8 issues in __init__.py
anahita-m
+
Adding helpful hints for rbt commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
[WIP] Adding Review Commands
anahita-m
+
Adding subcommand class and restructuring review command with subparsers
anahita-m
+
fixing flake8 issues on test_review.py
anahita-m
+
Added misssing options for File Attachment Comments
anahita-m
+
Editing review tests based off command restructuring
anahita-m
+
Adding repository, server, and global options to subparsers as well
anahita-m
+
ensuring that empty comments can't be added
anahita-m
+
adding temporary a check for an empty review so that empty reviews cannot be published
anahita-m
+
adding temporary a check for an empty review so that empty reviews cannot be published
anahita-m
+
Adding --json output on subparsers
anahita-m
+
fixing flake8 issues
anahita-m
+
fixing error message for matching files > 1 for add-diff-comment subcommand to include the passed filename
anahita-m
+
fixing flake8 issues in __init__.py
anahita-m
+
making minor edit to error message
anahita-m

Diff:

Revision 30 (+2639 -575)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
Review request changed

Status: Discarded

Loading...