Adding Review Commands

 






 

 


  Review Request #11502
  —
  Created March 3, 2021 and discarded  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  amohapatra
 









 
 

  RBTools
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
We'd like to add a new command to RBTools for performing reviews, which

itself would actually be several commands. This might be useful for some

users who are super heavy command-line users, and would definitely be

useful for people who want to add automation of various sorts (such as

adding reviews after running custom CI tools that we don't have

integrations for). This review request is dependent upon the JSON output object from r#11521.

 








  


 
 

  
Manually tested all commands so far and documented on Notion. Also added and ran new tests in rbtools/commands/tests/test_review.py.

 







 









 





  








 




 







   

    
    
Changes between revision 27 and 28



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Adding helpful hints for rbt commands
     
RBTools current must scan the filesystem when a user does not specify a
repository name or repository type which is very slow. In order to optimize
RBTools, we will log hints that recommends setting repository name or type
when it already has not been specified. An option --no-hints is added so
users can disable hints if desired.

I ran ./tests/runtests.py rbtools/ and have 263 tests passing and have done
manual testing on different rbtools commands to ensure that the --no-hints
option is working and is also presented as a global option to the user when
they type .

    

   
  		
  63e8bbcf704b383e8c9b6cf7d83a0c21f12ab372
  anahita-m
 


 
  
 
 
  
   
    

     [WIP] Adding Review Commands
     
We'd like to add a new command to RBTools for performing reviews, which
itself would actually be several commands. This might be useful for some
users who are super heavy command-line users, and would definitely be
useful for people who want to add automation of various sorts (such as
adding reviews after running custom CI tools that we don't have
integrations for).

    

   
  		
  4be43a13c38a3c93efdf5a7bf57703f4c5e17485
  anahita-m
 


 
  
 
 
  
   
    

     [WIP] Adding Review Commands
     
We'd like to add a new command to RBTools for performing reviews, which
itself would actually be several commands. This might be useful for some
users who are super heavy command-line users, and would definitely be
useful for people who want to add automation of various sorts (such as
adding reviews after running custom CI tools that we don't have
integrations for).

    

   
  		
  ba2432ef24061fc247fde8176ca43c5754ea0fa0
  anahita-m
 


 
  
 
 
  
   
    
Adding subcommand class and restructuring review command with subparsers

   
  		
  47ea0c349af3fad6def195e0454c13be9e21f5b6
  anahita-m
 


 
  
 
 
  
   
    
fixing flake8 issues on test_review.py

   
  		
  ecd12d4a6c108b75324416937c70324b1d69253d
  anahita-m
 


 
  
 
 
  
   
    
Added misssing options for File Attachment Comments

   
  		
  8452d7a6dd850593028455a3f421ea1c251d510c
  anahita-m
 


 
  
 
 
  
   
    
Editing review tests based off command restructuring

   
  		
  6ca62ba88fdf80ecda869be22176f74e4fe8ce49
  anahita-m
 


 
  
 
 
  
   
    
Adding repository, server, and global options to subparsers as well

   
  		
  c5b9492c6a0ab8f22407b69e49c6694b7ce9c78d
  anahita-m
 


 
  
 
 
  
   
    
ensuring that empty comments can't be added

   
  		
  cda23b8ca6b7a7c8377d7a02a46cba89709c20cf
  anahita-m
 


 
  
 
 
  
   
    

     Adding helpful hints for rbt commands
     
RBTools current must scan the filesystem when a user does not specify a
repository name or repository type which is very slow. In order to optimize
RBTools, we will log hints that recommends setting repository name or type
when it already has not been specified. An option --no-hints is added so
users can disable hints if desired.

I ran ./tests/runtests.py rbtools/ and have 263 tests passing and have done
manual testing on different rbtools commands to ensure that the --no-hints
option is working and is also presented as a global option to the user when
they type .

    

   
  		
  f476ee907f86595e0cb8b34fe6412641ed35157b
  anahita-m
 


 
  
 
 
  
   
    

     [WIP] Adding Review Commands
     
We'd like to add a new command to RBTools for performing reviews, which
itself would actually be several commands. This might be useful for some
users who are super heavy command-line users, and would definitely be
useful for people who want to add automation of various sorts (such as
adding reviews after running custom CI tools that we don't have
integrations for).

    

   
  		
  4d965957f5cf3844fb9f5491949e3a4169a47d91
  anahita-m
 


 
  
 
 
  
   
    

     [WIP] Adding Review Commands
     
We'd like to add a new command to RBTools for performing reviews, which
itself would actually be several commands. This might be useful for some
users who are super heavy command-line users, and would definitely be
useful for people who want to add automation of various sorts (such as
adding reviews after running custom CI tools that we don't have
integrations for).

    

   
  		
  1af7b76735880743668361c1948703444a698748
  anahita-m
 


 
  
 
 
  
   
    
Adding subcommand class and restructuring review command with subparsers

   
  		
  47712bc2b2d49190b841fe97e4266511ac870742
  anahita-m
 


 
  
 
 
  
   
    
fixing flake8 issues on test_review.py

   
  		
  0edcd34d84c0c769bc7e5381b9ac8d60698f3518
  anahita-m
 


 
  
 
 
  
   
    
Added misssing options for File Attachment Comments

   
  		
  d9b7b1304c35c596af90b8a9043884aca220caee
  anahita-m
 


 
  
 
 
  
   
    
Editing review tests based off command restructuring

   
  		
  2b7db12273ca222863f9c1f98d3b51e9ecfbbbd9
  anahita-m
 


 
  
 
 
  
   
    
Adding repository, server, and global options to subparsers as well

   
  		
  b7511b79eb538f19d569b8260bce7d86de0a1da5
  anahita-m
 


 
  
 
 
  
   
    
ensuring that empty comments can't be added

   
  		
  1373b3d26d834fa1a3d6412606c683459e6bc2f8
  anahita-m
 


 
  
 
 
  
   
    
adding temporary a check for an empty review so that empty reviews cannot be ...

   
  		
  337290f1dd6f62f80a8e579221947c52974764a4
  anahita-m
 


 
  
 
 
  
   
    
adding temporary a check for an empty review so that empty reviews cannot be ...

   
  		
  7745522b8daf3587aad16fb6095a9693cfebf5ce
  anahita-m
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/commands/review.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...