Adding Review Commands

 






 

 


  Review Request #11502
  —
  Created March 3, 2021 and discarded  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  amohapatra
 









 
 

  RBTools
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
We'd like to add a new command to RBTools for performing reviews, which

itself would actually be several commands. This might be useful for some

users who are super heavy command-line users, and would definitely be

useful for people who want to add automation of various sorts (such as

adding reviews after running custom CI tools that we don't have

integrations for). This review request is dependent upon the JSON output object from r#11521.

 








  


 
 

  
Manually tested all commands so far and documented on Notion. Also added and ran new tests in rbtools/commands/tests/test_review.py.

 







 









 





  








 




 







   

    
    
Diff Revision 15


This is not the most recent revision of the diff. The latest diff is revision 30. See what's changed.

    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Adding helpful hints for rbt commands
     
RBTools current must scan the filesystem when a user does not specify a
repository name or repository type which is very slow. In order to optimize
RBTools, we will log hints that recommends setting repository name or type
when it already has not been specified. An option --no-hints is added so
users can disable hints if desired.

I ran ./tests/runtests.py rbtools/ and have 263 tests passing and have done
manual testing on different rbtools commands to ensure that the --no-hints
option is working and is also presented as a global option to the user when
they type .

    

   
  		
  63e8bbcf704b383e8c9b6cf7d83a0c21f12ab372
  anahita-m
 


 
  
   
  
  
   
  
 
 
  
   
    

     [WIP] Adding Review Commands
     
We'd like to add a new command to RBTools for performing reviews, which
itself would actually be several commands. This might be useful for some
users who are super heavy command-line users, and would definitely be
useful for people who want to add automation of various sorts (such as
adding reviews after running custom CI tools that we don't have
integrations for).

    

   
  		
  4be43a13c38a3c93efdf5a7bf57703f4c5e17485
  anahita-m
 


 
  
   
  
  
   
  
 
 
  
   
    

     [WIP] Adding Review Commands
     
We'd like to add a new command to RBTools for performing reviews, which
itself would actually be several commands. This might be useful for some
users who are super heavy command-line users, and would definitely be
useful for people who want to add automation of various sorts (such as
adding reviews after running custom CI tools that we don't have
integrations for).

    

   
  		
  63b1afc27810c79540d3c08374cd724f6cf38faa
  anahita-m
 




    


    
    

   

  

 









 

  

   
    

     
      
      setup.py
     
    

   
  

 



 

  

   
    

     
      
      docs/rbtools/index.rst
     
    

   
  

 



 

  

   
    

     
      
      rbtools/commands/review.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...