Summary

Adding Review Commands

Review Request #11502 — Created March 3, 2021 and discarded Nov. 24, 2021, 12:11 p.m.

Information

Owner

amohapatra

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

We'd like to add a new command to RBTools for performing reviews, which
itself would actually be several commands. This might be useful for some
users who are super heavy command-line users, and would definitely be
useful for people who want to add automation of various sorts (such as
adding reviews after running custom CI tools that we don't have
integrations for). This review request is dependent upon the JSON output object from r#11521.

Testing Done

Manually tested all commands so far and documented on Notion. Also added and ran new tests in rbtools/commands/tests/test_review.py.

Commits

Summary	ID	Author
Adding helpful hints for rbt commands RBTools current must scan the filesystem when a user does not specify a repository name or repository type which is very slow. In order to optimize RBTools, we will log hints that recommends setting repository name or type when it already has not been specified. An option --no-hints is added so users can disable hints if desired. I ran ./tests/runtests.py rbtools/ and have 263 tests passing and have done manual testing on different rbtools commands to ensure that the --no-hints option is working and is also presented as a global option to the user when they type .	71326e2dc6bc97a01030de44affe588b9f21a7e1	anahita-m
[WIP] Adding Review Commands We'd like to add a new command to RBTools for performing reviews, which itself would actually be several commands. This might be useful for some users who are super heavy command-line users, and would definitely be useful for people who want to add automation of various sorts (such as adding reviews after running custom CI tools that we don't have integrations for).	195de49d5a5ce6b1979556f85ed9b31b0e7da06a	anahita-m
[WIP] Adding Review Commands We'd like to add a new command to RBTools for performing reviews, which itself would actually be several commands. This might be useful for some users who are super heavy command-line users, and would definitely be useful for people who want to add automation of various sorts (such as adding reviews after running custom CI tools that we don't have integrations for).	3c36f63b5ae8e656f55c01d0ce335bf119e9a61b	anahita-m
Adding subcommand class and restructuring review command with subparsers	5f802fb4a6be325044800fb4cf7d757314dde9ac	anahita-m
fixing flake8 issues on test_review.py	d064c6470393a840b48132175529c84efe9be196	anahita-m
Added misssing options for File Attachment Comments	7b70b35e7fed9cb97c0219d277d3d91270d6e95f	anahita-m
Editing review tests based off command restructuring	5ec4fdc3608d67ab2698ed0cf94684b06170171b	anahita-m
Adding repository, server, and global options to subparsers as well	84c9bc49e456170fc573aae84d1d9289363d6640	anahita-m
ensuring that empty comments can't be added	d04c4bc18e0c5cd2b3f3e175a9832bcd66603c26	anahita-m
adding temporary a check for an empty review so that empty reviews cannot be published	d1fb4c9b4a2ac41622e2d069dbc1df728af79b54	anahita-m
adding temporary a check for an empty review so that empty reviews cannot be published	4f7bb7547af17cd64280cf65f701139cf5e0e446	anahita-m
Adding --json output on subparsers	1e5f3c0a3e1dab8ba83e98dfe756d37ef46841ea	anahita-m
fixing flake8 issues	8401d70d9ff2f9c17ebe5d472fa85e950da12b4d	anahita-m
fixing error message for matching files > 1 for add-diff-comment subcommand to include the passed filename	81c91d321e6acdb7f74d7a58d1fd478f946c38c9	anahita-m
fixing flake8 issues in __init__.py	74be2931d947a5d9865b4ad05809ad49d6c1215d	anahita-m
making minor edit to error message	58144e4a1a4e56ead9cf04785aef9511546373ce	anahita-m

Issues

Description	From	Last Updated
testComment1	amohapatra	March 14, 2021, 9 p.m.
F401 'rbtools.commands.Option' imported but unused	reviewbot	March 3, 2021, 1:54 a.m.
F401 'rbtools.utils.review_request.get_revisions' imported but unused	reviewbot	March 3, 2021, 1:54 a.m.
F401 'rbtools.utils.review_request.guess_existing_review_request' imported but unused	reviewbot	March 3, 2021, 1:55 a.m.
F401 'rbtools.utils.review_request.get_draft_or_current_value' imported but unused	reviewbot	March 3, 2021, 1:55 a.m.
E302 expected 2 blank lines, found 0	reviewbot	March 3, 2021, 1:54 a.m.
E231 missing whitespace after ','	reviewbot	March 3, 2021, 1:54 a.m.
E231 missing whitespace after ','	reviewbot	March 3, 2021, 1:53 a.m.
E231 missing whitespace after ','	reviewbot	March 3, 2021, 1:53 a.m.
E501 line too long (84 > 79 characters)	reviewbot	March 3, 2021, 1:52 a.m.
F841 local variable 'review' is assigned to but never used	reviewbot	March 3, 2021, 3:02 a.m.
F821 undefined name 'e'	reviewbot	March 3, 2021, 1:52 a.m.
E231 missing whitespace after ','	reviewbot	March 3, 2021, 1:52 a.m.
E225 missing whitespace around operator	reviewbot	March 3, 2021, 1:52 a.m.
E501 line too long (106 > 79 characters)	reviewbot	March 3, 2021, 1:52 a.m.
E501 line too long (80 > 79 characters)	reviewbot	March 3, 2021, 1:51 a.m.
W293 blank line contains whitespace	reviewbot	March 3, 2021, 1:51 a.m.
E231 missing whitespace after ','	reviewbot	March 3, 2021, 1:51 a.m.
E122 continuation line missing indentation or outdented	reviewbot	March 3, 2021, 1:55 a.m.
E231 missing whitespace after ','	reviewbot	March 3, 2021, 1:51 a.m.
W292 no newline at end of file	reviewbot	March 3, 2021, 1:50 a.m.
F401 'rbtools.commands.Option' imported but unused	reviewbot	March 3, 2021, 1:59 a.m.
F401 'rbtools.utils.review_request.get_revisions' imported but unused	reviewbot	March 3, 2021, 2 a.m.
F401 'rbtools.utils.review_request.guess_existing_review_request' imported but unused	reviewbot	March 3, 2021, 2 a.m.
F401 'rbtools.utils.review_request.get_draft_or_current_value' imported but unused	reviewbot	March 3, 2021, 2 a.m.
E302 expected 2 blank lines, found 0	reviewbot	March 3, 2021, 2 a.m.
E231 missing whitespace after ','	reviewbot	March 3, 2021, 2 a.m.
E231 missing whitespace after ','	reviewbot	March 3, 2021, 2 a.m.
E231 missing whitespace after ','	reviewbot	March 3, 2021, 2 a.m.
F841 local variable 'review' is assigned to but never used	reviewbot	March 3, 2021, 2 a.m.
E501 line too long (84 > 79 characters)	reviewbot	March 3, 2021, 2 a.m.
E501 line too long (106 > 79 characters)	reviewbot	March 3, 2021, 2 a.m.
E225 missing whitespace around operator	reviewbot	March 3, 2021, 2 a.m.
E231 missing whitespace after ','	reviewbot	March 3, 2021, 2 a.m.
F821 undefined name 'e'	reviewbot	March 3, 2021, 2 a.m.
E501 line too long (80 > 79 characters)	reviewbot	March 3, 2021, 2 a.m.
W293 blank line contains whitespace	reviewbot	March 3, 2021, 2 a.m.
E231 missing whitespace after ','	reviewbot	March 3, 2021, 2 a.m.
E122 continuation line missing indentation or outdented	reviewbot	March 3, 2021, 2 a.m.
E231 missing whitespace after ','	reviewbot	March 3, 2021, 2 a.m.
W292 no newline at end of file	reviewbot	March 3, 2021, 2 a.m.
E501 line too long (84 > 79 characters)	reviewbot	March 3, 2021, 2:04 a.m.
E127 continuation line over-indented for visual indent	reviewbot	March 3, 2021, 3:03 a.m.
E127 continuation line over-indented for visual indent	reviewbot	March 3, 2021, 3:03 a.m.
E127 continuation line over-indented for visual indent	reviewbot	March 3, 2021, 3:03 a.m.
E127 continuation line over-indented for visual indent	reviewbot	March 3, 2021, 3:03 a.m.
E127 continuation line over-indented for visual indent	reviewbot	March 3, 2021, 3:03 a.m.
E303 too many blank lines (2)	reviewbot	March 3, 2021, 3:04 a.m.
E501 line too long (82 > 79 characters)	reviewbot	March 3, 2021, 3:04 a.m.
E127 continuation line over-indented for visual indent	reviewbot	March 3, 2021, 3:09 a.m.
E127 continuation line over-indented for visual indent	reviewbot	March 3, 2021, 3:09 a.m.
E127 continuation line over-indented for visual indent	reviewbot	March 3, 2021, 3:09 a.m.
E127 continuation line over-indented for visual indent	reviewbot	March 3, 2021, 3:09 a.m.
E127 continuation line over-indented for visual indent	reviewbot	March 3, 2021, 3:09 a.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	March 3, 2021, 3:09 a.m.
W291 trailing whitespace	reviewbot	March 3, 2021, 8:46 p.m.
F841 local variable 'review_draft' is assigned to but never used	reviewbot	March 5, 2021, 2:04 a.m.
F841 local variable 'e' is assigned to but never used	reviewbot	March 5, 2021, 2:04 a.m.
F841 local variable 'e' is assigned to but never used	reviewbot	March 5, 2021, 2:04 a.m.
F841 local variable 'review_draft' is assigned to but never used	reviewbot	March 5, 2021, 2:04 a.m.
F841 local variable 'e' is assigned to but never used	reviewbot	March 5, 2021, 2:04 a.m.
E303 too many blank lines (4)	reviewbot	March 5, 2021, 2:04 a.m.
W291 trailing whitespace	reviewbot	March 5, 2021, 1:58 a.m.
F841 local variable 'e' is assigned to but never used	reviewbot	March 5, 2021, 2:01 a.m.
F841 local variable 'e' is assigned to but never used	reviewbot	March 5, 2021, 2:01 a.m.
F841 local variable 'review' is assigned to but never used	reviewbot	March 5, 2021, 2:01 a.m.
F841 local variable 'e' is assigned to but never used	reviewbot	March 5, 2021, 2:01 a.m.
E501 line too long (85 > 79 characters)	reviewbot	March 5, 2021, 2:03 a.m.
E501 line too long (120 > 79 characters)	reviewbot	March 5, 2021, 2:03 a.m.
F841 local variable 'e' is assigned to but never used	reviewbot	March 5, 2021, 2:03 a.m.
E501 line too long (80 > 79 characters)	reviewbot	March 5, 2021, 2:04 a.m.
E501 line too long (85 > 79 characters)	reviewbot	March 5, 2021, 2:04 a.m.
E225 missing whitespace around operator	reviewbot	March 5, 2021, 2:09 a.m.
E225 missing whitespace around operator	reviewbot	March 5, 2021, 2:09 a.m.
E225 missing whitespace around operator	reviewbot	March 5, 2021, 2:09 a.m.
E225 missing whitespace around operator	reviewbot	March 5, 2021, 2:09 a.m.
E225 missing whitespace around operator	reviewbot	March 5, 2021, 2:09 a.m.
E501 line too long (80 > 79 characters)	reviewbot	March 6, 2021, 4:57 a.m.
E501 line too long (94 > 79 characters)	reviewbot	March 6, 2021, 4:56 a.m.
E501 line too long (81 > 79 characters)	reviewbot	March 6, 2021, 4:55 a.m.
E501 line too long (84 > 79 characters)	reviewbot	March 6, 2021, 4:54 a.m.
E501 line too long (90 > 79 characters)	reviewbot	March 6, 2021, 4:54 a.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	March 6, 2021, 4:53 a.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	March 6, 2021, 4:53 a.m.
E501 line too long (98 > 79 characters)	reviewbot	March 6, 2021, 4:54 a.m.
E501 line too long (84 > 79 characters)	reviewbot	March 6, 2021, 4:52 a.m.
E501 line too long (83 > 79 characters)	reviewbot	March 6, 2021, 4:51 a.m.
E501 line too long (80 > 79 characters)	reviewbot	March 6, 2021, 4:50 a.m.
E128 continuation line under-indented for visual indent	reviewbot	March 6, 2021, 4:50 a.m.
E722 do not use bare except'	reviewbot	March 6, 2021, 8:34 a.m.
E128 continuation line under-indented for visual indent	reviewbot	March 6, 2021, 8:32 a.m.
E128 continuation line under-indented for visual indent	reviewbot	March 6, 2021, 8:33 a.m.
E722 do not use bare except'	reviewbot	March 6, 2021, 8:34 a.m.
E225 missing whitespace around operator	reviewbot	March 28, 2021, 7:09 a.m.
E501 line too long (80 > 79 characters)	reviewbot	March 28, 2021, 7:09 a.m.
E225 missing whitespace around operator	reviewbot	March 8, 2021, 1:50 a.m.
E501 line too long (80 > 79 characters)	reviewbot	March 8, 2021, 1:51 a.m.
E999 IndentationError: expected an indented block	reviewbot	March 8, 2021, 1:52 a.m.
E112 expected an indented block	reviewbot	March 8, 2021, 1:53 a.m.
E113 unexpected indentation	reviewbot	March 8, 2021, 1:52 a.m.
W291 trailing whitespace	reviewbot	March 8, 2021, 1:55 a.m.
E128 continuation line under-indented for visual indent	reviewbot	March 8, 2021, 1:54 a.m.
This should be in sentence case. But even better would be to use option groups to keep things together. See …	david	April 3, 2021, 7:49 p.m.
When we include short options, we only do single characters. Given how rare it is to set a review footer, …	david	March 27, 2021, 9:28 a.m.
Maybe -h here?	david	March 27, 2021, 9:27 a.m.
These two options are for all types of comments, not just general comments.	david	March 27, 2021, 9:27 a.m.
Help text should be in sentence case. This should probably also mention that if not specified, the comment will cover …	david	March 28, 2021, 7:05 a.m.
I don't think this one needs a short option.	david	March 27, 2021, 9:26 a.m.
If we don't use -f for file attachments, let's use it for this one.	david	March 27, 2021, 9:26 a.m.
I don't think this one needs a short option.	david	March 27, 2021, 9:26 a.m.
Method docstrings should be written in the imperative mood ("Discard a review draft"). There's also an extra space between the …	david	April 4, 2021, 9:36 p.m.
This text needs to come before the "Args" section.	david	March 27, 2021, 9:25 a.m.
This should be a comment (#) rather than a string.	david	March 27, 2021, 9:25 a.m.
This should be a comment (#) rather than a string.	david	March 27, 2021, 9:25 a.m.
Same comments about the docstring here.	david	April 3, 2021, 7:48 p.m.
This should be a comment (#) rather than a string.	david	March 27, 2021, 9:24 a.m.
Same comments about the docstring.	david	March 28, 2021, 7:08 a.m.
I feel like it might be nicer to set default=None for these options, and then only include them in the …	david	April 3, 2021, 7:09 p.m.
E122 continuation line missing indentation or outdented	reviewbot	March 8, 2021, 2:08 a.m.
Hi Anahita, one little thing I noticed from your code is that you are using """""" for comments. Last time …	qianxi	March 28, 2021, 7:09 a.m.
Let's wrap this a little differently to make it a bit more compact: raise CommandError( '...' '...')	david	March 27, 2021, 9:24 a.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E201 whitespace after '('	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E131 continuation line unaligned for hanging indent	reviewbot	April 3, 2021, 7:08 p.m.
E265 block comment should start with '# '	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:08 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:09 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:09 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:09 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:09 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:09 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 3, 2021, 7:09 p.m.
F401 'rbtools.commands.CommandError' imported but unused	reviewbot	April 3, 2021, 7:46 p.m.
F401 'rbtools.commands.post.Post' imported but unused	reviewbot	April 3, 2021, 7:46 p.m.
E302 expected 2 blank lines, found 1	reviewbot	April 3, 2021, 7:46 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:46 p.m.
E501 line too long (128 > 79 characters)	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E303 too many blank lines (2)	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E501 line too long (133 > 79 characters)	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E501 line too long (118 > 79 characters)	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E501 line too long (109 > 79 characters)	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
E231 missing whitespace after ','	reviewbot	April 3, 2021, 7:47 p.m.
W503 line break before binary operator	reviewbot	April 5, 2021, 12:51 a.m.
W503 line break before binary operator	reviewbot	April 5, 2021, 12:51 a.m.
W503 line break before binary operator	reviewbot	April 5, 2021, 12:51 a.m.
W503 line break before binary operator	reviewbot	April 5, 2021, 12:51 a.m.
W503 line break before binary operator	reviewbot	April 8, 2021, 3:47 p.m.
W503 line break before binary operator	reviewbot	April 8, 2021, 3:47 p.m.
W503 line break before binary operator	reviewbot	April 8, 2021, 3:47 p.m.
W503 line break before binary operator	reviewbot	April 8, 2021, 3:47 p.m.
W503 line break before binary operator	reviewbot	April 9, 2021, 7:27 p.m.
W503 line break before binary operator	reviewbot	April 9, 2021, 7:27 p.m.
W503 line break before binary operator	reviewbot	April 9, 2021, 7:27 p.m.
W503 line break before binary operator	reviewbot	April 9, 2021, 7:27 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'rbtools.commands.Option' imported but unused
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'rbtools.utils.review_request.get_revisions' imported but unused
```

rbtools/commands/review.py (Diff revision 1)

The issue has been resolved. Show all issues

F401 'rbtools.utils.review_request.guess_existing_review_request' imported but unused

rbtools/commands/review.py (Diff revision 1)

The issue has been resolved. Show all issues

F401 'rbtools.utils.review_request.get_draft_or_current_value' imported but unused

rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 0
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (84 > 79 characters)
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F841 local variable 'review' is assigned to but never used
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'e'
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E225 missing whitespace around operator
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (106 > 79 characters)
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E122 continuation line missing indentation or outdented
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
rbtools/commands/review.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W292 no newline at end of file
```

Commits:

Summary	ID	Author
Adding helpful hints for rbt commands RBTools current must scan the filesystem when a user does not specify a repository name or repository type which is very slow. In order to optimize RBTools, we will log hints that recommends setting repository name or type when it already has not been specified. An option --no-hints is added so users can disable hints if desired. I ran ./tests/runtests.py rbtools/ and have 263 tests passing and have done manual testing on different rbtools commands to ensure that the --no-hints option is working and is also presented as a global option to the user when they type .	63e8bbcf704b383e8c9b6cf7d83a0c21f12ab372	anahita-m
[WIP] Adding Review Commands We'd like to add a new command to RBTools for performing reviews, which itself would actually be several commands. This might be useful for some users who are super heavy command-line users, and would definitely be useful for people who want to add automation of various sorts (such as adding reviews after running custom CI tools that we don't have integrations for).	4be43a13c38a3c93efdf5a7bf57703f4c5e17485	anahita-m
[WIP] Adding Review Commands We'd like to add a new command to RBTools for performing reviews, which itself would actually be several commands. This might be useful for some users who are super heavy command-line users, and would definitely be useful for people who want to add automation of various sorts (such as adding reviews after running custom CI tools that we don't have integrations for).	13a8e52d58536ae09820497d796b636d199cb405	anahita-m
Adding helpful hints for rbt commands RBTools current must scan the filesystem when a user does not specify a repository name or repository type which is very slow. In order to optimize RBTools, we will log hints that recommends setting repository name or type when it already has not been specified. An option --no-hints is added so users can disable hints if desired. I ran ./tests/runtests.py rbtools/ and have 263 tests passing and have done manual testing on different rbtools commands to ensure that the --no-hints option is working and is also presented as a global option to the user when they type .	63e8bbcf704b383e8c9b6cf7d83a0c21f12ab372	anahita-m
[WIP] Adding Review Commands We'd like to add a new command to RBTools for performing reviews, which itself would actually be several commands. This might be useful for some users who are super heavy command-line users, and would definitely be useful for people who want to add automation of various sorts (such as adding reviews after running custom CI tools that we don't have integrations for).	4be43a13c38a3c93efdf5a7bf57703f4c5e17485	anahita-m
[WIP] Adding Review Commands We'd like to add a new command to RBTools for performing reviews, which itself would actually be several commands. This might be useful for some users who are super heavy command-line users, and would definitely be useful for people who want to add automation of various sorts (such as adding reviews after running custom CI tools that we don't have integrations for).	13a8e52d58536ae09820497d796b636d199cb405	anahita-m

Diff:

Revision 2 (+179 -75)

	setup.py
	docs/rbtools/index.rst
	rbtools/clients/tests/.DS_Store
	rbtools/clients/tests/test_scanning.py
	rbtools/commands/review.py
	rbtools/commands/tests/test_review.py

		We'd like to add a new command to RBTools for performing reviews, which
		itself would actually be several commands. This might be useful for some
		users who are super heavy command-line users, and would definitely be
		useful for people who want to add automation of various sorts (such as
		adding reviews after running custom CI tools that we don't have
~		integrations for).
	~	integrations for). This review request is dependent upon the JSON output object from r#11521.

Summary	ID	Author
Adding helpful hints for rbt commands RBTools current must scan the filesystem when a user does not specify a repository name or repository type which is very slow. In order to optimize RBTools, we will log hints that recommends setting repository name or type when it already has not been specified. An option --no-hints is added so users can disable hints if desired. I ran ./tests/runtests.py rbtools/ and have 263 tests passing and have done manual testing on different rbtools commands to ensure that the --no-hints option is working and is also presented as a global option to the user when they type .	f476ee907f86595e0cb8b34fe6412641ed35157b	anahita-m
[WIP] Adding Review Commands We'd like to add a new command to RBTools for performing reviews, which itself would actually be several commands. This might be useful for some users who are super heavy command-line users, and would definitely be useful for people who want to add automation of various sorts (such as adding reviews after running custom CI tools that we don't have integrations for).	4d965957f5cf3844fb9f5491949e3a4169a47d91	anahita-m
[WIP] Adding Review Commands We'd like to add a new command to RBTools for performing reviews, which itself would actually be several commands. This might be useful for some users who are super heavy command-line users, and would definitely be useful for people who want to add automation of various sorts (such as adding reviews after running custom CI tools that we don't have integrations for).	1af7b76735880743668361c1948703444a698748	anahita-m
Adding subcommand class and restructuring review command with subparsers	47712bc2b2d49190b841fe97e4266511ac870742	anahita-m
fixing flake8 issues on test_review.py	0edcd34d84c0c769bc7e5381b9ac8d60698f3518	anahita-m
Added misssing options for File Attachment Comments	d9b7b1304c35c596af90b8a9043884aca220caee	anahita-m
Editing review tests based off command restructuring	2b7db12273ca222863f9c1f98d3b51e9ecfbbbd9	anahita-m
Adding repository, server, and global options to subparsers as well	b7511b79eb538f19d569b8260bce7d86de0a1da5	anahita-m
ensuring that empty comments can't be added	1373b3d26d834fa1a3d6412606c683459e6bc2f8	anahita-m
adding temporary a check for an empty review so that empty reviews cannot be published	337290f1dd6f62f80a8e579221947c52974764a4	anahita-m
adding temporary a check for an empty review so that empty reviews cannot be published	7745522b8daf3587aad16fb6095a9693cfebf5ce	anahita-m
Adding helpful hints for rbt commands RBTools current must scan the filesystem when a user does not specify a repository name or repository type which is very slow. In order to optimize RBTools, we will log hints that recommends setting repository name or type when it already has not been specified. An option --no-hints is added so users can disable hints if desired. I ran ./tests/runtests.py rbtools/ and have 263 tests passing and have done manual testing on different rbtools commands to ensure that the --no-hints option is working and is also presented as a global option to the user when they type .	71326e2dc6bc97a01030de44affe588b9f21a7e1	anahita-m
[WIP] Adding Review Commands We'd like to add a new command to RBTools for performing reviews, which itself would actually be several commands. This might be useful for some users who are super heavy command-line users, and would definitely be useful for people who want to add automation of various sorts (such as adding reviews after running custom CI tools that we don't have integrations for).	195de49d5a5ce6b1979556f85ed9b31b0e7da06a	anahita-m
[WIP] Adding Review Commands We'd like to add a new command to RBTools for performing reviews, which itself would actually be several commands. This might be useful for some users who are super heavy command-line users, and would definitely be useful for people who want to add automation of various sorts (such as adding reviews after running custom CI tools that we don't have integrations for).	3c36f63b5ae8e656f55c01d0ce335bf119e9a61b	anahita-m
Adding subcommand class and restructuring review command with subparsers	5f802fb4a6be325044800fb4cf7d757314dde9ac	anahita-m
fixing flake8 issues on test_review.py	d064c6470393a840b48132175529c84efe9be196	anahita-m
Added misssing options for File Attachment Comments	7b70b35e7fed9cb97c0219d277d3d91270d6e95f	anahita-m
Editing review tests based off command restructuring	5ec4fdc3608d67ab2698ed0cf94684b06170171b	anahita-m
Adding repository, server, and global options to subparsers as well	84c9bc49e456170fc573aae84d1d9289363d6640	anahita-m
ensuring that empty comments can't be added	d04c4bc18e0c5cd2b3f3e175a9832bcd66603c26	anahita-m
adding temporary a check for an empty review so that empty reviews cannot be published	d1fb4c9b4a2ac41622e2d069dbc1df728af79b54	anahita-m
adding temporary a check for an empty review so that empty reviews cannot be published	4f7bb7547af17cd64280cf65f701139cf5e0e446	anahita-m
Adding --json output on subparsers	1e5f3c0a3e1dab8ba83e98dfe756d37ef46841ea	anahita-m
fixing flake8 issues	8401d70d9ff2f9c17ebe5d472fa85e950da12b4d	anahita-m
fixing error message for matching files > 1 for add-diff-comment subcommand to include the passed filename	81c91d321e6acdb7f74d7a58d1fd478f946c38c9	anahita-m
fixing flake8 issues in __init__.py	74be2931d947a5d9865b4ad05809ad49d6c1215d	anahita-m

	setup.py
	docs/rbtools/index.rst
	rbtools/commands/__init__.py
	rbtools/commands/review.py
	rbtools/commands/tests/test_review.py

Adding Review Commands

Information

Reviewers

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (2 succeeded)

Checks run (1 failed, 1 succeeded)

flake8

Checks run (2 succeeded)

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (2 succeeded)

Checks run (1 failed, 1 succeeded)

flake8

Checks run (2 succeeded)

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (2 succeeded)

Checks run (1 failed, 1 succeeded)

flake8

Checks run (2 succeeded)

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (2 succeeded)

Checks run (2 succeeded)

Checks run (2 succeeded)

Checks run (2 succeeded)

Checks run (2 succeeded)

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8

Checks run (1 failed, 1 succeeded)

flake8