Summary

Make RBTools command initialization easier and more consistent.

Review Request #11480 — Created Feb. 22, 2021 and submitted March 23, 2021, 10:37 p.m.

Information

Owner

david

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

This change is the first of a couple to clean this up. Two new
attributes have been added to the base Command class: needs_api and
needs_scm_client. Subclasses can set these to True depending on
their needs, and then prior to main being called, the initialization
process will set various attributes: api_client, api_root,
capabilities, repository_info, server_url, and tool.

This change handles most of the initialization process. The one major
remaining piece are the calls to find_server_repository_info, which
will require some more involved changes (for example, short-cutting in
the case when REPOSITORY_NAME or REPOSITORY_URL are defined).

Testing Done


Smoke tested basic functionality for all changed commands.
Verified rbt patch behavior was correct with both ID and full URL

  (ID only and ID + diff revision) arguments. Checked that

rbt patch --print did not initialize any repository support.
Verified rbt land behavior was correct with both ID and full URL

--review-request-id option.
Checked that rbt status --all did not initialize any repository

  support.

Commits

Summary	ID
Make RBTools command initialization easier and more consistent. The different commands in RBTools have lots of differerent needs. Some of them interact only with your local repository, some of them interact only with the server API, some do both, and some do neither. We've traditionally had a few methods to handle things like setting up the API or the SCMClient, but usage of these was inconsistent and resulted in a lot of repeated boilerplate. Because of this and the history of RBTools development, usage of all of this was somewhat inconsistent, with many commands doing more or less than they really needed to do. This change is the first of a couple to clean this up. Two new attributes have been added to the base `Command` class: `needs_api` and `needs_scm_client`. Subclasses can set these to `True` depending on their needs, and then prior to `main` being called, the initialization process will set various attributes: `api_client`, `api_root`, `capabilities`, `repository_info`, `server_url`, and `tool`. This change handles most of the initialization process. The one major remaining piece are the calls to `find_server_repository_info`, which will require some more involved changes (for example, short-cutting in the case when REPOSITORY_NAME or REPOSITORY_URL are defined). Testing Done: - Smoke tested basic functionality for all changed commands. - Verified `rbt patch` behavior was correct with both ID and full URL (ID only and ID + diff revision) arguments. Checked that `rbt patch --print` did not initialize any repository support. - Verified `rbt land` behavior was correct with both ID and full URL `--review-request-id` option. - Checked that `rbt status --all` did not initialize any repository support.	7a393157dfa946d52898718a1e5d0a969df39591

Summary

Make RBTools command initialization easier and more consistent.

The different commands in RBTools have lots of differerent needs. Some of them interact only with your local repository, some of them interact only with the server API, some do both, and some do neither. We've traditionally had a few methods to handle things like setting up the API or the SCMClient, but usage of these was inconsistent and resulted in a lot of repeated boilerplate. Because of this and the history of RBTools development, usage of all of this was somewhat inconsistent, with many commands doing more or less than they really needed to do. This change is the first of a couple to clean this up. Two new attributes have been added to the base `Command` class: `needs_api` and `needs_scm_client`. Subclasses can set these to `True` depending on their needs, and then prior to `main` being called, the initialization process will set various attributes: `api_client`, `api_root`, `capabilities`, `repository_info`, `server_url`, and `tool`. This change handles most of the initialization process. The one major remaining piece are the calls to `find_server_repository_info`, which will require some more involved changes (for example, short-cutting in the case when REPOSITORY_NAME or REPOSITORY_URL are defined). Testing Done: - Smoke tested basic functionality for all changed commands. - Verified `rbt patch` behavior was correct with both ID and full URL (ID only and ID + diff revision) arguments. Checked that `rbt patch --print` did not initialize any repository support. - Verified `rbt land` behavior was correct with both ID and full URL `--review-request-id` option. - Checked that `rbt status --all` did not initialize any repository support.

7a393157dfa946d52898718a1e5d0a969df39591

Issues

Description	From	Last Updated
Let's move this work to master for 3.0, given how much of a change I suspect this will all ultimately …	chipx86	Feb. 23, 2021, 11:55 a.m.
F821 undefined name 'tool'	reviewbot	Feb. 22, 2021, 3:28 p.m.
F821 undefined name 'repository_info'	reviewbot	Feb. 22, 2021, 3:28 p.m.
F821 undefined name 'repository_info'	reviewbot	Feb. 22, 2021, 3:28 p.m.
F821 undefined name 'repository_info'	reviewbot	Feb. 22, 2021, 3:28 p.m.
F821 undefined name 'repository_info'	reviewbot	Feb. 22, 2021, 3:28 p.m.
F821 undefined name 'repository_info'	reviewbot	Feb. 22, 2021, 3:28 p.m.
Typo: "repat"	chipx86	Feb. 22, 2021, 9:21 p.m.
Private methods should go below public.	chipx86	Feb. 22, 2021, 9:24 p.m.
"command line"	chipx86	Feb. 22, 2021, 9:24 p.m.
Should we just assign server_url unconditionally?	chipx86	Feb. 22, 2021, 9:25 p.m.
This should be one if statement. It's checking server_url is None twice, and there's never an alternate condition for the …	chipx86	Feb. 22, 2021, 9:25 p.m.
This doesn't handle the case of trees[path] not existing.	chipx86	Feb. 22, 2021, 9:26 p.m.
This should be logging.warning. The warn alias is, as far as I can tell, for backwards-compatibility only. Actually though, I …	chipx86	Feb. 23, 2021, 11:54 a.m.
This should also be updated to use warnings and ideally a version-specific DeprecationWarning.	chipx86	Feb. 23, 2021, 11:54 a.m.
Can we pull out self.tool into a local variable to avoid the repeated attribute lookups and line changes?	chipx86	Feb. 22, 2021, 9:26 p.m.
Missing a Raises	chipx86	Feb. 22, 2021, 9:32 p.m.
While here, can we make these keyword arguments?	chipx86	Feb. 22, 2021, 9:33 p.m.
Let's pull out api_client to avoid repeated attribute lookups.	chipx86	Feb. 23, 2021, 11:55 a.m.
Missing a Raises:.	chipx86	Feb. 22, 2021, 9:38 p.m.
Let's pull out tool as well.	chipx86	Feb. 22, 2021, 9:38 p.m.
Let's pull out repository_info.	chipx86	Feb. 22, 2021, 9:41 p.m.
While here, can we make these all keyword arguments? This is a really wordy function.	chipx86	Feb. 22, 2021, 9:42 p.m.
Can we use keyword arguments here?	chipx86	Feb. 22, 2021, 9:43 p.m.
And here.	chipx86	Feb. 22, 2021, 9:43 p.m.
Can we use keyword arguments here?	chipx86	Feb. 22, 2021, 9:44 p.m.
How about we call this initialize? That'll be consistent with the naming used for extensions.	chipx86	March 11, 2021, 12:51 p.m.
Does this fit on one line now?	chipx86	March 11, 2021, 12:51 p.m.
Can you add a Version Added to these (before Type)?	chipx86	March 23, 2021, 10:37 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'tool'
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'repository_info'
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'repository_info'
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'repository_info'
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'repository_info'
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'repository_info'
```

Commits:

	Summary	ID
	Make RBTools command initialization easier and more consistent. The different commands in RBTools have lots of differerent needs. Some of them interact only with your local repository, some of them interact only with the server API, some do both, and some do neither. We've traditionally had a few methods to handle things like setting up the API or the SCMClient, but usage of these was inconsistent and resulted in a lot of repeated boilerplate. Because of this and the history of RBTools development, usage of all of this was somewhat inconsistent, with many commands doing more or less than they really needed to do. This change is the first of a couple to clean this up. Two new attributes have been added to the base `Command` class: `needs_api` and `needs_scm_client`. Subclasses can set these to `True` depending on their needs, and then prior to `main` being called, the initialization process will set various attributes: `api_client`, `api_root`, `capabilities`, `repository_info`, `server_url`, and `tool`. This change handles most of the initialization process. The one major remaining piece are the calls to `find_server_repository_info`, which will require some more involved changes (for example, short-cutting in the case when REPOSITORY_NAME or REPOSITORY_URL are defined). Testing Done: - Smoke tested basic functionality for all changed commands. - Verified `rbt patch` behavior was correct with both ID and full URL (ID only and ID + diff revision) arguments. Checked that `rbt patch --print` did not initialize any repository support. - Verified `rbt land` behavior was correct with both ID and full URL `--review-request-id` option. - Checked that `rbt status --all` did not initialize any repository support.	3bc91c87ed92af992896bf4bd7959a306bf91e4b
	Make RBTools command initialization easier and more consistent. The different commands in RBTools have lots of differerent needs. Some of them interact only with your local repository, some of them interact only with the server API, some do both, and some do neither. We've traditionally had a few methods to handle things like setting up the API or the SCMClient, but usage of these was inconsistent and resulted in a lot of repeated boilerplate. Because of this and the history of RBTools development, usage of all of this was somewhat inconsistent, with many commands doing more or less than they really needed to do. This change is the first of a couple to clean this up. Two new attributes have been added to the base `Command` class: `needs_api` and `needs_scm_client`. Subclasses can set these to `True` depending on their needs, and then prior to `main` being called, the initialization process will set various attributes: `api_client`, `api_root`, `capabilities`, `repository_info`, `server_url`, and `tool`. This change handles most of the initialization process. The one major remaining piece are the calls to `find_server_repository_info`, which will require some more involved changes (for example, short-cutting in the case when REPOSITORY_NAME or REPOSITORY_URL are defined). Testing Done: - Smoke tested basic functionality for all changed commands. - Verified `rbt patch` behavior was correct with both ID and full URL (ID only and ID + diff revision) arguments. Checked that `rbt patch --print` did not initialize any repository support. - Verified `rbt land` behavior was correct with both ID and full URL `--review-request-id` option. - Checked that `rbt status --all` did not initialize any repository support.	ba7733ecfbeca09c3138676462524ed6c1da1b45

Diff:

Revision 2 (+840 -682)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	rbtools/commands/login.py
	8 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

This is a great cleanup! This cleanly removes one of the biggest annoyances with writing commands. I love it.
My biggest nit is that I'd like to move toward fewer, rather than more, attribute accesses. We have a lot of code (existing and newly-introduced in this change) that does a lot of repeated self.some_attr_name, and while it's not performance-critical code, it's slower and less readable to keep doing that. I suspect that this change will shrink a bit if we replace some of the older code you're getting rid of with statements like tool = self.tool when that variable's going to be used repeatedly.
I marked a few cases like this, but it's not comprehensive.
There's a few other areas of code that I've always disliked, where we're calling some utility function with a bunch of positional arguments, and I think there's a good opportunity to switch those calls to keyword arguments. I only marked up a few of the bigger cases here.

The issue has been resolved. Show all issues

Let's move this work to master for 3.0, given how much of a change I suspect this will all ultimately be.

rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Typo: "repat"
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Private methods should go below public.
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
"command line"
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Should we just assign server_url unconditionally?
```

rbtools/commands/__init__.py (Diff revision 2)

The issue has been resolved. Show all issues

This should be one if statement. It's checking server_url is None twice, and there's never an alternate condition for the outer if.

rbtools/commands/__init__.py (Diff revision 2)

The issue has been dropped. Show all issues

This doesn't handle the case of trees[path] not existing.

david Feb. 23, 2021, 11:56 a.m.

That's handled in the structure of the for loop above.

rbtools/commands/__init__.py (Diff revision 2)

The issue has been resolved. Show all issues

This should be logging.warning. The warn alias is, as far as I can tell, for backwards-compatibility only.

Actually though, I think we want to use the warnings module. Ideally, and this can be a follow-up change if you want, we should have a rbtools.deprecation module that provides classes similar to Review Board's, so we can put together a proper deprecation strategy.

david Feb. 23, 2021, 11:56 a.m.

I'll switch it to logging.warning but the deprecation module stuff seems better suited for a separate change.

rbtools/commands/__init__.py (Diff revision 2)

The issue has been dropped. Show all issues

This should also be updated to use warnings and ideally a version-specific DeprecationWarning.

rbtools/commands/diff.py (Diff revision 2)

The issue has been resolved. Show all issues

Can we pull out self.tool into a local variable to avoid the repeated attribute lookups and line changes?

rbtools/commands/land.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a Raises
```
rbtools/commands/login.py (Diff revision 2)
The issue has been resolved. Show all issues
```
While here, can we make these keyword arguments?
```

rbtools/commands/logout.py (Diff revision 2)

The issue has been dropped. Show all issues

Let's pull out api_client to avoid repeated attribute lookups.

david Feb. 23, 2021, 11:56 a.m.

Saving one extra attribute lookup in a command which is almost never used doesn't seem worth the extra line.

rbtools/commands/patch.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Missing a Raises:.
```
rbtools/commands/patch.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Let's pull out tool as well.
```
rbtools/commands/post.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Let's pull out repository_info.
```

rbtools/commands/post.py (Diff revision 2)

The issue has been resolved. Show all issues

While here, can we make these all keyword arguments? This is a really wordy function.

rbtools/commands/stamp.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we use keyword arguments here?
```
rbtools/commands/stamp.py (Diff revision 2)
The issue has been resolved. Show all issues
```
And here.
```
rbtools/commands/status.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Can we use keyword arguments here?
```

Commits:

	Summary	ID
	Make RBTools command initialization easier and more consistent. The different commands in RBTools have lots of differerent needs. Some of them interact only with your local repository, some of them interact only with the server API, some do both, and some do neither. We've traditionally had a few methods to handle things like setting up the API or the SCMClient, but usage of these was inconsistent and resulted in a lot of repeated boilerplate. Because of this and the history of RBTools development, usage of all of this was somewhat inconsistent, with many commands doing more or less than they really needed to do. This change is the first of a couple to clean this up. Two new attributes have been added to the base `Command` class: `needs_api` and `needs_scm_client`. Subclasses can set these to `True` depending on their needs, and then prior to `main` being called, the initialization process will set various attributes: `api_client`, `api_root`, `capabilities`, `repository_info`, `server_url`, and `tool`. This change handles most of the initialization process. The one major remaining piece are the calls to `find_server_repository_info`, which will require some more involved changes (for example, short-cutting in the case when REPOSITORY_NAME or REPOSITORY_URL are defined). Testing Done: - Smoke tested basic functionality for all changed commands. - Verified `rbt patch` behavior was correct with both ID and full URL (ID only and ID + diff revision) arguments. Checked that `rbt patch --print` did not initialize any repository support. - Verified `rbt land` behavior was correct with both ID and full URL `--review-request-id` option. - Checked that `rbt status --all` did not initialize any repository support.	ba7733ecfbeca09c3138676462524ed6c1da1b45
	Make RBTools command initialization easier and more consistent. The different commands in RBTools have lots of differerent needs. Some of them interact only with your local repository, some of them interact only with the server API, some do both, and some do neither. We've traditionally had a few methods to handle things like setting up the API or the SCMClient, but usage of these was inconsistent and resulted in a lot of repeated boilerplate. Because of this and the history of RBTools development, usage of all of this was somewhat inconsistent, with many commands doing more or less than they really needed to do. This change is the first of a couple to clean this up. Two new attributes have been added to the base `Command` class: `needs_api` and `needs_scm_client`. Subclasses can set these to `True` depending on their needs, and then prior to `main` being called, the initialization process will set various attributes: `api_client`, `api_root`, `capabilities`, `repository_info`, `server_url`, and `tool`. This change handles most of the initialization process. The one major remaining piece are the calls to `find_server_repository_info`, which will require some more involved changes (for example, short-cutting in the case when REPOSITORY_NAME or REPOSITORY_URL are defined). Testing Done: - Smoke tested basic functionality for all changed commands. - Verified `rbt patch` behavior was correct with both ID and full URL (ID only and ID + diff revision) arguments. Checked that `rbt patch --print` did not initialize any repository support. - Verified `rbt land` behavior was correct with both ID and full URL `--review-request-id` option. - Checked that `rbt status --all` did not initialize any repository support.	272daa73034353600c3447ed408c58c36cc8a251

Branch:

-	release-2.0.x
+	master

Diff:

Revision 3 (+970 -766)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	rbtools/commands/login.py
	8 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Looks good. I just have one suggestion regarding naming.

rbtools/commands/__init__.py (Diff revision 3)

The issue has been resolved. Show all issues

How about we call this initialize? That'll be consistent with the naming used for extensions.

rbtools/commands/post.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Does this fit on one line now?
```

Commits:

	Summary	ID
	Make RBTools command initialization easier and more consistent. The different commands in RBTools have lots of differerent needs. Some of them interact only with your local repository, some of them interact only with the server API, some do both, and some do neither. We've traditionally had a few methods to handle things like setting up the API or the SCMClient, but usage of these was inconsistent and resulted in a lot of repeated boilerplate. Because of this and the history of RBTools development, usage of all of this was somewhat inconsistent, with many commands doing more or less than they really needed to do. This change is the first of a couple to clean this up. Two new attributes have been added to the base `Command` class: `needs_api` and `needs_scm_client`. Subclasses can set these to `True` depending on their needs, and then prior to `main` being called, the initialization process will set various attributes: `api_client`, `api_root`, `capabilities`, `repository_info`, `server_url`, and `tool`. This change handles most of the initialization process. The one major remaining piece are the calls to `find_server_repository_info`, which will require some more involved changes (for example, short-cutting in the case when REPOSITORY_NAME or REPOSITORY_URL are defined). Testing Done: - Smoke tested basic functionality for all changed commands. - Verified `rbt patch` behavior was correct with both ID and full URL (ID only and ID + diff revision) arguments. Checked that `rbt patch --print` did not initialize any repository support. - Verified `rbt land` behavior was correct with both ID and full URL `--review-request-id` option. - Checked that `rbt status --all` did not initialize any repository support.	272daa73034353600c3447ed408c58c36cc8a251
	Make RBTools command initialization easier and more consistent. The different commands in RBTools have lots of differerent needs. Some of them interact only with your local repository, some of them interact only with the server API, some do both, and some do neither. We've traditionally had a few methods to handle things like setting up the API or the SCMClient, but usage of these was inconsistent and resulted in a lot of repeated boilerplate. Because of this and the history of RBTools development, usage of all of this was somewhat inconsistent, with many commands doing more or less than they really needed to do. This change is the first of a couple to clean this up. Two new attributes have been added to the base `Command` class: `needs_api` and `needs_scm_client`. Subclasses can set these to `True` depending on their needs, and then prior to `main` being called, the initialization process will set various attributes: `api_client`, `api_root`, `capabilities`, `repository_info`, `server_url`, and `tool`. This change handles most of the initialization process. The one major remaining piece are the calls to `find_server_repository_info`, which will require some more involved changes (for example, short-cutting in the case when REPOSITORY_NAME or REPOSITORY_URL are defined). Testing Done: - Smoke tested basic functionality for all changed commands. - Verified `rbt patch` behavior was correct with both ID and full URL (ID only and ID + diff revision) arguments. Checked that `rbt patch --print` did not initialize any repository support. - Verified `rbt land` behavior was correct with both ID and full URL `--review-request-id` option. - Checked that `rbt status --all` did not initialize any repository support.	9ec5ab5f85c8423145ea9d69eb6d848dfaa5c48c

Diff:

Revision 4 (+970 -768)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	rbtools/commands/login.py
	8 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Rename init -> initialize everywhere.

Commits:

	Summary	ID
	Make RBTools command initialization easier and more consistent. The different commands in RBTools have lots of differerent needs. Some of them interact only with your local repository, some of them interact only with the server API, some do both, and some do neither. We've traditionally had a few methods to handle things like setting up the API or the SCMClient, but usage of these was inconsistent and resulted in a lot of repeated boilerplate. Because of this and the history of RBTools development, usage of all of this was somewhat inconsistent, with many commands doing more or less than they really needed to do. This change is the first of a couple to clean this up. Two new attributes have been added to the base `Command` class: `needs_api` and `needs_scm_client`. Subclasses can set these to `True` depending on their needs, and then prior to `main` being called, the initialization process will set various attributes: `api_client`, `api_root`, `capabilities`, `repository_info`, `server_url`, and `tool`. This change handles most of the initialization process. The one major remaining piece are the calls to `find_server_repository_info`, which will require some more involved changes (for example, short-cutting in the case when REPOSITORY_NAME or REPOSITORY_URL are defined). Testing Done: - Smoke tested basic functionality for all changed commands. - Verified `rbt patch` behavior was correct with both ID and full URL (ID only and ID + diff revision) arguments. Checked that `rbt patch --print` did not initialize any repository support. - Verified `rbt land` behavior was correct with both ID and full URL `--review-request-id` option. - Checked that `rbt status --all` did not initialize any repository support.	9ec5ab5f85c8423145ea9d69eb6d848dfaa5c48c
	Make RBTools command initialization easier and more consistent. The different commands in RBTools have lots of differerent needs. Some of them interact only with your local repository, some of them interact only with the server API, some do both, and some do neither. We've traditionally had a few methods to handle things like setting up the API or the SCMClient, but usage of these was inconsistent and resulted in a lot of repeated boilerplate. Because of this and the history of RBTools development, usage of all of this was somewhat inconsistent, with many commands doing more or less than they really needed to do. This change is the first of a couple to clean this up. Two new attributes have been added to the base `Command` class: `needs_api` and `needs_scm_client`. Subclasses can set these to `True` depending on their needs, and then prior to `main` being called, the initialization process will set various attributes: `api_client`, `api_root`, `capabilities`, `repository_info`, `server_url`, and `tool`. This change handles most of the initialization process. The one major remaining piece are the calls to `find_server_repository_info`, which will require some more involved changes (for example, short-cutting in the case when REPOSITORY_NAME or REPOSITORY_URL are defined). Testing Done: - Smoke tested basic functionality for all changed commands. - Verified `rbt patch` behavior was correct with both ID and full URL (ID only and ID + diff revision) arguments. Checked that `rbt patch --print` did not initialize any repository support. - Verified `rbt land` behavior was correct with both ID and full URL `--review-request-id` option. - Checked that `rbt status --all` did not initialize any repository support.	7a393157dfa946d52898718a1e5d0a969df39591

Diff:

Revision 5 (+970 -768)

Show changes

	rbtools/commands/__init__.py
	rbtools/commands/api_get.py
	rbtools/commands/attach.py
	rbtools/commands/close.py
	rbtools/commands/diff.py
	rbtools/commands/info.py
	rbtools/commands/land.py
	rbtools/commands/login.py
	8 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

rbtools/commands/__init__.py (Diff revision 5)

The issue has been resolved. Show all issues

Can you add a Version Added to these (before Type)?

Status: Closed (submitted)

Change Summary:

Pushed to master (35275e6)