flake8
-
rbtools/api/transport/sync.py (Diff revision 1) Show all issues -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
Review Request #11479 — Created Feb. 21, 2021 and updated
Information | |
---|---|
qianxi | |
RBTools | |
master | |
Reviewers | |
rbtools | |
The reason why we need api command instead of api-get is simple: We need to do HTTP GET, POST, PUT, DELETE requests.
I createdapi
command, with new options--get
,--post
,--put
,--delete
,--data=key1=value1
,--header=headercontent
, original--pretty
option and server options still work.
I'll add support for file data POST and PUT later.
Please omit "Merge XDG project changes in local branch into local master" commit, I believe the commit content should be the same as https://reviews.reviewboard.org/r/11423/.
For api
--get
,--post
,--put
,--delete
options, I did some basic testings using command line tools. They all work for non-existed urls and--get
works for existing api resources. We can use--data=key1=value1
to add post data and use--header=headercontent
to add customized headers. And--pretty
option still works. I will do further testing later.
Summary |
---|
Description | From | Last Updated |
---|---|---|
E225 missing whitespace around operator |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W291 trailing whitespace |
![]() |
|
W291 trailing whitespace |
![]() |
|
W291 trailing whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
F401 'rbtools.commands.OptionGroup' imported but unused |
![]() |
|
E302 expected 2 blank lines, found 1 |
![]() |
|
E128 continuation line under-indented for visual indent |
![]() |
|
W503 line break before binary operator |
![]() |
|
W291 trailing whitespace |
![]() |
|
W291 trailing whitespace |
![]() |
|
E128 continuation line under-indented for visual indent |
![]() |
|
W503 line break before binary operator |
![]() |
|
E303 too many blank lines (2) |
![]() |
|
E231 missing whitespace after ':' |
![]() |
|
W291 trailing whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W391 blank line at end of file |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W291 trailing whitespace |
![]() |
|
W291 trailing whitespace |
![]() |
|
W291 trailing whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W391 blank line at end of file |
![]() |
|
W293 blank line contains whitespace |
![]() |
|
W292 no newline at end of file |
![]() |
rbtools/api/transport/sync.py (Diff revision 1) |
---|
Fix coding style problems
Commits: |
|
||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+1120 -218) |
Fix more coding style problems.
Commits: |
|
||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+1124 -226) |
Add a newline character
Commits: |
|
||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+1125 -227) |