Summary

Add a new `rbt api` command and support `--get`, `--put`, `--post` and `--delete` options.

Review Request #11479 — Created Feb. 21, 2021 and updated April 7, 2021, 5:52 p.m.

Information

Owner

qianxi

Repository

RBTools

Branch

master

Bugs

Depends On

Reviewers

Groups

rbtools

People

Description

The reason why we need api command instead of api-get is simple: We need to do HTTP GET, POST, PUT, DELETE requests.
I created api command, with new options --get, --post, --put, --delete, --patch, --file="local path", --data='key1=value1', --header='headercontent' , original --pretty option and server options still work.

Testing Done

For api --get, --post, --put, --delete options, I did some testings using command line tools.

I created a review request draft and used my --get, --post, --put and --delete options, they all worked fine.
I posted several files to the review request draft using --post and --file options and they worked.
I don't think our reviewboard APIs support --patch at this moment so I just left it there in case one day it will be useful.

Commits

Summary	ID
Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
Add a newline character.	3058676f474918449c806faea1fe1787e168e659
Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
Fix coding style problems.	232ae21dc68075b4259ced72f86563e006f007cd
Remove .DS_Store file.	83d5cbb5a8c9b8c0bba6a2dfaa3660afb84a4abd
Add __future__ module doc string.	187b2ab7edcefd834a8c8da1cf62e03704c1605b
Refactor code. Fix improper usage of variables.	aa3ebd0cc4f78e6fb887d7d7aedc30ab1e5b464f
Fix coding style problems.	dc68ac243b80d790d14d519b582e161fe371f941
Fix coding style problems.	b8a14bb190c4e8f99bb37d71eaa8a2161149c501
Fix trailing space problems.	5b9e1d3306d68e41892698b96c063439efaa9c49

Issues

Description	From	Last Updated
Please remove the .DS_Store file from your change.	david	March 26, 2021, 4:51 p.m.
E225 missing whitespace around operator	reviewbot	Feb. 21, 2021, 2:49 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 21, 2021, 2:49 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 21, 2021, 2:50 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 21, 2021, 2:50 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 21, 2021, 2:50 p.m.
W291 trailing whitespace	reviewbot	Feb. 21, 2021, 2:50 p.m.
W291 trailing whitespace	reviewbot	Feb. 21, 2021, 2:50 p.m.
W291 trailing whitespace	reviewbot	Feb. 21, 2021, 2:50 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 21, 2021, 2:51 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 21, 2021, 2:51 p.m.
F401 'rbtools.commands.OptionGroup' imported but unused	reviewbot	Feb. 21, 2021, 2:52 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Feb. 21, 2021, 2:52 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Feb. 21, 2021, 2:54 p.m.
W503 line break before binary operator	reviewbot	Feb. 21, 2021, 2:56 p.m.
W291 trailing whitespace	reviewbot	Feb. 21, 2021, 2:57 p.m.
W291 trailing whitespace	reviewbot	Feb. 21, 2021, 2:57 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Feb. 21, 2021, 2:57 p.m.
W503 line break before binary operator	reviewbot	Feb. 21, 2021, 2:58 p.m.
E303 too many blank lines (2)	reviewbot	Feb. 21, 2021, 2:58 p.m.
E231 missing whitespace after ':'	reviewbot	Feb. 21, 2021, 2:59 p.m.
W291 trailing whitespace	reviewbot	Feb. 21, 2021, 2:59 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 21, 2021, 2:59 p.m.
W391 blank line at end of file	reviewbot	Feb. 21, 2021, 3 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 21, 2021, 3:08 p.m.
W291 trailing whitespace	reviewbot	Feb. 21, 2021, 3:08 p.m.
W291 trailing whitespace	reviewbot	Feb. 21, 2021, 3:07 p.m.
W291 trailing whitespace	reviewbot	Feb. 21, 2021, 3:07 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 21, 2021, 3:07 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 21, 2021, 3:07 p.m.
W391 blank line at end of file	reviewbot	Feb. 21, 2021, 3:06 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 21, 2021, 3:06 p.m.
W292 no newline at end of file	reviewbot	Feb. 21, 2021, 3:11 p.m.
F841 local variable 'e' is assigned to but never used	reviewbot	March 14, 2021, 2:25 p.m.
E231 missing whitespace after ','	reviewbot	March 14, 2021, 2:25 p.m.
W293 blank line contains whitespace	reviewbot	March 14, 2021, 2:25 p.m.
E265 block comment should start with '# '	reviewbot	March 14, 2021, 2:26 p.m.
W291 trailing whitespace	reviewbot	March 14, 2021, 2:26 p.m.
W291 trailing whitespace	reviewbot	March 14, 2021, 2:26 p.m.
E228 missing whitespace around modulo operator	reviewbot	March 14, 2021, 2:29 p.m.
F841 local variable 'e' is assigned to but never used	reviewbot	March 20, 2021, 3:42 p.m.
E265 block comment should start with '# '	reviewbot	March 20, 2021, 3:42 p.m.
W291 trailing whitespace	reviewbot	March 20, 2021, 3:42 p.m.
E231 missing whitespace after ':'	reviewbot	March 20, 2021, 3:43 p.m.
E231 missing whitespace after ':'	reviewbot	March 20, 2021, 3:43 p.m.
E231 missing whitespace after ':'	reviewbot	March 20, 2021, 3:43 p.m.
E501 line too long (82 > 79 characters)	reviewbot	March 20, 2021, 3:43 p.m.
E303 too many blank lines (2)	reviewbot	March 20, 2021, 3:43 p.m.
F841 local variable 'name' is assigned to but never used	reviewbot	March 20, 2021, 10:55 p.m.
This should be reverted.	david	March 26, 2021, 1:49 p.m.
Please restore this blank line.	david	March 26, 2021, 1:49 p.m.
This needs a method docstring.	david	March 26, 2021, 3:40 p.m.
This should probably be defined as a raw string (prefix with r, like `r'(...)+')	david	March 26, 2021, 4:09 p.m.
Should this be KeyError instead of just Exception?	david	March 26, 2021, 1:51 p.m.
Should this be using the data variable you just defined?	david	March 26, 2021, 1:52 p.m.
This needs a method docstring.	david	March 26, 2021, 4:05 p.m.
Please use single quotes instead of double.	david	March 26, 2021, 1:52 p.m.
This needs a method docstring.	david	March 26, 2021, 3:40 p.m.
Blank line between these two	david	March 26, 2021, 1:52 p.m.
This needs a method docstring.	david	March 26, 2021, 3:41 p.m.
This needs a method docstring.	david	March 26, 2021, 3:41 p.m.
Should this be KeyError?	david	March 26, 2021, 1:53 p.m.
We're doing this a lot. Perhaps we can have a helper method to sanitize the URL?	david	March 26, 2021, 2:46 p.m.
Please use single quotes instead of double.	david	March 26, 2021, 1:53 p.m.
This needs a method docstring.	david	March 26, 2021, 3:41 p.m.
This needs a method docstring.	david	March 26, 2021, 3:41 p.m.
Please use single quotes instead of double.	david	March 26, 2021, 1:54 p.m.
This needs a method docstring.	david	March 26, 2021, 3:41 p.m.
This needs a method docstring.	david	March 26, 2021, 3:41 p.m.
Might be nice to have a helper for this too.	david	March 26, 2021, 3:41 p.m.
Please use single quotes instead of double.	david	March 26, 2021, 1:54 p.m.
This needs a method docstring.	david	March 26, 2021, 3:41 p.m.
KeyError?	david	March 26, 2021, 1:54 p.m.
Please use single quotes instead of double.	david	March 26, 2021, 1:54 p.m.
This needs a method docstring.	david	March 26, 2021, 3:41 p.m.
This needs a method docstring.	david	March 26, 2021, 3:41 p.m.
Please revert these changes--it's just churn in blank lines for no purpose.	david	March 26, 2021, 1:55 p.m.
Same here--move the blank line back, please.	david	March 26, 2021, 1:58 p.m.
Please revert the changes in this file.	david	March 26, 2021, 1:58 p.m.
This needs a module docstring.	david	March 26, 2021, 5:08 p.m.
This needs a class docstring.	david	March 26, 2021, 2:02 p.m.
How about "Perform Review Board API requests"? Note also that when we wrap a string, we put the space at …	david	March 26, 2021, 2:04 p.m.
Put the space at the end of the first line instead of beginning of the second.	david	March 26, 2021, 2:04 p.m.
Please swap the use of single and double quotes here.	david	March 26, 2021, 2:05 p.m.
Swap single and double quotes here.	david	March 26, 2021, 2:05 p.m.
This needs a method docstring.	david	March 26, 2021, 4:04 p.m.
This first part needs to fit on a single line. Simply "Handle HTTP requests" is probably sufficient--the arguments are listed …	david	March 26, 2021, 2:06 p.m.
This should probably mention that it prints output. Alternatively, this method could just return the request and the caller could …	david	March 26, 2021, 2:11 p.m.
There's an extra blank line here.	david	March 26, 2021, 2:12 p.m.
This blank line can be removed.	david	March 26, 2021, 2:13 p.m.
Please use single quotes.	david	March 26, 2021, 2:13 p.m.
Please use single quotes.	david	March 26, 2021, 2:13 p.m.
Please use single quotes.	david	March 26, 2021, 2:14 p.m.
Please use single quotes. This should also wrap with each entry on its own line. We could even avoid defining …	david	March 26, 2021, 2:15 p.m.
This needs a docstring.	david	March 26, 2021, 3:56 p.m.
Add a blank line between these two.	david	March 26, 2021, 2:15 p.m.
This should probably print an error (probably different errors depending on if no method was passed, or if multiple methods …	david	March 26, 2021, 2:24 p.m.
This should be reverted.	david	March 26, 2021, 1:45 p.m.
Please revert the changes to this file.	david	March 26, 2021, 1:42 p.m.
Please revert the changes to this file.	david	March 26, 2021, 1:41 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 26, 2021, 4:22 p.m.
W291 trailing whitespace	reviewbot	March 26, 2021, 4:23 p.m.
W291 trailing whitespace	reviewbot	March 26, 2021, 4:23 p.m.
This isn't ultimately useful to have here in our codebase. It's a great thing to learn! But these imports are …	chipx86	March 29, 2021, 7:10 p.m.
Can you rename this to _get_padded_url? That's a better fit for the naming we aim for. We want to communicate …	chipx86	March 29, 2021, 7:12 p.m.
Likewise, this would be better as "Returns a URL ending with a slash." ("URL" should always be capitalized.)	chipx86	March 29, 2021, 7:12 p.m.
For "Returns", the description text can't be indented. We do indent for "Args," because we're have a list of arguments. …	chipx86	March 29, 2021, 7:15 p.m.
"The URL or path ending with a '/'." would be better.	chipx86	March 29, 2021, 7:16 p.m.
We can probably simplify this: if not url.ensdwith('/'): url = '%s/' % url return url Avoids the creation of a …	chipx86	March 29, 2021, 7:16 p.m.
You can probably replace this with Python's urljoin function.	chipx86	March 29, 2021, 7:47 p.m.
No indentation for descriptions in "Returns". This will apply to any others throughout this change.	chipx86	March 29, 2021, 7:17 p.m.
Is this for querystrings? If so, check out Python's parse_qsl function. Look at HttpRequest in RBTools for code already doing …	chipx86	April 7, 2021, 4:14 p.m.
The naming may seem unrelated, but this is actually already available to us in Python's email module as email.message_from_string. This …	chipx86	April 7, 2021, 3:48 p.m.
Should always be capitalized as "URL". Same elsewhere in the change.	chipx86	March 29, 2021, 7:21 p.m.
Repeating ourselves for each method can end up increasing our maintenance burden. Instead, since these are all wrapping a centralized …	chipx86	April 7, 2021, 4:14 p.m.
Instead of dict.items(), we need to do six.iteritems(dict) to get consistent behavior across Python 2 and 3. Same anywhere else …	chipx86	April 7, 2021, 2:41 p.m.
All these _path versions of these functions seem to have the same logic as the _url versions, but are creating …	chipx86	April 7, 2021, 2:39 p.m.
All these blank lines need to remain.	chipx86	March 29, 2021, 7:22 p.m.
This should be removed, for the same reason above.	chipx86	March 29, 2021, 7:22 p.m.
rbt api --post Other examples are also missing the api bit.	chipx86	March 29, 2021, 7:23 p.m.
I think we shouldn't say too much more than "Send a HTTP PATCH request to an API" (and same for …	chipx86	March 29, 2021, 7:25 p.m.
All private functions should follow public functions.	chipx86	March 29, 2021, 7:26 p.m.
You probably want a blank line here.	chipx86	March 29, 2021, 7:27 p.m.
self.options.pretty_print is a reference to internal code. Write these docs like nobody's reading your code. You probably want to say …	chipx86	March 29, 2021, 7:28 p.m.
This is missing a return type. We're also not streaming to anything. We're just returning a string.	chipx86	April 7, 2021, 2 p.m.
Comma should be on the prior line.	chipx86	March 29, 2021, 7:30 p.m.
"JSON"	chipx86	March 29, 2021, 7:30 p.m.
You want a blank line before the statement and the loop, but not on the first inner line of the …	chipx86	March 29, 2021, 7:31 p.m.
This can be simplified massively by doing a couple things: Have each HTTP method option (--get, --post, etc.) have an …	chipx86	April 7, 2021, 2:19 p.m.
startswith takes a tuple, for convenience: if path.startswith(('http://', 'https://')):	chipx86	April 7, 2021, 2:19 p.m.
This will need to be the full import class path.	chipx86	April 7, 2021, 2:20 p.m.
I think we want to avoid allowing anything unexpected to be a query argument. What if an API takes a …	chipx86	April 7, 2021, 4:14 p.m.
The above recommendation about the HTTP method options will eliminate all of this. Now, that doesn't mean that it'll duplicate …	chipx86	March 28, 2021, 9:35 p.m.
F401 'email' imported but unused	reviewbot	April 7, 2021, 5:31 p.m.
F401 're' imported but unused	reviewbot	April 7, 2021, 5:31 p.m.
F401 'urllib.parse.urljoin' imported but unused	reviewbot	April 7, 2021, 5:31 p.m.
W291 trailing whitespace	reviewbot	April 7, 2021, 5:31 p.m.
F841 local variable 'body_dict' is assigned to but never used	reviewbot	April 7, 2021, 5:32 p.m.
F841 local variable 'file_path_list' is assigned to but never used	reviewbot	April 7, 2021, 5:32 p.m.
W293 blank line contains whitespace	reviewbot	April 7, 2021, 5:33 p.m.
W291 trailing whitespace	reviewbot	April 7, 2021, 5:34 p.m.
F841 local variable 'file_path_list' is assigned to but never used	reviewbot	April 7, 2021, 5:34 p.m.
F841 local variable 'file_path_list' is assigned to but never used	reviewbot	April 7, 2021, 5:34 p.m.
F841 local variable 'body_dict' is assigned to but never used	reviewbot	April 7, 2021, 5:35 p.m.
F841 local variable 'file_path_list' is assigned to but never used	reviewbot	April 7, 2021, 5:35 p.m.
F401 'argparse' imported but unused	reviewbot	April 7, 2021, 5:35 p.m.
F401 'rbtools.commands.ParseError' imported but unused	reviewbot	April 7, 2021, 5:39 p.m.
F841 local variable 'query_dict' is assigned to but never used	reviewbot	April 7, 2021, 5:40 p.m.
E501 line too long (80 > 79 characters)	reviewbot	April 7, 2021, 5:43 p.m.
W293 blank line contains whitespace	reviewbot	April 7, 2021, 5:44 p.m.
F841 local variable 'query_arguments' is assigned to but never used	reviewbot	April 7, 2021, 5:44 p.m.
E501 line too long (82 > 79 characters)	reviewbot	April 7, 2021, 5:47 p.m.
E501 line too long (80 > 79 characters)	reviewbot	April 7, 2021, 5:47 p.m.
E501 line too long (80 > 79 characters)	reviewbot	April 7, 2021, 5:47 p.m.
E501 line too long (80 > 79 characters)	reviewbot	April 7, 2021, 5:48 p.m.
W291 trailing whitespace	reviewbot	April 7, 2021, 5:52 p.m.
W291 trailing whitespace	reviewbot	April 7, 2021, 5:52 p.m.
W291 trailing whitespace	reviewbot	April 7, 2021, 5:52 p.m.

flake8 failed.

JSHint passed.

flake8

rbtools/api/transport/sync.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E225 missing whitespace around operator
```
rbtools/api/transport/sync.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/api/transport/sync.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/api/transport/sync.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/api/transport/sync.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/api/transport/sync.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/api/transport/sync.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/api/transport/sync.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/api/transport/sync.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/__init__.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/api.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'rbtools.commands.OptionGroup' imported but unused
```
rbtools/commands/api.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E302 expected 2 blank lines, found 1
```
rbtools/commands/api.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
rbtools/commands/api.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W503 line break before binary operator
```
rbtools/commands/api.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/commands/api.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/commands/api.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E128 continuation line under-indented for visual indent
```
rbtools/commands/api.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W503 line break before binary operator
```
rbtools/commands/api.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```
rbtools/commands/api.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
rbtools/commands/api.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/commands/api.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/api.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```

Change Summary:

Fix coding style problems

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9

Diff:

Revision 2 (+1120 -218)

Show changes

	.DS_Store
	setup.py
	contrib/tools/git-hook-check-approval
	rbtools/.DS_Store
	rbtools/api/client.py
	rbtools/api/request.py
	rbtools/api/tests/test_http_request.py
	rbtools/api/transport/sync.py
	9 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/api/transport/sync.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/api/transport/sync.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/api/transport/sync.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/api/transport/sync.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/api/transport/sync.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/__init__.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/api.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W391 blank line at end of file
```
rbtools/commands/api.py (Diff revision 2)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```

Change Summary:

Fix more coding style problems.

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378

Diff:

Revision 3 (+1124 -226)

Show changes

	.DS_Store
	setup.py
	contrib/tools/git-hook-check-approval
	rbtools/.DS_Store
	rbtools/api/client.py
	rbtools/api/request.py
	rbtools/api/tests/test_http_request.py
	rbtools/api/transport/sync.py
	9 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/api.py (Diff revision 3)
The issue has been resolved. Show all issues
```
W292 no newline at end of file
```

Change Summary:

Add a newline character

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659

Diff:

Revision 4 (+1125 -227)

Show changes

	.DS_Store
	setup.py
	contrib/tools/git-hook-check-approval
	rbtools/.DS_Store
	rbtools/api/client.py
	rbtools/api/request.py
	rbtools/api/tests/test_http_request.py
	rbtools/api/transport/sync.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

Revert commits from another project.

Summary:

Add `api` command and options like `--get`, `--post`, `--put`, `--delete`, `--data=key1=value1` and `--header=headercontent`

Add a new `rbt api` command and support `--get`, `--put`, `--post` and `--delete` options.

Description:

		The reason why we need api command instead of api-get is simple: We need to do HTTP GET, POST, PUT, DELETE requests.
~		I created `api` command, with new options `--get`, `--post`, `--put`, `--delete`, `--data=key1=value1`, `--header=headercontent` , original `--pretty` option and server options still work.
	~	I created `api` command, with new options `--get`, `--post`, `--put`, `--delete`, `--data='key1=value1'`, `--header='headercontent'` , original `--pretty` option and server options still work.
-		I'll add support for file data POST and PUT later.
-		Please omit "Merge XDG project changes in local branch into local master" commit, I believe the commit content should be the same as https://reviews.reviewboard.org/r/11423/.

Testing Done:

~		For api `--get`, `--post`, `--put`, `--delete` options, I did some basic testings using command line tools. They all work for non-existed urls and `--get` works for existing api resources. We can use `--data=key1=value1` to add post data and use `--header=headercontent` to add customized headers. And `--pretty` option still works. I will do further testing later.
	~	For api `--get`, `--post`, `--put`, `--delete` options, I did some testings using command line tools.
	+
	+	I created a review request draft and used my `--get`, `--post`, `--put` and `--delete` options, they all worked fine.

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b

Diff:

Revision 5 (+1385 -617)

Show changes

	setup.py
	contrib/tools/git-hook-check-approval
	rbtools/.DS_Store
	rbtools/api/client.py
	rbtools/api/factory.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	4 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/api/transport/sync.py (Diff revision 5)
The issue has been resolved. Show all issues
```
F841 local variable 'e' is assigned to but never used
```
rbtools/api/transport/sync.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ','
```
rbtools/api/transport/sync.py (Diff revision 5)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/api/transport/sync.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E265 block comment should start with '# '
```
rbtools/commands/api.py (Diff revision 5)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/commands/api.py (Diff revision 5)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/commands/api.py (Diff revision 5)
The issue has been resolved. Show all issues
```
E228 missing whitespace around modulo operator
```

Change Summary:

Fix coding style problems.

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c

Diff:

Revision 6 (+1389 -625)

Show changes

	setup.py
	contrib/tools/git-hook-check-approval
	rbtools/.DS_Store
	rbtools/api/client.py
	rbtools/api/factory.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

		The reason why we need api command instead of api-get is simple: We need to do HTTP GET, POST, PUT, DELETE requests.
~		I created `api` command, with new options `--get`, `--post`, `--put`, `--delete`, `--data='key1=value1'`, `--header='headercontent'` , original `--pretty` option and server options still work.
	~	I created `api` command, with new options `--get`, `--post`, `--put`, `--delete`, `--patch`, `--file="local path"`, `--data='key1=value1'`, `--header='headercontent'` , original `--pretty` option and server options still work.

Testing Done:

		For api `--get`, `--post`, `--put`, `--delete` options, I did some testings using command line tools.

~		I created a review request draft and used my `--get`, `--post`, `--put` and `--delete` options, they all worked fine.
	~	I created a review request draft and used my `--get`, `--post`, `--put` and `--delete` options, they all worked fine.
	+	I don't think our reviewboard APIs support `--patch` so I just left it there in case one day it will be useful.

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3

Diff:

Revision 7 (+1570 -632)

Show changes

	setup.py
	contrib/tools/git-hook-check-approval
	rbtools/.DS_Store
	rbtools/api/client.py
	rbtools/api/factory.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	4 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/api/transport/sync.py (Diff revision 7)
The issue has been resolved. Show all issues
```
F841 local variable 'e' is assigned to but never used
```
rbtools/api/transport/sync.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E265 block comment should start with '# '
```
rbtools/api/transport/sync.py (Diff revision 7)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/commands/api.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
rbtools/commands/api.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
rbtools/commands/api.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E231 missing whitespace after ':'
```
rbtools/commands/api.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E501 line too long (82 > 79 characters)
```
rbtools/commands/api.py (Diff revision 7)
The issue has been resolved. Show all issues
```
E303 too many blank lines (2)
```

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371

Diff:

Revision 8 (+1575 -637)

Show changes

	setup.py
	contrib/tools/git-hook-check-approval
	rbtools/.DS_Store
	rbtools/api/client.py
	rbtools/api/factory.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Testing Done:

		For api `--get`, `--post`, `--put`, `--delete` options, I did some testings using command line tools.

		I created a review request draft and used my `--get`, `--post`, `--put` and `--delete` options, they all worked fine.
~		I don't think our reviewboard APIs support `--patch` so I just left it there in case one day it will be useful.
	~	I posted several files to the review request draft using `--post` and `--file` options and they worked.
	+	I don't think our reviewboard APIs support `--patch` at this moment so I just left it there in case one day it will be useful.

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076

Diff:

Revision 9 (+1593 -647)

Show changes

	setup.py
	contrib/tools/git-hook-check-approval
	rbtools/.DS_Store
	rbtools/api/client.py
	rbtools/api/factory.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	4 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/api.py (Diff revision 9)
The issue has been resolved. Show all issues
```
F841 local variable 'name' is assigned to but never used
```

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24

Diff:

Revision 10 (+1591 -649)

Show changes

	setup.py
	contrib/tools/git-hook-check-approval
	rbtools/.DS_Store
	rbtools/api/client.py
	rbtools/api/factory.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	4 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Please remove the .DS_Store file from your change.

contrib/tools/git-hook-check-approval (Diff revision 10)
The issue has been resolved. Show all issues
```
This should be reverted.
```
rbtools/api/factory.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Please restore this blank line.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This should probably be defined as a raw string (prefix with r, like `r'(...)+')
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Should this be KeyError instead of just Exception?
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Should this be using the data variable you just defined?
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Please use single quotes instead of double.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Blank line between these two
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Should this be KeyError?
```

rbtools/api/transport/sync.py (Diff revision 10)

The issue has been resolved. Show all issues

We're doing this a lot. Perhaps we can have a helper method to sanitize the URL?

rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Please use single quotes instead of double.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Please use single quotes instead of double.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Might be nice to have a helper for this too.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Please use single quotes instead of double.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
KeyError?
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Please use single quotes instead of double.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```
rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```

rbtools/api/transport/sync.py (Diff revision 10)

The issue has been resolved. Show all issues

Please revert these changes--it's just churn in blank lines for no purpose.

qianxi March 26, 2021, 4:09 p.m.

Sorry about this, I was doing a lot of print statements around here and forgot to restore the spaces.

rbtools/api/transport/sync.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Same here--move the blank line back, please.
```
rbtools/commands/__init__.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Please revert the changes in this file.
```
rbtools/commands/api.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a module docstring.
```
rbtools/commands/api.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a class docstring.
```

rbtools/commands/api.py (Diff revision 10)

The issue has been resolved. Show all issues

How about "Perform Review Board API requests"?

Note also that when we wrap a string, we put the space at the end of the first line instead of the beginning of the second. Your way is probably less error-prone but all of existing code that does it the other way.

qianxi March 26, 2021, 4:09 p.m.
```
Got it.
```

rbtools/commands/api.py (Diff revision 10)

The issue has been resolved. Show all issues

Put the space at the end of the first line instead of beginning of the second.

rbtools/commands/api.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Please swap the use of single and double quotes here.
```
rbtools/commands/api.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Swap single and double quotes here.
```
rbtools/commands/api.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a method docstring.
```

rbtools/commands/api.py (Diff revision 10)

The issue has been resolved. Show all issues

This first part needs to fit on a single line. Simply "Handle HTTP requests" is probably sufficient--the arguments are listed in the method definition and the docstring below.

rbtools/commands/api.py (Diff revision 10)

The issue has been resolved. Show all issues

This should probably mention that it prints output.
Alternatively, this method could just return the request and the caller could print.

rbtools/commands/api.py (Diff revision 10)
The issue has been resolved. Show all issues
```
There's an extra blank line here.
```
rbtools/commands/api.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This blank line can be removed.
```
rbtools/commands/api.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Please use single quotes.
```
rbtools/commands/api.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Please use single quotes.
```
rbtools/commands/api.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Please use single quotes.
```

rbtools/commands/api.py (Diff revision 10)

The issue has been resolved. Show all issues

Please use single quotes. This should also wrap with each entry on its own line. We could even avoid defining the variable and just put it inline:

full_file_list.append({
    'filename': file_name,
    'content': content,
})

rbtools/commands/api.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This needs a docstring.
```
rbtools/commands/api.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Add a blank line between these two.
```

rbtools/commands/api.py (Diff revision 10)

The issue has been resolved. Show all issues

This should probably print an error (probably different errors depending on if no method was passed, or if multiple methods were passed)

rbtools/commands/api_get.py (Diff revision 10)
The issue has been resolved. Show all issues
```
This should be reverted.
```
rbtools/commands/main.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Please revert the changes to this file.
```
rbtools/utils/filesystem.py (Diff revision 10)
The issue has been resolved. Show all issues
```
Please revert the changes to this file.
```

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3

Diff:

Revision 11 (+2649 -759)

Show changes

	setup.py
	rbtools/.DS_Store
	rbtools/api/client.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	rbtools/commands/api.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/api/transport/sync.py (Diff revision 11)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
rbtools/api/transport/sync.py (Diff revision 11)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/api/transport/sync.py (Diff revision 11)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
	Fix coding style problems.	232ae21dc68075b4259ced72f86563e006f007cd

Diff:

Revision 12 (+2653 -763)

Show changes

	setup.py
	rbtools/.DS_Store
	rbtools/api/client.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	rbtools/commands/api.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
	Fix coding style problems.	232ae21dc68075b4259ced72f86563e006f007cd
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
	Fix coding style problems.	232ae21dc68075b4259ced72f86563e006f007cd
	Remove .DS_Store file.	83d5cbb5a8c9b8c0bba6a2dfaa3660afb84a4abd

Diff:

Revision 13 (+2653 -763)

Show changes

	setup.py
	rbtools/api/client.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	rbtools/commands/api.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
	Fix coding style problems.	232ae21dc68075b4259ced72f86563e006f007cd
	Remove .DS_Store file.	83d5cbb5a8c9b8c0bba6a2dfaa3660afb84a4abd
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
	Fix coding style problems.	232ae21dc68075b4259ced72f86563e006f007cd
	Remove .DS_Store file.	83d5cbb5a8c9b8c0bba6a2dfaa3660afb84a4abd
	Add __future__ module doc string.	187b2ab7edcefd834a8c8da1cf62e03704c1605b

Diff:

Revision 14 (+2681 -763)

Show changes

	setup.py
	rbtools/api/client.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	rbtools/commands/api.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Fix it!

rbtools/api/transport/sync.py (Diff revision 14)

The issue has been resolved. Show all issues

This isn't ultimately useful to have here in our codebase. It's a great thing to learn! But these imports are present in every single file in all of our codebases, so we don't want to document it in each file.

rbtools/api/transport/sync.py (Diff revision 14)

The issue has been resolved. Show all issues

Can you rename this to _get_padded_url? That's a better fit for the naming we aim for. We want to communicate that this gets (returns) something, and that the thing it's returning is a padded URL.

rbtools/api/transport/sync.py (Diff revision 14)

The issue has been resolved. Show all issues

Likewise, this would be better as "Returns a URL ending with a slash."

("URL" should always be capitalized.)

rbtools/api/transport/sync.py (Diff revision 14)

The issue has been resolved. Show all issues

For "Returns", the description text can't be indented. We do indent for "Args," because we're have a list of arguments. "Returns" doesn't work this way, and this will ultimately render incorrectly.

rbtools/api/transport/sync.py (Diff revision 14)
The issue has been resolved. Show all issues
```
"The URL or path ending with a '/'." would be better.
```

rbtools/api/transport/sync.py (Diff revision 14)

The issue has been resolved. Show all issues

We can probably simplify this:

if not url.ensdwith('/'):
    url = '%s/' % url

return url


Avoids the creation of a new variable.
%-based formatting is also generally faster (Python compiles it down to bytecode)

rbtools/api/transport/sync.py (Diff revision 14)
The issue has been resolved. Show all issues
```
You can probably replace this with Python's urljoin function.
```

rbtools/api/transport/sync.py (Diff revision 14)

The issue has been resolved. Show all issues

No indentation for descriptions in "Returns".

This will apply to any others throughout this change.

rbtools/api/transport/sync.py (Diff revision 14)

The issue has been resolved. Show all issues

Is this for querystrings? If so, check out Python's parse_qsl function.

Look at HttpRequest in RBTools for code already doing this.

rbtools/api/transport/sync.py (Diff revision 14)

The issue has been resolved. Show all issues

The naming may seem unrelated, but this is actually already available to us in Python's email module as email.message_from_string. This is used under-the-hood for Python's own HTTP header parsing, as it's the same standard.
You can do something like this (I'm copying from the Python shell):

>>> import email
>>> dict(email.message_from_string(
...     'User-Agent: foo\n'
...     'Content-Type: bar\n'
...     'X-Custom: foobar!')
{'X-Custom': 'foobar!', 'Content-Type': 'bar', 'User-Agent': 'foo'}

rbtools/api/transport/sync.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Should always be capitalized as "URL".
Same elsewhere in the change.
```

rbtools/api/transport/sync.py (Diff revision 14)

The issue has been resolved. Show all issues

Repeating ourselves for each method can end up increasing our maintenance burden. Instead, since these are all wrapping a centralized function, it's probably best to just document it there and instead refer readers to that in args.

However, it's not quite right to pass in a dictionary as an argument and have that contain what's effectively keyword arguments. It would be better to make each of these things a new keyword argument.

Same goes for all other functions doing this.

rbtools/api/transport/sync.py (Diff revision 14)

The issue has been resolved. Show all issues

Instead of dict.items(), we need to do six.iteritems(dict) to get consistent behavior across Python 2 and 3.
Same anywhere else this may be done.

rbtools/api/transport/sync.py (Diff revision 14)

The issue has been resolved. Show all issues

All these _path versions of these functions seem to have the same logic as the _url versions, but are creating an absolute URL.

How about just keeping the _path versions simple. have them call the _url version, but with the absolute URL (through urljoin).

rbtools/commands/__init__.py (Diff revision 14)
The issue has been resolved. Show all issues
```
All these blank lines need to remain.
```

rbtools/commands/api.py (Diff revision 14)

The issue has been resolved. Show all issues

This should be removed, for the same reason above.

rbtools/commands/api.py (Diff revision 14)
The issue has been resolved. Show all issues
```
rbt api --post
Other examples are also missing the api bit.
```

rbtools/commands/api.py (Diff revision 14)

The issue has been resolved. Show all issues

I think we shouldn't say too much more than "Send a HTTP PATCH request to an API" (and same for other HTTP methods).

rbtools/commands/api.py (Diff revision 14)
The issue has been resolved. Show all issues
```
All private functions should follow public functions.
```
rbtools/commands/api.py (Diff revision 14)
The issue has been resolved. Show all issues
```
You probably want a blank line here.
```

rbtools/commands/api.py (Diff revision 14)

The issue has been resolved. Show all issues

self.options.pretty_print is a reference to internal code. Write these docs like nobody's reading your code. You probably want to say something like:

If the :option:`--pretty` option is passed to the command, ...

rbtools/commands/api.py (Diff revision 14)

The issue has been resolved. Show all issues

This is missing a return type.
We're also not streaming to anything. We're just returning a string.

rbtools/commands/api.py (Diff revision 14)
The issue has been resolved. Show all issues
```
Comma should be on the prior line.
```
rbtools/commands/api.py (Diff revision 14)
The issue has been resolved. Show all issues
```
"JSON"
```

rbtools/commands/api.py (Diff revision 14)

The issue has been resolved. Show all issues

You want a blank line before the statement and the loop, but not on the first inner line of the loop.

rbtools/commands/api.py (Diff revision 14)

The issue has been resolved. Show all issues

This can be simplified massively by doing a couple things:


Have each HTTP method option (--get, --post, etc.) have an action of store_const, setting a central attribute (say, 'http_method') to a value (get, post, etc.).


Update this code to compute the correct function to call:



http_method = self.options.http_method

if path.startswith(...):
    client_method_name = '%s_url' % http_method
else:
    client_method_name = '%s_path' % http_method

client_method = getattr(api_client, http_method_name)
assert client_method is not None

resource = client_method(...)

rbtools/commands/api.py (Diff revision 14)

The issue has been resolved. Show all issues

startswith takes a tuple, for convenience:

if path.startswith(('http://', 'https://')):

rbtools/commands/api.py (Diff revision 14)
The issue has been resolved. Show all issues
```
This will need to be the full import class path.
```

rbtools/commands/api.py (Diff revision 14)

The issue has been resolved. Show all issues

I think we want to avoid allowing anything unexpected to be a query argument. What if an API takes a query argument of ?get=...?

The old code did this, but it was a bad idea.

Let's instead add a --query parameter, or allow it on the URL itself.

rbtools/commands/api.py (Diff revision 14)

An issue was opened. Show all issues

The above recommendation about the HTTP method options will eliminate all of this.

Now, that doesn't mean that it'll duplicate this behavior. The way it'll work is that the last of --get, --post, etc. specified wins. That isn't ideal, but it's frankly good enough.

If we really want to protect the user here, the right solution would be to make a new action that gets passed to options, and have it warn at that time, before we do all this work.

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
	Fix coding style problems.	232ae21dc68075b4259ced72f86563e006f007cd
	Remove .DS_Store file.	83d5cbb5a8c9b8c0bba6a2dfaa3660afb84a4abd
	Add __future__ module doc string.	187b2ab7edcefd834a8c8da1cf62e03704c1605b
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
	Fix coding style problems.	232ae21dc68075b4259ced72f86563e006f007cd
	Remove .DS_Store file.	83d5cbb5a8c9b8c0bba6a2dfaa3660afb84a4abd
	Add __future__ module doc string.	187b2ab7edcefd834a8c8da1cf62e03704c1605b
	Refactor code. Fix improper usage of variables.	aa3ebd0cc4f78e6fb887d7d7aedc30ab1e5b464f

Diff:

Revision 15 (+2691 -1491)

Show changes

	setup.py
	docs/rbtools/rbt/commands/api.rst
	rbtools/api/client.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	rbtools/commands/api.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/api/transport/sync.py (Diff revision 15)
The issue has been resolved. Show all issues
```
F401 'email' imported but unused
```
rbtools/api/transport/sync.py (Diff revision 15)
The issue has been resolved. Show all issues
```
F401 're' imported but unused
```
rbtools/api/transport/sync.py (Diff revision 15)
The issue has been resolved. Show all issues
```
F401 'urllib.parse.urljoin' imported but unused
```
rbtools/api/transport/sync.py (Diff revision 15)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/api/transport/sync.py (Diff revision 15)
The issue has been resolved. Show all issues
```
F841 local variable 'body_dict' is assigned to but never used
```
rbtools/api/transport/sync.py (Diff revision 15)
The issue has been resolved. Show all issues
```
F841 local variable 'file_path_list' is assigned to but never used
```
rbtools/api/transport/sync.py (Diff revision 15)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/api/transport/sync.py (Diff revision 15)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/api/transport/sync.py (Diff revision 15)
The issue has been resolved. Show all issues
```
F841 local variable 'file_path_list' is assigned to but never used
```
rbtools/api/transport/sync.py (Diff revision 15)
The issue has been resolved. Show all issues
```
F841 local variable 'file_path_list' is assigned to but never used
```
rbtools/api/transport/sync.py (Diff revision 15)
The issue has been resolved. Show all issues
```
F841 local variable 'body_dict' is assigned to but never used
```
rbtools/api/transport/sync.py (Diff revision 15)
The issue has been resolved. Show all issues
```
F841 local variable 'file_path_list' is assigned to but never used
```
rbtools/commands/api.py (Diff revision 15)
The issue has been resolved. Show all issues
```
F401 'argparse' imported but unused
```
rbtools/commands/api.py (Diff revision 15)
The issue has been resolved. Show all issues
```
F401 'rbtools.commands.ParseError' imported but unused
```
rbtools/commands/api.py (Diff revision 15)
The issue has been resolved. Show all issues
```
F841 local variable 'query_dict' is assigned to but never used
```
rbtools/commands/api.py (Diff revision 15)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
	Fix coding style problems.	232ae21dc68075b4259ced72f86563e006f007cd
	Remove .DS_Store file.	83d5cbb5a8c9b8c0bba6a2dfaa3660afb84a4abd
	Add __future__ module doc string.	187b2ab7edcefd834a8c8da1cf62e03704c1605b
	Refactor code. Fix improper usage of variables.	aa3ebd0cc4f78e6fb887d7d7aedc30ab1e5b464f
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
	Fix coding style problems.	232ae21dc68075b4259ced72f86563e006f007cd
	Remove .DS_Store file.	83d5cbb5a8c9b8c0bba6a2dfaa3660afb84a4abd
	Add __future__ module doc string.	187b2ab7edcefd834a8c8da1cf62e03704c1605b
	Refactor code. Fix improper usage of variables.	aa3ebd0cc4f78e6fb887d7d7aedc30ab1e5b464f
	Fix coding style problems.	dc68ac243b80d790d14d519b582e161fe371f941

Diff:

Revision 16 (+2753 -1563)

Show changes

	setup.py
	docs/rbtools/rbt/commands/api.rst
	rbtools/api/client.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	rbtools/commands/api.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/api/transport/sync.py (Diff revision 16)
The issue has been resolved. Show all issues
```
W293 blank line contains whitespace
```
rbtools/commands/api.py (Diff revision 16)
The issue has been resolved. Show all issues
```
F841 local variable 'query_arguments' is assigned to but never used
```
rbtools/commands/api.py (Diff revision 16)
The issue has been resolved. Show all issues
```
E501 line too long (82 > 79 characters)
```
rbtools/commands/api.py (Diff revision 16)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
rbtools/commands/api.py (Diff revision 16)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
rbtools/commands/api.py (Diff revision 16)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
	Fix coding style problems.	232ae21dc68075b4259ced72f86563e006f007cd
	Remove .DS_Store file.	83d5cbb5a8c9b8c0bba6a2dfaa3660afb84a4abd
	Add __future__ module doc string.	187b2ab7edcefd834a8c8da1cf62e03704c1605b
	Refactor code. Fix improper usage of variables.	aa3ebd0cc4f78e6fb887d7d7aedc30ab1e5b464f
	Fix coding style problems.	dc68ac243b80d790d14d519b582e161fe371f941
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
	Fix coding style problems.	232ae21dc68075b4259ced72f86563e006f007cd
	Remove .DS_Store file.	83d5cbb5a8c9b8c0bba6a2dfaa3660afb84a4abd
	Add __future__ module doc string.	187b2ab7edcefd834a8c8da1cf62e03704c1605b
	Refactor code. Fix improper usage of variables.	aa3ebd0cc4f78e6fb887d7d7aedc30ab1e5b464f
	Fix coding style problems.	dc68ac243b80d790d14d519b582e161fe371f941
	Fix coding style problems.	b8a14bb190c4e8f99bb37d71eaa8a2161149c501

Diff:

Revision 17 (+2768 -1572)

Show changes

	setup.py
	docs/rbtools/rbt/commands/api.rst
	rbtools/api/client.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	rbtools/commands/api.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

rbtools/commands/api.py (Diff revision 17)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/commands/api.py (Diff revision 17)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```
rbtools/commands/api.py (Diff revision 17)
The issue has been resolved. Show all issues
```
W291 trailing whitespace
```

Commits:

	Summary	ID
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
	Fix coding style problems.	232ae21dc68075b4259ced72f86563e006f007cd
	Remove .DS_Store file.	83d5cbb5a8c9b8c0bba6a2dfaa3660afb84a4abd
	Add __future__ module doc string.	187b2ab7edcefd834a8c8da1cf62e03704c1605b
	Refactor code. Fix improper usage of variables.	aa3ebd0cc4f78e6fb887d7d7aedc30ab1e5b464f
	Fix coding style problems.	dc68ac243b80d790d14d519b582e161fe371f941
	Fix coding style problems.	b8a14bb190c4e8f99bb37d71eaa8a2161149c501
	Merge XDG project changes in local branch into local master	13e4b1d3a98ebb31a701b4c80c457da035d050c0
	[WIP]Add a new command called "api". Add option commands called "--get", "--post", "--delete". "api --get" option can substitute original "api-get" option now.	f5d08321dbf89a392a282e30b1cc4eba4f0d406e
	[WIP]Add api.py file, forget to stage this file in the last commit.	39de827276ea422dea3fc1f630d35c17f415ab9c
	[WIP]Add "--put" option but still need to find out how to send post/put data. Add "--header" option, still need to find a way to combine our customized header with original data.	9300eb1518e3b078f03aeb388b7f91821e915c7f
	Refactor methods in api class. Now support use --header option to add customized header in a request.	604bed2b22deb3145dcf7339753bd2096d9d8889
	[WIP]Allow basic HTTP GET, DELETE. Allow POST and PUT key value pairs. Still need further testings	f12ccfbf6346c75a934fdf6e70ee37c6e5c38702
	Remove redundant print statements from api-get.py	dc104eaacfc259f3466e0c0cf14982ccc21da57e
	Fix coding style problems.	dc4fcf3ccc29f5d6ab8243ade250c9ff830730e9
	Fix more coding style problems.	027ac7cc1ef765176d3c8a98c8fa09e9295a4378
	Add a newline character.	3058676f474918449c806faea1fe1787e168e659
	Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names.	44efa2f7a4d647cba179c40223fa31685614cd15
	Api testing	e5c49dad1d97276dbe9e4a21edb136e7984ee54e
	Test "--post" and "--put" options.	53939217e08588c88d4a410bab2b4337e8ebcfd8
	Revert "Change create create_cookie_jar function. Edit test_create_cookie_jar. Fix coding style problems. Change improper variable names." This reverts commit 44efa2f7a4d647cba179c40223fa31685614cd15.	5068e0c14b5c564f8917f221100b9b6fc084f563
	Revert "Merge XDG project changes in local branch into local master" This reverts commit 13e4b1d3a98ebb31a701b4c80c457da035d050c0.	d3baaf085443b05301478c034acc24631dfedd2b
	Fix coding style problems.	921d578ffcec441f0047bc4f4c4fc8cd3c74673c
	Add "--patch" and "--file" options. Finish testing "--post", "--put", "--get", "--delete", "--pretty" and "--header" options.	e5529638e506d696280d0f28377f017729fe53a3
	Fix coding style problems.	41fca77f0fcf26e86c9cef616e2e9ab8ce7dd371
	Fix file upload problem.	8b092c2d0797f6f2f367d0a27d163dff221f0076
	Fix redundant variable problem.	122e4a928f1513907dd14ca73289f08f33066f24
	Fix coding style problems. Add method docs. Add method helpers.	ca8f74f465f3ac16e3909f626ea649e3b8efd9b3
	Fix coding style problems.	232ae21dc68075b4259ced72f86563e006f007cd
	Remove .DS_Store file.	83d5cbb5a8c9b8c0bba6a2dfaa3660afb84a4abd
	Add __future__ module doc string.	187b2ab7edcefd834a8c8da1cf62e03704c1605b
	Refactor code. Fix improper usage of variables.	aa3ebd0cc4f78e6fb887d7d7aedc30ab1e5b464f
	Fix coding style problems.	dc68ac243b80d790d14d519b582e161fe371f941
	Fix coding style problems.	b8a14bb190c4e8f99bb37d71eaa8a2161149c501
	Fix trailing space problems.	5b9e1d3306d68e41892698b96c063439efaa9c49

Diff:

Revision 18 (+2771 -1575)

Show changes

	setup.py
	docs/rbtools/rbt/commands/api.rst
	rbtools/api/client.py
	rbtools/api/request.py
	rbtools/api/transport/sync.py
	rbtools/commands/__init__.py
	rbtools/commands/api.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.