Summary

Fix showing the base directory on the New Review Request page.

Review Request #11470 — Created Feb. 15, 2021 and submitted Feb. 16, 2021, 5:28 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

4911

Depends On

Reviewers

Groups

reviewboard

People

Description

A typo in a context variable name led to a regression with uploading
diffs in the New Review Request page that required a base directory. The
correct variable name was requiresBasedir. but it was typoed to
requiresBaseDir.

This change fixes the typo, and adds unit tests to ensure this and other
context variables won't regress in the future.

Testing Done

Unit tests pass.

Verified the field was present for Subversion repositories.

Commits

Summary	ID
Fix showing the base directory on the New Review Request page. A typo in a context variable name led to a regression with uploading diffs in the New Review Request page that required a base directory. The correct variable name was `requiresBasedir`. but it was typoed to `requiresBaseDir`. This change fixes the typo, and adds unit tests to ensure this and other context variables won't regress in the future.	28d7e18dc8602f19320e073b1388985e3d7af035

Summary

Fix showing the base directory on the New Review Request page.

A typo in a context variable name led to a regression with uploading diffs in the New Review Request page that required a base directory. The correct variable name was `requiresBasedir`. but it was typoed to `requiresBaseDir`. This change fixes the typo, and adds unit tests to ensure this and other context variables won't regress in the future.

28d7e18dc8602f19320e073b1388985e3d7af035

flake8 passed.

JSHint passed.

Bugs:

+	4911

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (b2ef548)