[WIP] Background Color Selector When Viewing Images

Review Request #11445 — Created Feb. 14, 2021 and updated

mderose
Review Board
master
reviewboard, students

This will allow users to select the colour outside of the image
to help improve visibility. For instance if an image is mostly
white and the background is white it may be difficult to
understand what the image is.

Currently fixing two bugs: the image caption is no longer centered in the image header, and in a mobile phone view the image menus (zoom and background color) are not organized neatly. Please refer to implementation progress page for this project for more details. https://www.notion.so/reviewboard/Implementation-Progress-28120acec5c34674a271f973f94261b4

Manual testing has been done to ensure that the background color of the image review page can change to white, black, grey/black checkerboard, or a custom colour for all image views.

Summary Author
Background Color Selector When Viewing Images
mderose123
Added fixed HSHint raised
mderose123
Developed event handlers for changing the background color
mderose123
Implemented the functionality to change the background color selector for the image review window for all image views. Currently the user is able to choose a white, black, black/grey checkerboard, or a custom color as a background for an image
mderose123
Addendum added missing semicolon as per ReviewBot's recommendation
mderose123

Description From Last Updated

I think, personally, this UI fits in really nicely with Review Board's pre-existing metaphors. Great job! A few notes: We ...

mike_conleymike_conley

Col: 76 Missing semicolon.

reviewbotreviewbot

Col: 97 Missing semicolon.

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

mderose
mderose
mderose
mderose
mderose
Review request changed

Testing Done:

  +

Manual testing has been done to ensure that the background color of the image review page can change to white, black, grey/black checkerboard, or a custom colour for all image views.

Commits:

Summary Author
-
Background Color Selector When Viewing Images
mderose123
-
Added fixed HSHint raised
mderose123
-
Developed event handlers for changing the background color
mderose123
+
Background Color Selector When Viewing Images
mderose123
+
Added fixed HSHint raised
mderose123
+
Developed event handlers for changing the background color
mderose123
+
Implemented the functionality to change the background color selector for the image review window for all image views. Currently the user is able to choose a white, black, black/grey checkerboard, or a custom color as a background for an image
mderose123

Diff:

Revision 3 (+348 -58)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 passed.
JSHint failed.

JSHint

mderose
mderose
mderose
Review request changed

Added Files:

mike_conley
  1. 
      
  2. I think, personally, this UI fits in really nicely with Review Board's pre-existing metaphors. Great job!

    A few notes:

    1. We probably still want the filename in the center of this, rather than pushed to the right.
    2. The labels should be vertical-center aligned
    3. Either both should end with : or not.
    4. We probably want a little extra space between "Custom" and the image on its left - maybe the same amount of distance between the background color selectors.
  3. 
      
Loading...