Summary

Add new rbext options for specifying app labels and extensions.

Review Request #11428 — Created Feb. 3, 2021 and submitted Feb. 9, 2021, 4:51 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

rbext historically required a -m parameter to specify modules in the

extension to test, but this wasn't always sufficient. Module names were

just passed to nosetests, and didn't impact the list of installed

apps, meaning that referenced models would fail to import.
To address this, and to simplify usage, there are two new options:


-e/--extension takes a full class path, importing it to find the

  list of installed apps, which will be added to Django. This doesn't

  currently support extension dependencies, but it's not clear that

  anyone has ever used this feature anyway.


--app can be specified multiple times. It takes an app label that

  gets added to Django.


This massively simplifies the ease of use of rbext, and removes almost

all need for a custom settings_local.py file.

Testing Done

Tested rbext test with the rbintegrations and Power Pack codebases,
utilizing both -e and --app. All tests passed without the need for a
custom settings_local.py.

Commits

Summary	ID
Add new rbext options for specifying app labels and extensions. `rbext` historically required a `-m` parameter to specify modules in the extension to test, but this wasn't always sufficient. Module names were just passed to `nosetests`, and didn't impact the list of installed apps, meaning that referenced models would fail to import. To address this, and to simplify usage, there are two new options: * `-e`/`--extension` takes a full class path, importing it to find the list of installed apps, which will be added to Django. This doesn't currently support extension dependencies, but it's not clear that anyone has ever used this feature anyway. * `--app` can be specified multiple times. It takes an app label that gets added to Django. This massively simplifies the ease of use of `rbext`, and removes almost all need for a custom `settings_local.py` file.	750261fbbef1149b82b6e52f59bcb467d313bcb3

Summary

Add new rbext options for specifying app labels and extensions.

`rbext` historically required a `-m` parameter to specify modules in the extension to test, but this wasn't always sufficient. Module names were just passed to `nosetests`, and didn't impact the list of installed apps, meaning that referenced models would fail to import. To address this, and to simplify usage, there are two new options: * `-e`/`--extension` takes a full class path, importing it to find the list of installed apps, which will be added to Django. This doesn't currently support extension dependencies, but it's not clear that anyone has ever used this feature anyway. * `--app` can be specified multiple times. It takes an app label that gets added to Django. This massively simplifies the ease of use of `rbext`, and removes almost all need for a custom `settings_local.py` file.

750261fbbef1149b82b6e52f59bcb467d313bcb3

Issues

Description	From	Last Updated
This reads a little weird, and I think suggesting the long option would be more self-explanatory. Maybe "You may want …	david	Feb. 8, 2021, 6:32 p.m.

flake8 passed.

JSHint passed.

reviewboard/cmdline/rbext.py (Diff revision 1)

The issue has been resolved. Show all issues

This reads a little weird, and I think suggesting the long option would be more self-explanatory. Maybe "You may want to use --extension instead"?

Change Summary:

Improved the wording of the --extension recommendation in --module.

Commits:

	Summary	ID
	Add new rbext options for specifying app labels and extensions. `rbext` historically required a `-m` parameter to specify modules in the extension to test, but this wasn't always sufficient. Module names were just passed to `nosetests`, and didn't impact the list of installed apps, meaning that referenced models would fail to import. To address this, and to simplify usage, there are two new options: * `-e`/`--extension` takes a full class path, importing it to find the list of installed apps, which will be added to Django. This doesn't currently support extension dependencies, but it's not clear that anyone has ever used this feature anyway. * `--app` can be specified multiple times. It takes an app label that gets added to Django. This massively simplifies the ease of use of `rbext`, and removes almost all need for a custom `settings_local.py` file.	69dca450b2c87faf56324827add57334905fddb2
	Add new rbext options for specifying app labels and extensions. `rbext` historically required a `-m` parameter to specify modules in the extension to test, but this wasn't always sufficient. Module names were just passed to `nosetests`, and didn't impact the list of installed apps, meaning that referenced models would fail to import. To address this, and to simplify usage, there are two new options: * `-e`/`--extension` takes a full class path, importing it to find the list of installed apps, which will be added to Django. This doesn't currently support extension dependencies, but it's not clear that anyone has ever used this feature anyway. * `--app` can be specified multiple times. It takes an app label that gets added to Django. This massively simplifies the ease of use of `rbext`, and removes almost all need for a custom `settings_local.py` file.	750261fbbef1149b82b6e52f59bcb467d313bcb3

Diff:

Revision 2 (+110 -10)

Show changes

reviewboard/cmdline/rbext.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to master (257a233)