flake8
-
reviewboard/cmdline/rbext.py (Diff revision 1) -
-
reviewboard/cmdline/rbext.py (Diff revision 1) F401 'reviewboard.cmdline.utils.argparsing.RBProgVersionAction' imported but unused
Review Request #11426 — Created Feb. 2, 2021 and submitted
This change makes a few improvements to
rbext
to modernize command
line parsing, help output, and console output.
rbext --help
and each subcommand's--help
now provides more useful
instructions, with links to useful URLs where appropriate. They're
formatted by the newHelpFormatter
split off fromrb-site
.
rbext --version
now works, showing the Review Board version, Python
version, and Review Board install path.
rbext test
has new native support for-x
,--pdb
, and
--with-coverage
options, and explicit documentation on how to make use
ofnosetests
options.Console output uses the new
Console
object, which doesn't do a whole
lot in our case, but does allow us to standardize things.Variables for manual URLs were also standardized.
Checked
rbext --help
,rbext create --help
, andrbext test --help
and verified the output was formatted correctly.Ran
rbext create
and verified all the generated files were correct,
including URLs.Ran
rbext test
with the new options and verified that they impacted
the tests I ran.
Summary | ID |
---|---|
b03ce0d7ada0070170ab2552303c0de4e8780e99 |
Description | From | Last Updated |
---|---|---|
E402 module level import not at top of file |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
F401 'reviewboard.cmdline.utils.argparsing.RBProgVersionAction' imported but unused |
reviewbot | |
F401 'subprocess' imported but unused |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
F401 'reviewboard.cmdline.utils.argparsing.RBProgVersionAction' imported but unused |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
E402 module level import not at top of file |
reviewbot |
reviewboard/cmdline/rbext.py (Diff revision 1) |
---|
reviewboard/cmdline/rbext.py (Diff revision 1) |
---|
F401 'reviewboard.cmdline.utils.argparsing.RBProgVersionAction' imported but unused
--version
support missing from the commit.Description: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commits: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||
Diff: |
Revision 2 (+212 -60) |
reviewboard/cmdline/rbext.py (Diff revision 2) |
---|
F401 'reviewboard.cmdline.utils.argparsing.RBProgVersionAction' imported but unused
Prematurely published before posting the full revised change.
Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+216 -60) |
-m
.test_args
when not using any flags.Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 4 (+236 -62) |
rbext test
without -m
RBTestRunner
.Commits: |
|
|||||||
---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+230 -60) |