Modernize and improve options for rbext.

Review Request #11426 — Created Feb. 2, 2021 and submitted

Information

Review Board
release-4.0.x

Reviewers

This change makes a few improvements to rbext to modernize command
line parsing, help output, and console output.

rbext --help and each subcommand's --help now provides more useful
instructions, with links to useful URLs where appropriate. They're
formatted by the new HelpFormatter split off from rb-site.

rbext --version now works, showing the Review Board version, Python
version, and Review Board install path.

rbext test has new native support for -x, --pdb, and
--with-coverage options, and explicit documentation on how to make use
of nosetests options.

Console output uses the new Console object, which doesn't do a whole
lot in our case, but does allow us to standardize things.

Variables for manual URLs were also standardized.

Checked rbext --help, rbext create --help, and rbext test --help
and verified the output was formatted correctly.

Ran rbext create and verified all the generated files were correct,
including URLs.

Ran rbext test with the new options and verified that they impacted
the tests I ran.

Summary ID
Modernize and improve options for rbext.
This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.
b03ce0d7ada0070170ab2552303c0de4e8780e99
Description From Last Updated

E402 module level import not at top of file

reviewbotreviewbot

E402 module level import not at top of file

reviewbotreviewbot

F401 'reviewboard.cmdline.utils.argparsing.RBProgVersionAction' imported but unused

reviewbotreviewbot

F401 'subprocess' imported but unused

reviewbotreviewbot

E402 module level import not at top of file

reviewbotreviewbot

F401 'reviewboard.cmdline.utils.argparsing.RBProgVersionAction' imported but unused

reviewbotreviewbot

E402 module level import not at top of file

reviewbotreviewbot

E402 module level import not at top of file

reviewbotreviewbot

E402 module level import not at top of file

reviewbotreviewbot

E402 module level import not at top of file

reviewbotreviewbot

E402 module level import not at top of file

reviewbotreviewbot

E402 module level import not at top of file

reviewbotreviewbot

E402 module level import not at top of file

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
Review request changed
Change Summary:
  • Added the --version support missing from the commit.
  • Fixed an import order.
Description:
   

This change makes a few improvements to rbext to modernize command

    line parsing, help output, and console output.

   
   

rbext --help and each subcommand's --help now provides more useful

    instructions, with links to useful URLs where appropriate. They're
    formatted by the new HelpFormatter split off from rb-site.

   
  +

rbext --version now works, showing the Review Board version, Python

  + version, and Review Board install path.

  +
   

rbext test has new native support for -x, --pdb, and

    --with-coverage options, and explicit documentation on how to make use
    of nosetests options.

   
   

Console output uses the new Console object, which doesn't do a whole

    lot in our case, but does allow us to standardize things.

   
   

Variables for manual URLs were also standardized.

Commits:
Summary ID
Modernize and improve options for rbext.
This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.
58a1d238ac2447caea3b45de8a4cc44e5e552d16
Modernize and improve options for rbext.
This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.
cbd890cf33aea7c9df306d5f1358cebc4abb968c

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

chipx86
Review request changed
Change Summary:

Prematurely published before posting the full revised change.

Commits:
Summary ID
Modernize and improve options for rbext.
This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.
cbd890cf33aea7c9df306d5f1358cebc4abb968c
Modernize and improve options for rbext.
This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.
6edb7f19136ff748cc825e42311be8f384d2d26c

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

chipx86
Review request changed
Change Summary:
  • Added better help output for -m.
  • Fixed test_args when not using any flags.
Commits:
Summary ID
Modernize and improve options for rbext.
This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.
6edb7f19136ff748cc825e42311be8f384d2d26c
Modernize and improve options for rbext.
This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.
8833bf78affade5df66d7a2f24a1253553512e21

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

chipx86
Review request changed
Change Summary:
  • Fixed a crash when using rbext test without -m
  • Corrected the way we're supposed to pass nose options to RBTestRunner.
Commits:
Summary ID
Modernize and improve options for rbext.
This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.
8833bf78affade5df66d7a2f24a1253553512e21
Modernize and improve options for rbext.
This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.
b03ce0d7ada0070170ab2552303c0de4e8780e99

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

david
  1. Ship It!
  2. 
      
chipx86
Review request changed
Status:
Completed
Change Summary:
Pushed to release-4.0.x (c81f674)