Modernize and improve options for rbext.
Review Request #11426 — Created Feb. 2, 2021 and submitted
This change makes a few improvements to
rbext
to modernize command
line parsing, help output, and console output.
rbext --help
and each subcommand's--help
now provides more useful
instructions, with links to useful URLs where appropriate. They're
formatted by the newHelpFormatter
split off fromrb-site
.
rbext --version
now works, showing the Review Board version, Python
version, and Review Board install path.
rbext test
has new native support for-x
,--pdb
, and
--with-coverage
options, and explicit documentation on how to make use
ofnosetests
options.Console output uses the new
Console
object, which doesn't do a whole
lot in our case, but does allow us to standardize things.Variables for manual URLs were also standardized.
Checked
rbext --help
,rbext create --help
, andrbext test --help
and verified the output was formatted correctly.Ran
rbext create
and verified all the generated files were correct,
including URLs.Ran
rbext test
with the new options and verified that they impacted
the tests I ran.
Summary | ID |
---|---|
b03ce0d7ada0070170ab2552303c0de4e8780e99 |
Description | From | Last Updated |
---|---|---|
E402 module level import not at top of file |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
F401 'reviewboard.cmdline.utils.argparsing.RBProgVersionAction' imported but unused |
reviewbot | |
F401 'subprocess' imported but unused |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
F401 'reviewboard.cmdline.utils.argparsing.RBProgVersionAction' imported but unused |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
E402 module level import not at top of file |
reviewbot | |
E402 module level import not at top of file |
reviewbot |
- Change Summary:
-
- Added the
--version
support missing from the commit. - Fixed an import order.
- Added the
- Description:
-
This change makes a few improvements to
rbext
to modernize commandline parsing, help output, and console output. rbext --help
and each subcommand's--help
now provides more usefulinstructions, with links to useful URLs where appropriate. They're formatted by the new HelpFormatter
split off fromrb-site
.+ rbext --version
now works, showing the Review Board version, Python+ version, and Review Board install path. + rbext test
has new native support for-x
,--pdb
, and--with-coverage
options, and explicit documentation on how to make useof nosetests
options.Console output uses the new
Console
object, which doesn't do a wholelot in our case, but does allow us to standardize things. Variables for manual URLs were also standardized.
- Commits:
-
Summary ID 58a1d238ac2447caea3b45de8a4cc44e5e552d16 cbd890cf33aea7c9df306d5f1358cebc4abb968c - Diff:
-
Revision 2 (+212 -60)
- Change Summary:
-
Prematurely published before posting the full revised change.
- Commits:
-
Summary ID cbd890cf33aea7c9df306d5f1358cebc4abb968c 6edb7f19136ff748cc825e42311be8f384d2d26c - Diff:
-
Revision 3 (+216 -60)
- Change Summary:
-
- Added better help output for
-m
. - Fixed
test_args
when not using any flags.
- Added better help output for
- Commits:
-
Summary ID 6edb7f19136ff748cc825e42311be8f384d2d26c 8833bf78affade5df66d7a2f24a1253553512e21 - Diff:
-
Revision 4 (+236 -62)
- Change Summary:
-
- Fixed a crash when using
rbext test
without-m
- Corrected the way we're supposed to pass nose options to
RBTestRunner
.
- Fixed a crash when using
- Commits:
-
Summary ID 8833bf78affade5df66d7a2f24a1253553512e21 b03ce0d7ada0070170ab2552303c0de4e8780e99 - Diff:
-
Revision 5 (+230 -60)