Summary

Modernize and improve options for rbext.

Review Request #11426 — Created Feb. 2, 2021 and submitted Feb. 8, 2021, 6:32 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This change makes a few improvements to rbext to modernize command
line parsing, help output, and console output.

rbext --help and each subcommand's --help now provides more useful
instructions, with links to useful URLs where appropriate. They're
formatted by the new HelpFormatter split off from rb-site.

rbext --version now works, showing the Review Board version, Python
version, and Review Board install path.

rbext test has new native support for -x, --pdb, and
--with-coverage options, and explicit documentation on how to make use
of nosetests options.

Console output uses the new Console object, which doesn't do a whole
lot in our case, but does allow us to standardize things.

Variables for manual URLs were also standardized.

Testing Done

Checked rbext --help, rbext create --help, and rbext test --help
and verified the output was formatted correctly.

Ran rbext create and verified all the generated files were correct,
including URLs.

Ran rbext test with the new options and verified that they impacted
the tests I ran.

Commits

Summary	ID
Modernize and improve options for rbext. This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.	b03ce0d7ada0070170ab2552303c0de4e8780e99

Summary

Modernize and improve options for rbext.

This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.

b03ce0d7ada0070170ab2552303c0de4e8780e99

Issues

Description	From	Last Updated
E402 module level import not at top of file	reviewbot	Feb. 2, 2021, 5:49 p.m.
E402 module level import not at top of file	reviewbot	Feb. 2, 2021, 5:49 p.m.
F401 'reviewboard.cmdline.utils.argparsing.RBProgVersionAction' imported but unused	reviewbot	Feb. 2, 2021, 5:49 p.m.
F401 'subprocess' imported but unused	reviewbot	Feb. 2, 2021, 5:50 p.m.
E402 module level import not at top of file	reviewbot	Feb. 2, 2021, 5:50 p.m.
F401 'reviewboard.cmdline.utils.argparsing.RBProgVersionAction' imported but unused	reviewbot	Feb. 2, 2021, 5:50 p.m.
E402 module level import not at top of file	reviewbot	Feb. 2, 2021, 5:50 p.m.
E402 module level import not at top of file	reviewbot	Feb. 2, 2021, 5:51 p.m.
E402 module level import not at top of file	reviewbot	Feb. 2, 2021, 5:51 p.m.
E402 module level import not at top of file	reviewbot	Feb. 2, 2021, 11:22 p.m.
E402 module level import not at top of file	reviewbot	Feb. 2, 2021, 11:22 p.m.
E402 module level import not at top of file	reviewbot	Feb. 3, 2021, 12:05 a.m.
E402 module level import not at top of file	reviewbot	Feb. 3, 2021, 12:05 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/cmdline/rbext.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```
reviewboard/cmdline/rbext.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```

reviewboard/cmdline/rbext.py (Diff revision 1)

The issue has been resolved. Show all issues

F401 'reviewboard.cmdline.utils.argparsing.RBProgVersionAction' imported but unused

Change Summary:


Added the --version support missing from the commit.
Fixed an import order.

Description:

		This change makes a few improvements to `rbext` to modernize command
		line parsing, help output, and console output.

		`rbext --help` and each subcommand's `--help` now provides more useful
		instructions, with links to useful URLs where appropriate. They're
		formatted by the new `HelpFormatter` split off from `rb-site`.

	+	`rbext --version` now works, showing the Review Board version, Python
	+	version, and Review Board install path.
	+
		`rbext test` has new native support for `-x`, `--pdb`, and
		`--with-coverage` options, and explicit documentation on how to make use
		of `nosetests` options.

		Console output uses the new `Console` object, which doesn't do a whole
		lot in our case, but does allow us to standardize things.

		Variables for manual URLs were also standardized.

Commits:

	Summary	ID
	Modernize and improve options for rbext. This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.	58a1d238ac2447caea3b45de8a4cc44e5e552d16
	Modernize and improve options for rbext. This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.	cbd890cf33aea7c9df306d5f1358cebc4abb968c

Diff:

Revision 2 (+212 -60)

Show changes

reviewboard/cmdline/rbext.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/cmdline/rbext.py (Diff revision 2)
The issue has been resolved. Show all issues
```
F401 'subprocess' imported but unused
```
reviewboard/cmdline/rbext.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```

reviewboard/cmdline/rbext.py (Diff revision 2)

The issue has been resolved. Show all issues

F401 'reviewboard.cmdline.utils.argparsing.RBProgVersionAction' imported but unused

reviewboard/cmdline/rbext.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```

Change Summary:

Prematurely published before posting the full revised change.

Commits:

	Summary	ID
	Modernize and improve options for rbext. This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.	cbd890cf33aea7c9df306d5f1358cebc4abb968c
	Modernize and improve options for rbext. This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.	6edb7f19136ff748cc825e42311be8f384d2d26c

Diff:

Revision 3 (+216 -60)

Show changes

reviewboard/cmdline/rbext.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/cmdline/rbext.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```
reviewboard/cmdline/rbext.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```

Change Summary:


Added better help output for -m.
Fixed test_args when not using any flags.

Commits:

	Summary	ID
	Modernize and improve options for rbext. This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.	6edb7f19136ff748cc825e42311be8f384d2d26c
	Modernize and improve options for rbext. This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.	8833bf78affade5df66d7a2f24a1253553512e21

Diff:

Revision 4 (+236 -62)

Show changes

reviewboard/cmdline/rbext.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/cmdline/rbext.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```
reviewboard/cmdline/rbext.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```

Change Summary:


Fixed a crash when using rbext test without -m
Corrected the way we're supposed to pass nose options to RBTestRunner.

Commits:

	Summary	ID
	Modernize and improve options for rbext. This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.	8833bf78affade5df66d7a2f24a1253553512e21
	Modernize and improve options for rbext. This change makes a few improvements to `rbext` to modernize command line parsing, help output, and console output. `rbext --help` and each subcommand's `--help` now provides more useful instructions, with links to useful URLs where appropriate. They're formatted by the new `HelpFormatter` split off from `rb-site`. `rbext test` has new native support for `-x`, `--pdb`, and `--with-coverage` options, and explicit documentation on how to make use of `nosetests` options. Console output uses the new `Console` object, which doesn't do a whole lot in our case, but does allow us to standardize things.	b03ce0d7ada0070170ab2552303c0de4e8780e99

Diff:

Revision 5 (+230 -60)

Show changes

reviewboard/cmdline/rbext.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/cmdline/rbext.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```
reviewboard/cmdline/rbext.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E402 module level import not at top of file
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (c81f674)