Guarded against an inactive user being set as a reviewer or owner of a review request

 






 

 


  Review Request #11422
  —
  Created Jan. 30, 2021 and updated  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  mderose
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  4896
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard, students
 









 
 

  
 






 








 





  


 
 

  
A change that prevents an inactive user to be assigned as a submitter or reviewer for a

unpublished review request. In addition to this, this change will prevent

a review request draft from being published if the submitter or reviewer(s) are inactive.

 








  


 
 

  
I've manually validated in the UI for draft review request that an error appears if a user 

tries to update the owner/submitter or target people (reviewers) field with an innactive 

user 


-I've created unit tests for when a review request draft is published for the following 

cases

1. A review request draft is published with an inactive reviewer 

2. A review request draft is published with an inactive owner/submitter 

3. A review request draft is published with multiple reviewers, one of which is inactive


-I've also created additional unit tests regarrding when a review request draft is updated 

using a PUT request

5. A PUT API call is made to update a review request draft with an inactive user set as the 

owner/submitter of the review request

7. A PUT API call is made to update a review request draft with an inactive user set as one 

8. of the reviewers of the review request

 







 









 





  








 




 







   

    
    
Changes between revision 7 and 8



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Guarded against an inactive user or owner from being assigned to a review.
     
A change that prevents an inactive user to be assigned as a submitter or reviewer for a
published or unpublished review request. In addition to this, this change will prevent
a review request draft from being published if the submitter or reviewer(s) are inactive.

    

   
  		
  47a726d9344045966731e7d789ab5b469f96f547
  mderose123
 


 
  
 
 
  
   
    
Addendum Made code fixes based on flake8 code styling recommendations

   
  		
  55390df0128c8883c6c936d662c191ad1ed72763
  mderose123
 


 
  
 
 
  
   
    
Addendum Fixed Further Flake8 Code Styling Issues

   
  		
  dfa0445c86ed412ac9e12bdbccf6a2fe0e8ddb59
  mderose123
 


 
  
 
 
  
   
    
Addendum Fixed Flake8 Issues Again

   
  		
  b2694e1d558f70d333d36587503859fa326e2821
  mderose123
 


 
  
 
 
  
   
    

     Added tests for handling put requests
     
with for updating submitter or target people with inactive users

    

   
  		
  07d9184b8ef78a6569c5bce98844af2355dc3d6f
  mderose123
 


 
  
 
 
  
   
    
Addendum removed whitespace as recommended by flake8

   
  		
  3c55086ca8fbbf3b32c51afc75ac97ad5bd9bd16
  mderose123
 


 
  
 
 
  
   
    
Addendum fixed flake8 code styling issues

   
  		
  e01be77030ddb4f5fe19e5b6db1cf67c9e58be87
  mderose123
 


 
  
 
 
  
   
    
Addendum added changes as perDavid's recommendations

   
  		
  f3bfde108fe01cc5a0dbca39e94428da686c172b
  mderose123
 


 
  
 
 
  
   
    

     Guarded against an inactive user or owner from being assigned to a review.
     
A change that prevents an inactive user to be assigned as a submitter or reviewer for a
published or unpublished review request. In addition to this, this change will prevent
a review request draft from being published if the submitter or reviewer(s) are inactive.

    

   
  		
  77e175ff12c5c098ec93c8558d6dae2727f06eb6
  mderose123
 


 
  
 
 
  
   
    
Addendum Made code fixes based on flake8 code styling recommendations

   
  		
  89d6d608750c529824fc00cce880cf77cbe7ff6d
  mderose123
 


 
  
 
 
  
   
    
Addendum Fixed Further Flake8 Code Styling Issues

   
  		
  634e91d9a34c6939dfcbf2bf5c358be12b10067c
  mderose123
 


 
  
 
 
  
   
    
Addendum Fixed Flake8 Issues Again

   
  		
  92d0dbb9c1deccdeb6a758b27e377048658e6509
  mderose123
 


 
  
 
 
  
   
    

     Added tests for handling put requests
     
with for updating submitter or target people with inactive users

    

   
  		
  6511fc0ef5068540042210a266bdfe6cdd28859d
  mderose123
 


 
  
 
 
  
   
    
Addendum removed whitespace as recommended by flake8

   
  		
  422334836d31a49b09658c3b4151cdb89960e428
  mderose123
 


 
  
 
 
  
   
    
Addendum fixed flake8 code styling issues

   
  		
  1aca18a7075644c9043ae48365e7e720031f2c08
  mderose123
 


 
  
 
 
  
   
    
Addendum added changes as perDavid's recommendations

   
  		
  60348fa225a045f5c33d56ff5ada4c303702af85
  mderose123
 


 
  
 
 
  
   
    
Addendum made changes based off of flake8 recommendations

   
  		
  ec40c4934a492758547a73cf9c8bf8c18c765203
  mderose123
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/accounts/backends/ad.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/accounts/backends/ldap.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/accounts/tests/test_ad_auth_backend.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/accounts/tests/test_ldap_auth_backend.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/review_request_draft.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/tests/test_review_request_draft.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/newReviewRequest/views/commitView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/dialogView.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/ui/views/tests/dialogViewTests.es6.js
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/review_request.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...