Summary

Improve the content of rb-site's instructions and other strings.

Review Request #11414 — Created Jan. 28, 2021 and submitted Feb. 8, 2021, 6:30 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

~~11413~~

Reviewers

Groups

reviewboard

People

Description

Much of the guidance in rb-site is old, and hasn't been updated in a

long time. Some of the information was slightly out-of-date, or didn't

provide much help in choosing ideal options.
This change improves some of those strings. Namely:


Fixing up some naming/wording (e.g., "memcache" -> "memcached", and

  or "shipped media" -> "shipped static media").


Adding recommendations for web servers and  database/memcached

  locations.


Better explaining the reasons you'd change the static or media URLs,

  for anyone running with --advanced.


Switching from "http" to "https" in examples.


Further preparing some strings for the upcoming port to Console.

Testing Done

Ran through rb-site install --advanced and rb-site upgrade and read
through the new text.

Commits

Summary	ID
Improve the content of rb-site's instructions and other strings. Much of the guidance in `rb-site` is old, and hasn't been updated in a long time. Some of the information was slightly out-of-date, or didn't provide much help in choosing ideal options. This change improves some of those strings. Namely: * Fixing up some naming/wording (e.g., "memcache" -> "memcached", and or "shipped media" -> "shipped static media"). * Adding recommendations for web servers and database/memcached locations. * Better explaining the reasons you'd change the static or media URLs, for anyone running with `--advanced`. * Switching from "http" to "https" in examples. * Further preparing some strings for the upcoming port to `Console`.	0c0971fbf2aa2d2003d1f8c12105aa5750bfa925

Summary

Improve the content of rb-site's instructions and other strings.

Much of the guidance in `rb-site` is old, and hasn't been updated in a long time. Some of the information was slightly out-of-date, or didn't provide much help in choosing ideal options. This change improves some of those strings. Namely: * Fixing up some naming/wording (e.g., "memcache" -> "memcached", and or "shipped media" -> "shipped static media"). * Adding recommendations for web servers and database/memcached locations. * Better explaining the reasons you'd change the static or media URLs, for anyone running with `--advanced`. * Switching from "http" to "https" in examples. * Further preparing some strings for the upcoming port to `Console`.

0c0971fbf2aa2d2003d1f8c12105aa5750bfa925

Issues

Description	From	Last Updated
Shouldn't this be manage.py createdb?	david	Jan. 28, 2021, 10:42 p.m.

flake8 passed.

JSHint passed.

Change Summary:

Improved the recommendation text for databases.

Commits:

	Summary	ID
	Improve the content of rb-site's instructions and other strings. Much of the guidance in `rb-site` is old, and hasn't been updated in a long time. Some of the information was slightly out-of-date, or didn't provide much help in choosing ideal options. This change improves some of those strings. Namely: * Fixing up some naming/wording (e.g., "memcache" -> "memcached", and or "shipped media" -> "shipped static media"). * Adding recommendations for web servers and database/memcached locations. * Better explaining the reasons you'd change the static or media URLs, for anyone running with `--advanced`. * Switching from "http" to "https" in examples. * Further preparing some strings for the upcoming port to `Console`.	7ad3a56c0dea26654b394e938a83c81db4257cef
	Improve the content of rb-site's instructions and other strings. Much of the guidance in `rb-site` is old, and hasn't been updated in a long time. Some of the information was slightly out-of-date, or didn't provide much help in choosing ideal options. This change improves some of those strings. Namely: * Fixing up some naming/wording (e.g., "memcache" -> "memcached", and or "shipped media" -> "shipped static media"). * Adding recommendations for web servers and database/memcached locations. * Better explaining the reasons you'd change the static or media URLs, for anyone running with `--advanced`. * Switching from "http" to "https" in examples. * Further preparing some strings for the upcoming port to `Console`.	273bd59bef2e0bc6df1d34c678380b2d99e3dfa7

Diff:

Revision 2 (+142 -72)

Show changes

	contrib/internal/prepare-dev.py
	reviewboard/cmdline/rbsite.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

contrib/internal/prepare-dev.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Shouldn't this be manage.py createdb?
```
1. chipx86 Jan. 28, 2021, 9:35 p.m.
  Oh, yep.

Change Summary:

Switched text to reference createdb for creating a database.

Commits:

	Summary	ID
	Improve the content of rb-site's instructions and other strings. Much of the guidance in `rb-site` is old, and hasn't been updated in a long time. Some of the information was slightly out-of-date, or didn't provide much help in choosing ideal options. This change improves some of those strings. Namely: * Fixing up some naming/wording (e.g., "memcache" -> "memcached", and or "shipped media" -> "shipped static media"). * Adding recommendations for web servers and database/memcached locations. * Better explaining the reasons you'd change the static or media URLs, for anyone running with `--advanced`. * Switching from "http" to "https" in examples. * Further preparing some strings for the upcoming port to `Console`.	273bd59bef2e0bc6df1d34c678380b2d99e3dfa7
	Improve the content of rb-site's instructions and other strings. Much of the guidance in `rb-site` is old, and hasn't been updated in a long time. Some of the information was slightly out-of-date, or didn't provide much help in choosing ideal options. This change improves some of those strings. Namely: * Fixing up some naming/wording (e.g., "memcache" -> "memcached", and or "shipped media" -> "shipped static media"). * Adding recommendations for web servers and database/memcached locations. * Better explaining the reasons you'd change the static or media URLs, for anyone running with `--advanced`. * Switching from "http" to "https" in examples. * Further preparing some strings for the upcoming port to `Console`.	0c0971fbf2aa2d2003d1f8c12105aa5750bfa925

Diff:

Revision 3 (+142 -72)

Show changes

	contrib/internal/prepare-dev.py
	reviewboard/cmdline/rbsite.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (ddcc8c1)