chipx86 got a fish trophy!
Switch rb-site and prepare-dev.py to the new Console interface.
Review Request #11411 — Created Jan. 28, 2021 and submitted — Latest diff uploaded
This is a cleanup of the
rb-site
andprepare-dev.py
code, moving
away from the page and callback-basedConsoleUI
code we've used for
years and to the new, more generalConsole
code.For the most part, the presentation remains the same, with a few
differences:
-
The text is no longer indented 2 spaces in the UI, creating a more
consistent look with other commands. -
Some of the sections were given better/updated instructions.
-
Upgrade code now uses sections and progress steps for the operations,
improving the presentation.
Unit tests pass.
Made a note of every single string in
rb-site
andprepare-dev.py
(by addingXXX TEST
comments). Walked through every variation of
both scripts, checking each set of strings and marking it off the list.
This included optional steps and errors. Verified every string looked
the way I expected it to, and executed properly.