Fish Trophy

chipx86 got a fish trophy!

Switch rb-site and prepare-dev.py to the new Console interface.

Review Request #11411 — Created Jan. 28, 2021 and submitted

Information

Review Board
release-4.0.x

Reviewers

This is a cleanup of the rb-site and prepare-dev.py code, moving
away from the page and callback-based ConsoleUI code we've used for
years and to the new, more general Console code.

For the most part, the presentation remains the same, with a few
differences:

  • The text is no longer indented 2 spaces in the UI, creating a more
    consistent look with other commands.

  • Some of the sections were given better/updated instructions.

  • Upgrade code now uses sections and progress steps for the operations,
    improving the presentation.

Unit tests pass.

Made a note of every single string in rb-site and prepare-dev.py
(by adding XXX TEST comments). Walked through every variation of
both scripts, checking each set of strings and marking it off the list.
This included optional steps and errors. Verified every string looked
the way I expected it to, and executed properly.

Summary ID
Switch rb-site and prepare-dev.py to the new Console interface.
This is a cleanup of the `rb-site` and `prepare-dev.py` code, moving away from the page and callback-based `ConsoleUI` code we've used for years and to the new, more general `Console` code. For the most part, the presentation remains the same, with a few differences: * The text is no longer indented 2 spaces in the UI, creating a more consistent look with other commands. * Some of the sections were given better/updated instructions. * Upgrade code now uses sections and progress steps for the operations, improving the presentation.
247ba42ea5a7c8dbd9af02eccce7b4e4358c4b64
chipx86
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (17a87db)
Loading...