flake8
passed.
JSHint
passed.
Replace all non-named logging within the cmdline module to use named logging
Review Request #11400 — Created Jan. 23, 2021 and updated
Replaced all non-named usages within the cmdline module to use named logging. This is done to implement the automatic inclusion of information about the module where the logging message came from, to help with diagnosing problems from logs.
Based off of ticket 4902 on Splat.
Ran "./tests/runtests.py reviewboard.cmdline.tests"
| Summary | ID |
|---|---|
| 304322df6e8c00fb1492d37d612f29ff226c5d98 |
| Description | From | Last Updated |
|---|---|---|
|
Please wrap your description to 80 columns. |
 david
|
|
|
Instead of putting the bug number into the description, add it to the "Bugs" field. |
david
|
|
|
Let's move this to happen after all of the imports. There should also be two blank lines above and below … |
david
|
|
|
These two lines need to be dedented one space, since "logger" is one character shorter than "logging" |
david
|
|
|
Please move to happen after all imports, add two blank lines around. |
david
|
|
|
Dedent one space. |
david
|
|
|
Dedent one space. |
david
|
-
-
-
-
reviewboard/cmdline/rbext.py (Diff revision 1) Let's move this to happen after all of the imports. There should also be two blank lines above and below it.
-
reviewboard/cmdline/rbext.py (Diff revision 1) These two lines need to be dedented one space, since "logger" is one character shorter than "logging"
-
reviewboard/cmdline/rbssh.py (Diff revision 1) Please move to happen after all imports, add two blank lines around.
-
-