Replace all non-named logging within the cmdline module to use named logging

Review Request #11400 — Created Jan. 23, 2021 and updated

Information

Review Board
release-4.0.x

Reviewers

Replaced all non-named usages within the cmdline module to use named logging. This is done to implement the automatic inclusion of information about the module where the logging message came from, to help with diagnosing problems from logs.

Based off of ticket 4902 on Splat.

Ran "./tests/runtests.py reviewboard.cmdline.tests"

Summary ID
Replaced all non-named usages within the cmdline module to use named logging
304322df6e8c00fb1492d37d612f29ff226c5d98
Description From Last Updated

Please wrap your description to 80 columns.

daviddavid

Instead of putting the bug number into the description, add it to the "Bugs" field.

daviddavid

Let's move this to happen after all of the imports. There should also be two blank lines above and below …

daviddavid

These two lines need to be dedented one space, since "logger" is one character shorter than "logging"

daviddavid

Please move to happen after all imports, add two blank lines around.

daviddavid

Dedent one space.

daviddavid

Dedent one space.

daviddavid
Checks run (2 succeeded)
flake8 passed.
JSHint passed.
david
  1. 
      
  2. Show all issues

    Please wrap your description to 80 columns.

  3. Show all issues

    Instead of putting the bug number into the description, add it to the "Bugs" field.

  4. reviewboard/cmdline/rbext.py (Diff revision 1)
     
     
     
    Show all issues

    Let's move this to happen after all of the imports. There should also be two blank lines above and below it.

  5. reviewboard/cmdline/rbext.py (Diff revision 1)
     
     
     
    Show all issues

    These two lines need to be dedented one space, since "logger" is one character shorter than "logging"

  6. reviewboard/cmdline/rbssh.py (Diff revision 1)
     
     
     
    Show all issues

    Please move to happen after all imports, add two blank lines around.

  7. reviewboard/cmdline/rbssh.py (Diff revision 1)
     
     
    Show all issues

    Dedent one space.

  8. reviewboard/cmdline/rbssh.py (Diff revision 1)
     
     
    Show all issues

    Dedent one space.

  9.