Summary

Add named logging in the extensions module.

Review Request #11398 — Created Jan. 22, 2021 and submitted Feb. 7, 2021, 2:41 p.m.

Information

Owner

mfliu

Repository

Review Board

Branch

release-4.0.x

Bugs

4904

Depends On

Reviewers

Groups

reviewboard, students

People

Description

The old global logging commands such as logging.error and
logging.info do not insert information about where the log message
came from. By instantiating a module-level logger object, log messages
will now include information about the source module.

Testing Done

Ran all reviewboard.extensions.tests unit tests.

Commits

Summary	ID
Add named logging in the extensions module. The old global logging commands such as `logging.error` and `logging.info` do not insert information about where the log message came from. By instantiating a module-level `logger` object, log messages will now include information about the source module.	3b57ee53f5eb83969190d1e1e4dede901b081e40

Issues

Description	From	Last Updated
Can you add the bug number to the "bugs" field?	david	Jan. 23, 2021, 9:01 a.m.
Super tiny nit: please add a period at the end of your testing done.	david	Jan. 23, 2021, 9:02 a.m.
Can you fix up indentation here? logger is one character shorter than logging.	david	Jan. 23, 2021, 12:44 p.m.
Same here.	david	Jan. 23, 2021, 12:44 p.m.
And here.	david	Jan. 23, 2021, 12:44 p.m.

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Ship it!

```
Ship It!
```

The issue has been resolved. Show all issues

Can you add the bug number to the "bugs" field?

The issue has been resolved. Show all issues

Super tiny nit: please add a period at the end of your testing done.

Change Summary:

Linked bug in bugs field and added period to end of testing done.

Testing Done:

~		Ran all `reviewboard.extensions.tests` unit tests
	~	Ran all `reviewboard.extensions.tests` unit tests.

Bugs:

+	4904

reviewboard/extensions/templatetags/rb_extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you fix up indentation here? logger is one character shorter than logging.
```
reviewboard/extensions/templatetags/rb_extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
reviewboard/extensions/templatetags/rb_extensions.py (Diff revision 1)
The issue has been resolved. Show all issues
```
And here.
```

Change Summary:

Aligned whitespace where I misaligned it

Commits:

	Summary	ID
	Add named logging in the extensions module. The old global logging commands such as `logging.error` and `logging.info` do not insert information about where the log message came from. By instantiating a module-level `logger` object, log messages will now include information about the source module.	9328ce9fc18b2874368131d49c65a6229f8c7ef3
	Add named logging in the extensions module. The old global logging commands such as `logging.error` and `logging.info` do not insert information about where the log message came from. By instantiating a module-level `logger` object, log messages will now include information about the source module.	3b57ee53f5eb83969190d1e1e4dede901b081e40

Diff:

Revision 2 (+30 -22)

Show changes

	reviewboard/extensions/hooks.py
	reviewboard/extensions/templatetags/rb_extensions.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (1395d3b)