Finish changing logging to logger in modules reviews, webapi and ssh. 

 






 

 


  Review Request #11397
  —
  Created Jan. 22, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  qianxi
 









 
 

  Review Board
 









 
 

  master
 









 
 

  4897, 4908, 4910
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  students
 









 
 

  
 






 








 





  


 
 

  
Change from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.

I changed logging to logger in modules reviews, webapi and ssh.

 








  


 
 

  
Test using the tests in the reviews, webapi and ssh modules' repositories. Using the following commands:


./tests/runtests.py reviewboard.reviews.tests
./tests/runtests.py reviewboard.webapi.tests
./tests/runtests.py reviewboard.ssh.tests



All three test sets are passed.

 







 









 





  








 




 







   

    
    
Diff Revision 5 (Latest)



    

 

 

 

 
orig
1
2
3
4
5

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    
[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. N...

   
  		
  a419cc0b2427e5be2d4deb47b87da999d5a78fe1
  Qianxi Li
 


 
  
   
  
  
   
  
 
 
  
   
    
Change logging to logger in test_reviewtags.py. Finish modules reviews, webap...

   
  		
  e7eb9144c776202c5aee8974c04c79e0488bbd26
  Qianxi Li
 


 
  
   
  
  
   
  
 
 
  
   
    
Fix extra line spaces with import variable.

   
  		
  e13131c50f7a6f82326a34796276e76f1069e478
  Qianxi Li
 


 
  
   
  
  
   
  
 
 
  
   
    
Fix global logger line spacing issue.

   
  		
  1d094d90c87af6d2d990d439616fbfe788766c4f
  Qianxi Li
 


 
  
   
  
  
   
  
 
 
  
   
    
Fix all one-char unaligned indentations due to the shorter logger string

   
  		
  dbf34a00d99a94b68799838b1336c4d81a1e4238
  Qianxi Li
 


 
  
   
  
  
   
  
 
 
  
   
    
Move local import statements right before spy

   
  		
  a4b09e32a0c35941b4d51790a32881daabdda3f3
  Qianxi Li
 


 
  
   
  
  
   
  
 
 
  
   
    
Remove extra space on a new blank line

   
  		
  f6b87711e0692b7a47c7700abc859b9096bdeb56
  Qianxi Li
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/reviews/detail.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/fields.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/managers.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/views.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/file_attachment_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/group.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/review.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/review_request.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/templatetags/reviewtags.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/tests/test_entries.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/tests/test_reviewtags.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/ui/base.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/ui/markdownui.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/ui/text.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/ssh/client.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/ssh/errors.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/ssh/storage.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/base.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/decorators.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/server_info.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/base_original_file.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/base_patched_file.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/base_review_request_file_attachment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/diff.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/review_request.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/validate_diff.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...