Summary

Finish changing logging to logger in modules reviews, webapi and ssh.

Review Request #11397 — Created Jan. 22, 2021 and submitted Feb. 8, 2021, 9:24 p.m.

Information

Owner

qianxi

Repository

Review Board

Branch

master

Bugs

4897, 4908, 4910

Depends On

Reviewers

Groups

students

People

Description

Change from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.
I changed logging to logger in modules reviews, webapi and ssh.

Testing Done

Test using the tests in the reviews, webapi and ssh modules' repositories. Using the following commands:

./tests/runtests.py reviewboard.reviews.tests
./tests/runtests.py reviewboard.webapi.tests
./tests/runtests.py reviewboard.ssh.tests

All three test sets are passed.

Commits

Summary	ID
[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.	a419cc0b2427e5be2d4deb47b87da999d5a78fe1
Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.	e7eb9144c776202c5aee8974c04c79e0488bbd26
Fix extra line spaces with import variable.	e13131c50f7a6f82326a34796276e76f1069e478
Fix global logger line spacing issue.	1d094d90c87af6d2d990d439616fbfe788766c4f
Fix all one-char unaligned indentations due to the shorter logger string	dbf34a00d99a94b68799838b1336c4d81a1e4238
Move local import statements right before spy	a4b09e32a0c35941b4d51790a32881daabdda3f3
Remove extra space on a new blank line	f6b87711e0692b7a47c7700abc859b9096bdeb56

Issues

Description	From	Last Updated
Your summary probably doesn't need that second sentence about unit tests.	david	Jan. 22, 2021, 4:26 p.m.
E303 too many blank lines (2)	reviewbot	Jan. 22, 2021, 2:28 p.m.
You'll need to update the indentation on following lines to match, since "logger" is one character shorter than "logging". Here …	david	Jan. 22, 2021, 4:26 p.m.
Add an extra blank line above this.	david	Jan. 22, 2021, 4:26 p.m.
Add an extra blank line above this.	david	Jan. 22, 2021, 4:26 p.m.
This should have two blank lines after it.	david	Jan. 22, 2021, 4:26 p.m.
This should have two blank lines above and below.	david	Jan. 22, 2021, 4:26 p.m.
This should have two blank lines above and below.	david	Jan. 22, 2021, 4:26 p.m.
This should have two blank lines above and below.	david	Jan. 22, 2021, 4:26 p.m.
Let's move this down to happen just before the spy_on call.	david	Feb. 7, 2021, 6:23 p.m.
Let's move this down to happen just before the spy_on call.	david	Feb. 7, 2021, 6:23 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 7, 2021, 6:23 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_reviewtags.py (Diff revision 1)
Show all issues
```
E303 too many blank lines (2)
```

Change Summary:

Delete two extra line space before and after a variable import statement.

Commits:

	Summary	ID
	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.	a419cc0b2427e5be2d4deb47b87da999d5a78fe1
	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.	e7eb9144c776202c5aee8974c04c79e0488bbd26
	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.	a419cc0b2427e5be2d4deb47b87da999d5a78fe1
	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.	e7eb9144c776202c5aee8974c04c79e0488bbd26
	Fix extra line spaces with import variable.	e13131c50f7a6f82326a34796276e76f1069e478

Diff:

Revision 2 (+290 -162)

Show changes

	reviewboard/reviews/detail.py
	reviewboard/reviews/fields.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/group.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	18 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Show all issues

Your summary probably doesn't need that second sentence about unit tests.

reviewboard/reviews/detail.py (Diff revision 2)

Show all issues

You'll need to update the indentation on following lines to match, since "logger" is one character shorter than "logging". Here and in all the other changed places.

reviewboard/reviews/ui/base.py (Diff revision 2)
Show all issues
```
Add an extra blank line above this.
```
reviewboard/ssh/storage.py (Diff revision 2)
Show all issues
```
Add an extra blank line above this.
```
reviewboard/webapi/resources/base_original_file.py (Diff revision 2)
Show all issues
```
This should have two blank lines after it.
```

reviewboard/webapi/resources/diff.py (Diff revision 2)

Show all issues

This should have two blank lines above and below.

reviewboard/webapi/resources/review_request.py (Diff revision 2)
Show all issues
```
This should have two blank lines above and below.
```
reviewboard/webapi/resources/validate_diff.py (Diff revision 2)
Show all issues
```
This should have two blank lines above and below.
```

Change Summary:

Keep the logging.getLogger statements in reviews, ssh and webapi modules with 2 lines of spaces above and below. Fix all one-char unaligned indentations due to the shorter logger string in reviews, ssh and webapi modules.

Summary:

-	Finish changing logging to logger in modules reviews, webapi and ssh. Finish unit tests for these three modules.
+	Finish changing logging to logger in modules reviews, webapi and ssh.

Commits:

	Summary	ID
	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.	a419cc0b2427e5be2d4deb47b87da999d5a78fe1
	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.	e7eb9144c776202c5aee8974c04c79e0488bbd26
	Fix extra line spaces with import variable.	e13131c50f7a6f82326a34796276e76f1069e478
	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.	a419cc0b2427e5be2d4deb47b87da999d5a78fe1
	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.	e7eb9144c776202c5aee8974c04c79e0488bbd26
	Fix extra line spaces with import variable.	e13131c50f7a6f82326a34796276e76f1069e478
	Fix global logger line spacing issue.	1d094d90c87af6d2d990d439616fbfe788766c4f
	Fix all one-char unaligned indentations due to the shorter logger string	dbf34a00d99a94b68799838b1336c4d81a1e4238

Diff:

Revision 3 (+544 -398)

Show changes

	reviewboard/reviews/detail.py
	reviewboard/reviews/fields.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/group.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	18 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Looking really solid! Just two small suggestions.

qianxi Feb. 7, 2021, 6:25 p.m.
```
All fixed.
```

reviewboard/reviews/tests/test_entries.py (Diff revision 3)
Show all issues
```
Let's move this down to happen just before the spy_on call.
```
reviewboard/reviews/tests/test_reviewtags.py (Diff revision 3)
Show all issues
```
Let's move this down to happen just before the spy_on call.
```

Change Summary:

Move local import statements right before spy.

Commits:

	Summary	ID
	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.	a419cc0b2427e5be2d4deb47b87da999d5a78fe1
	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.	e7eb9144c776202c5aee8974c04c79e0488bbd26
	Fix extra line spaces with import variable.	e13131c50f7a6f82326a34796276e76f1069e478
	Fix global logger line spacing issue.	1d094d90c87af6d2d990d439616fbfe788766c4f
	Fix all one-char unaligned indentations due to the shorter logger string	dbf34a00d99a94b68799838b1336c4d81a1e4238
	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.	a419cc0b2427e5be2d4deb47b87da999d5a78fe1
	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.	e7eb9144c776202c5aee8974c04c79e0488bbd26
	Fix extra line spaces with import variable.	e13131c50f7a6f82326a34796276e76f1069e478
	Fix global logger line spacing issue.	1d094d90c87af6d2d990d439616fbfe788766c4f
	Fix all one-char unaligned indentations due to the shorter logger string	dbf34a00d99a94b68799838b1336c4d81a1e4238
	Move local import statements right before spy	a4b09e32a0c35941b4d51790a32881daabdda3f3

Diff:

Revision 4 (+549 -401)

Show changes

	reviewboard/reviews/detail.py
	reviewboard/reviews/fields.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/group.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	18 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_reviewtags.py (Diff revision 4)
Show all issues
```
W293 blank line contains whitespace
```

Change Summary:

Remove extra space on a new blank line

Commits:

	Summary	ID
	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.	a419cc0b2427e5be2d4deb47b87da999d5a78fe1
	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.	e7eb9144c776202c5aee8974c04c79e0488bbd26
	Fix extra line spaces with import variable.	e13131c50f7a6f82326a34796276e76f1069e478
	Fix global logger line spacing issue.	1d094d90c87af6d2d990d439616fbfe788766c4f
	Fix all one-char unaligned indentations due to the shorter logger string	dbf34a00d99a94b68799838b1336c4d81a1e4238
	Move local import statements right before spy	a4b09e32a0c35941b4d51790a32881daabdda3f3
	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.	a419cc0b2427e5be2d4deb47b87da999d5a78fe1
	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.	e7eb9144c776202c5aee8974c04c79e0488bbd26
	Fix extra line spaces with import variable.	e13131c50f7a6f82326a34796276e76f1069e478
	Fix global logger line spacing issue.	1d094d90c87af6d2d990d439616fbfe788766c4f
	Fix all one-char unaligned indentations due to the shorter logger string	dbf34a00d99a94b68799838b1336c4d81a1e4238
	Move local import statements right before spy	a4b09e32a0c35941b4d51790a32881daabdda3f3
	Remove extra space on a new blank line	f6b87711e0692b7a47c7700abc859b9096bdeb56

Diff:

Revision 5 (+550 -402)

Show changes

	reviewboard/reviews/detail.py
	reviewboard/reviews/fields.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/group.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	18 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (6c28b14)