- Download Diff

Summary:

Finish changing logging to logger in modules reviews, webapi and ssh.

Review Request #11397 — Created Jan. 22, 2021 and submitted Feb. 8, 2021, 9:24 p.m.

Information
Owner:	qianxi
Repository:	Review Board
Branch:	master
Bugs:	4897, 4908, 4910
Depends On:
Reviewers
Groups:	students
People:

Description

Change from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.
I changed logging to logger in modules reviews, webapi and ssh.

Testing Done

Test using the tests in the reviews, webapi and ssh modules' repositories. Using the following commands:

./tests/runtests.py reviewboard.reviews.tests
./tests/runtests.py reviewboard.webapi.tests
./tests/runtests.py reviewboard.ssh.tests

All three test sets are passed.

Commits

Summary
[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.
Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.
Fix extra line spaces with import variable.
Fix global logger line spacing issue.
Fix all one-char unaligned indentations due to the shorter logger string
Move local import statements right before spy
Remove extra space on a new blank line

Screenshots

Issues

Description	From	Last Updated
Your summary probably doesn't need that second sentence about unit tests.	david	Jan. 22, 2021, 4:26 p.m.
E303 too many blank lines (2)	reviewbot	Jan. 22, 2021, 2:28 p.m.
You'll need to update the indentation on following lines to match, since "logger" is one character shorter than "logging". Here ...	david	Jan. 22, 2021, 4:26 p.m.
Add an extra blank line above this.	david	Jan. 22, 2021, 4:26 p.m.
Add an extra blank line above this.	david	Jan. 22, 2021, 4:26 p.m.
This should have two blank lines after it.	david	Jan. 22, 2021, 4:26 p.m.
This should have two blank lines above and below.	david	Jan. 22, 2021, 4:26 p.m.
This should have two blank lines above and below.	david	Jan. 22, 2021, 4:26 p.m.
This should have two blank lines above and below.	david	Jan. 22, 2021, 4:26 p.m.
Let's move this down to happen just before the spy_on call.	david	Feb. 7, 2021, 6:23 p.m.
Let's move this down to happen just before the spy_on call.	david	Feb. 7, 2021, 6:23 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 7, 2021, 6:23 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_reviewtags.py (Diff revision 1)
Show all issues
```
E303 too many blank lines (2)
```

Change Summary:

Delete two extra line space before and after a variable import statement.

Commits:

	Summary
-	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.
-	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.
+	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.
+	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.
+	Fix extra line spaces with import variable.

Diff:

Revision 2 (+290 -162)

Show changes

	reviewboard/reviews/detail.py
	reviewboard/reviews/fields.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/group.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	18 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Show all issues

Your summary probably doesn't need that second sentence about unit tests.

reviewboard/reviews/detail.py (Diff revision 2)

Show all issues

You'll need to update the indentation on following lines to match, since "logger" is one character shorter than "logging". Here and in all the other changed places.

reviewboard/reviews/ui/base.py (Diff revision 2)
Show all issues
```
Add an extra blank line above this.
```
reviewboard/ssh/storage.py (Diff revision 2)
Show all issues
```
Add an extra blank line above this.
```
reviewboard/webapi/resources/base_original_file.py (Diff revision 2)
Show all issues
```
This should have two blank lines after it.
```

reviewboard/webapi/resources/diff.py (Diff revision 2)

Show all issues

This should have two blank lines above and below.

reviewboard/webapi/resources/review_request.py (Diff revision 2)
Show all issues
```
This should have two blank lines above and below.
```
reviewboard/webapi/resources/validate_diff.py (Diff revision 2)
Show all issues
```
This should have two blank lines above and below.
```

Change Summary:

Keep the logging.getLogger statements in reviews, ssh and webapi modules with 2 lines of spaces above and below. Fix all one-char unaligned indentations due to the shorter logger string in reviews, ssh and webapi modules.

Summary:

-	Finish changing logging to logger in modules reviews, webapi and ssh. Finish unit tests for these three modules.
+	Finish changing logging to logger in modules reviews, webapi and ssh.

Commits:

	Summary
-	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.
-	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.
-	Fix extra line spaces with import variable.
+	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.
+	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.
+	Fix extra line spaces with import variable.
+	Fix global logger line spacing issue.
+	Fix all one-char unaligned indentations due to the shorter logger string

Diff:

Revision 3 (+544 -398)

Show changes

	reviewboard/reviews/detail.py
	reviewboard/reviews/fields.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/group.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	18 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Looking really solid! Just two small suggestions.

qianxi Feb. 7, 2021, 6:25 p.m.
```
All fixed.
```

reviewboard/reviews/tests/test_entries.py (Diff revision 3)
Show all issues
```
Let's move this down to happen just before the spy_on call.
```
reviewboard/reviews/tests/test_reviewtags.py (Diff revision 3)
Show all issues
```
Let's move this down to happen just before the spy_on call.
```

Change Summary:

Move local import statements right before spy.

Commits:

	Summary
-	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.
-	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.
-	Fix extra line spaces with import variable.
-	Fix global logger line spacing issue.
-	Fix all one-char unaligned indentations due to the shorter logger string
+	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.
+	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.
+	Fix extra line spaces with import variable.
+	Fix global logger line spacing issue.
+	Fix all one-char unaligned indentations due to the shorter logger string
+	Move local import statements right before spy

Diff:

Revision 4 (+549 -401)

Show changes

	reviewboard/reviews/detail.py
	reviewboard/reviews/fields.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/group.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	18 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/reviews/tests/test_reviewtags.py (Diff revision 4)
Show all issues
```
W293 blank line contains whitespace
```

Change Summary:

Remove extra space on a new blank line

Commits:

	Summary
-	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.
-	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.
-	Fix extra line spaces with import variable.
-	Fix global logger line spacing issue.
-	Fix all one-char unaligned indentations due to the shorter logger string
-	Move local import statements right before spy
+	[WIP] Finish changing logging to logger in modules reviews, webapi and ssh. Not tested yet. Changing from logging to logger because we wish to see the information about the module where the logging message came from so that it's easier to diagnosing problems.
+	Change logging to logger in test_reviewtags.py. Finish modules reviews, webapi and ssh unit tests. I ran "./tests/runtests.py reviewboard.reviews.tests", "./tests/runtests.py reviewboard.webapi.tests" and "./tests/runtests.py reviewboard.ssh.tests". All all them give OK.
+	Fix extra line spaces with import variable.
+	Fix global logger line spacing issue.
+	Fix all one-char unaligned indentations due to the shorter logger string
+	Move local import statements right before spy
+	Remove extra space on a new blank line

Diff:

Revision 5 (+550 -402)

Show changes

	reviewboard/reviews/detail.py
	reviewboard/reviews/fields.py
	reviewboard/reviews/managers.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/group.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	18 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (6c28b14)

You have a pending review.

Review Board 4.0 RC1 (dev)

Finish changing logging to logger in modules reviews, webapi and ssh.

flake8

Change Summary:

Commits:

Diff:

Checks run (2 succeeded)

Change Summary:

Summary:

Commits:

Diff:

Checks run (2 succeeded)

Change Summary:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Change Summary:

Commits:

Diff:

Checks run (2 succeeded)

Status: Closed (submitted)

Change Summary: