[Demo] Enhance and fix up the setup experience in prepare-dev.py.
Review Request #11393 — Created Jan. 21, 2021 and discarded
This modernizes the way we request input and display output on
prepare-dev.py
, utilizing more of rb-site'sConsoleUI
. This is a
better, more consistent way of displaying information and prompting for
information.The text has been updated to be more user-friendly, to offer
guidance for when things go wrong, and to provide next steps when the
environment is prepared.
Ran through
prepare-dev.py
with a brand-new clone and database, and also
with an existing one.Verified dependencies were installed.
Verified each new text string was correct and free from typos.
Summary | ID |
---|---|
e30f2fcf4418c1fd419ba7d034fbcabb3accca92 | |
e77f748462f8a4a61f0dca6076dfd58b00a308da |
Description | From | Last Updated |
---|---|---|
Typo in description: prepare-dev.ppy -> prepare-dev.py |
david | |
Can you flesh out the testing done? |
david | |
There should be a blank line between these two. |
david | |
Typo: two spaces between "in" and "the" |
david | |
E126 continuation line over-indented for hanging indent |
reviewbot | |
We need to add global ui here to assign to the global. |
david | |
Please use single quotes for this string. |
david | |
Please add a blank line. |
david | |
These two strings will get concatenated, so the first one needs a space at the end. |
david |
- Change Summary:
-
- Fixed up typos in some of the new strings and in the Description.
- Added a
global ui
and re-verified with testing. - Added missing blank lines.
- Description:
-
This modernizes the way we request input and display output on
~ prepare-dev.ppy
, utilizing more of rb-site'sConsoleUI
. This is a~ prepare-dev.py
, utilizing more of rb-site'sConsoleUI
. This is abetter, more consistent way of displaying information and prompting for information. The text has been updated to be more user-friendly, to offer
guidance for when things go wrong, and to provide next steps when the environment is prepared. - Testing Done:
-
~ Tested
prepare-dev.py
.~ Ran through
prepare-dev.py
with a brand-new clone and database, and also+ with an existing one. + + Verified dependencies were installed.
+ + Verified each new text string was correct and free from typos.
- Commits:
-
Summary ID e30f2fcf4418c1fd419ba7d034fbcabb3accca92 e30f2fcf4418c1fd419ba7d034fbcabb3accca92 e77f748462f8a4a61f0dca6076dfd58b00a308da - Diff:
-
Revision 2 (+139 -49)