Fix the dnspython check and improve wording and deps for the LDAP/AD.

Review Request #11359 — Created Jan. 6, 2021 and submitted

chipx86
Review Board
release-4.0.x
reviewboard

A recent change to get_can_enable_dns() gave it the wrong return type.
While this doesn't really impact things for us, since we don't call it
ourselves anymore, we don't want to break it. This fixes the return
type, and adds a deprecation warning.

get_can_enable_ldap() is used for both LDAP and Active Directory, but
its check only referenced LDAP, and gave legacy instructions for
installing the necessary support. The new text references both services,
and the ReviewBoard[ldap] dependency.

That dependency has also been updated to include the right version
ranges for Python 2 and 3.

Tested both functions and their results.

Tested installing ReviewBoard[ldap] on Python 2 and 3.6-3.9.

Summary
Fix the dnspython check and improve wording and deps for the LDAP/AD.
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (d71f118)
Loading...