Fix a regression and improve content when sending test e-mails.

Review Request #11353 — Created Dec. 28, 2020 and submitted

chipx86
Review Board
release-4.0.x
reviewboard

Some cleanup work in the e-mail settings page resulted in the wrong
keyword argument being used when sending a test e-mail. We were passing
email_from and not from_email. We didn't have any unit tests
covering this, and it wasn't caught in development.

This change fixes up the keyword argument and adds a test suite. It also
improves upon the e-mail's subject, body, and error handling. The new
content more explicitly lists the product in the summary, adds a
confirmation that things look good in the body, includes recipient
information in the logs, and an error message in the message shown in
the UI.

Unit tests pass.

Summary
Fix a regression and improve content when sending test e-maails.
Description From Last Updated

Typo in summary: e-maails

daviddavid

E127 continuation line over-indented for visual indent

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

david
  1. 
      
  2. Typo in summary: e-maails

    1. This is my bad keyboard :(

  3. 
      
chipx86
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (f08eec1)
Loading...