Summary

Fix a regression and improve content when sending test e-mails.

Review Request #11353 — Created Dec. 28, 2020 and submitted Jan. 6, 2021, 5:49 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Some cleanup work in the e-mail settings page resulted in the wrong
keyword argument being used when sending a test e-mail. We were passing
email_from and not from_email. We didn't have any unit tests
covering this, and it wasn't caught in development.

This change fixes up the keyword argument and adds a test suite. It also
improves upon the e-mail's subject, body, and error handling. The new
content more explicitly lists the product in the summary, adds a
confirmation that things look good in the body, includes recipient
information in the logs, and an error message in the message shown in
the UI.

Testing Done

Unit tests pass.

Commits

Summary	ID
Fix a regression and improve content when sending test e-maails. Some cleanup work in the e-mail settings page resulted in the wrong keyword argument being used when sending a test e-mail. We were passing `email_from` and not `from_email`. We didn't have any unit tests covering this, and it wasn't caught in development. This change fixes up the keyword argument and adds a test suite. It also improves upon the e-mail's subject, body, and error handling. The new content more explicitly lists the product in the summary, adds a confirmation that things look good in the body, includes recipient information in the logs, and an error message in the message shown in the UI.	3060b8cd9718615db8a1c66839c20b935181564c

Summary

Fix a regression and improve content when sending test e-maails.

Some cleanup work in the e-mail settings page resulted in the wrong keyword argument being used when sending a test e-mail. We were passing `email_from` and not `from_email`. We didn't have any unit tests covering this, and it wasn't caught in development. This change fixes up the keyword argument and adds a test suite. It also improves upon the e-mail's subject, body, and error handling. The new content more explicitly lists the product in the summary, adds a confirmation that things look good in the body, includes recipient information in the logs, and an error message in the message shown in the UI.

3060b8cd9718615db8a1c66839c20b935181564c

Issues

Description	From	Last Updated
Typo in summary: e-maails	david	Dec. 28, 2020, 6:33 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Dec. 28, 2020, 2:46 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/tests/test_email_settings_form.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E127 continuation line over-indented for visual indent
```

Ship it!

The issue has been resolved. Show all issues
```
Typo in summary: e-maails
```
1. chipx86 Dec. 28, 2020, 6:33 p.m.
  This is my bad keyboard :(

Summary:: Fix a regression and improve content when sending test e-maails.
Fix a regression and improve content when sending test e-mails.

Status:: Completed
Change Summary:: Pushed to release-4.0.x (f08eec1)