Summary

Remove usage of our custom MySQL backend.

Review Request #11342 — Created Dec. 21, 2020 and submitted Dec. 21, 2020, 5:19 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

While Review Board 4.0 was early in development, we hit a case with
Django's MySQL backend where setting a BinaryField to binary contents
would trigger a warning. This was fixed in Django 1.10.5, but applied to
Django 1.6 as well.

We worked around this in a custom backend defined in Djblets that we
patched in in Review Board's settings. As we're no longer using any
versions of Django that are susceptible to this bug, we no longer need
to patch in the backend.

This change removes that, allowing the original backend to be used.

Testing Done

Tested an install running on MySQL.

Unit tests pass.

Commits

Summary	ID
Remove usage of our custom MySQL backend. While Review Board 4.0 was early in development, we hit a case with Django's MySQL backend where setting a `BinaryField` to binary contents would trigger a warning. This was fixed in Django 1.10.5, but applied to Django 1.6 as well. We worked around this in a custom backend defiend in Djblets that we patched in in Review Board's settings. As we're no longer using any versions of Django that are susceptible to this bug, we no longer need to patch in the backend. This change removes that, allowing the original backend to be used.	b80c86f9f10839c0e2f17e0baa98429ed1a29f1b

Summary

Remove usage of our custom MySQL backend.

While Review Board 4.0 was early in development, we hit a case with Django's MySQL backend where setting a `BinaryField` to binary contents would trigger a warning. This was fixed in Django 1.10.5, but applied to Django 1.6 as well. We worked around this in a custom backend defiend in Djblets that we patched in in Review Board's settings. As we're no longer using any versions of Django that are susceptible to this bug, we no longer need to patch in the backend. This change removes that, allowing the original backend to be used.

b80c86f9f10839c0e2f17e0baa98429ed1a29f1b

Issues

Description	From	Last Updated
Before you submit: typo in description: defiend	david	Dec. 21, 2020, 5:18 p.m.

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

The issue has been resolved. Show all issues

Before you submit: typo in description: defiend

Description:: While Review Board 4.0 was early in development, we hit a case with
Django's MySQL backend where setting a BinaryField to binary contents
would trigger a warning. This was fixed in Django 1.10.5, but applied to
Django 1.6 as well.

~
We worked around this in a custom backend defiend in Djblets that we
~
We worked around this in a custom backend defined in Djblets that we
patched in in Review Board's settings. As we're no longer using any
versions of Django that are susceptible to this bug, we no longer need
to patch in the backend.

This change removes that, allowing the original backend to be used.

Status:: Completed
Change Summary:: Pushed to release-4.0.x (21aa2d7)

		While Review Board 4.0 was early in development, we hit a case with
		Django's MySQL backend where setting a `BinaryField` to binary contents
		would trigger a warning. This was fixed in Django 1.10.5, but applied to
		Django 1.6 as well.

~		We worked around this in a custom backend defiend in Djblets that we
	~	We worked around this in a custom backend defined in Djblets that we
		patched in in Review Board's settings. As we're no longer using any
		versions of Django that are susceptible to this bug, we no longer need
		to patch in the backend.

		This change removes that, allowing the original backend to be used.