Summary

Add a central function for registering SCMTools in the database.

Review Request #11338 — Created Dec. 17, 2020 and submitted Dec. 21, 2020, 3:10 a.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

This replaces the core logic from the registerscmtools management
command with a call to a new Tool.objects.register_from_entrypoints()
method. This method does the work of looking for any entrypoint-provided
SCMTools not already in the database, and registers them.

The new implementation executes fewer queries, and slims down the query
for the initial lookup of tools. The management command is also less
verbose, providing a single-line summary after registration instead of a
one line per tool.

Testing Done

Tested the registerscmtools command with registering 1 SCMTool, many
SCMTools, and no SCMTools.

Commits

Summary	ID
Add a central function for registering SCMTools in the database. This replaces the core logic from the `registerscmtools` management command with a call to a new `Tool.objects.register_from_entrypoints()` method. This method does the work of looking for any entrypoint-provided SCMTools not already in the database, and registers them. The new implementation executes fewer queries, and slims down the query for the initial lookup of tools. The management command is also less verbose, providing a single-line summary after registration instead of a one line per tool.	c85b4445e9acd6f350973baa83a27e896520436a

Summary

Add a central function for registering SCMTools in the database.

This replaces the core logic from the `registerscmtools` management command with a call to a new `Tool.objects.register_from_entrypoints()` method. This method does the work of looking for any entrypoint-provided SCMTools not already in the database, and registers them. The new implementation executes fewer queries, and slims down the query for the initial lookup of tools. The management command is also less verbose, providing a single-line summary after registration instead of a one line per tool.

c85b4445e9acd6f350973baa83a27e896520436a

Issues

Description	From	Last Updated
F821 undefined name '_'	reviewbot	Dec. 17, 2020, 8:09 p.m.
Totally your call, but personally I feel like a better wrapping would be: new_tools.append( self.model(name=name, class_name=class_name))	david	Dec. 21, 2020, 3:08 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/scmtools/managers.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name '_'
```

Change Summary:

Fixed logging in the error condition.

Commits:

	Summary	ID
	Add a central function for registering SCMTools in the database. This replaces the core logic from the `registerscmtools` management command with a call to a new `Tool.objects.register_from_entrypoints()` method. This method does the work of looking for any entrypoint-provided SCMTools not already in the database, and registers them. The new implementation executes fewer queries, and slims down the query for the initial lookup of tools. The management command is also less verbose, providing a single-line summary after registration instead of a one line per tool.	6b42749398d47a8105ced02105c024c1a33dcd4d
	Add a central function for registering SCMTools in the database. This replaces the core logic from the `registerscmtools` management command with a call to a new `Tool.objects.register_from_entrypoints()` method. This method does the work of looking for any entrypoint-provided SCMTools not already in the database, and registers them. The new implementation executes fewer queries, and slims down the query for the initial lookup of tools. The management command is also less verbose, providing a single-line summary after registration instead of a one line per tool.	c85b4445e9acd6f350973baa83a27e896520436a

Diff:

Revision 2 (+124 -60)

Show changes

	reviewboard/scmtools/managers.py
	reviewboard/scmtools/management/commands/registerscmtools.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

reviewboard/scmtools/managers.py (Diff revision 2)

The issue has been dropped. Show all issues

Totally your call, but personally I feel like a better wrapping would be:

new_tools.append(
    self.model(name=name, class_name=class_name))

chipx86 Dec. 21, 2020, 3:07 a.m.

I try to keep one keyword argument per line when filing out things like a model, for the same reason we do with dictionaries.

Status: Closed (submitted)

Change Summary:

Pushed to release-4.0.x (5b9703c)