Use newer Django auth-related views, and fix a Reset Password e-mail issue.

Review Request #11334 — Created Dec. 15, 2020 and submitted — Latest diff uploaded


Review Board


Django is getting rid of their legacy auth-related function-based views
and moving to class-based views. Usage of the legacy views emits a
deprecation warning (if enabled). This change updated our URLs to use
the modern views.

This was discovered while investigating an issue with Reset Password
e-mails, where the text would say "Thank you for using !" instead of
"Thank you for using Review Board!" That happened because the e-mail
context is slim, and doesn't have access to Django settings. We now pass
in the product name using one of the class-based view's attributes for
setting e-mail context.

Tested each auth view, making sure nothing regressed.

Reset my password. Verified that the text was correct in the e-mail.