Summary

Update the actual config forms page code to use modern config forms CSS.

Review Request #11331 — Created Dec. 15, 2020 and submitted Dec. 16, 2020, 2:17 p.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-2.0.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The actual configforms Python module and related JavaScript code is
responsible for pages like the My Account page in Review Board, or the
admin UI in RBCommons. This module was still using legacy naming, which
meant we weren't able to get some of the benefits of newer styling, and
were building UIs that needed workarounds for layout.

This change moves this last remaining part of Djblets to the modern
components.

Testing Done

Unit tests pass.

Tested each page in My Account

Commits

Summary	ID
Update the actual config forms page code to use modern config forms CSS. Djblets 2.0 got a major update to config forms, moving to our modern CSS component model and fixing up a bunch of styling. Everything in Djblets was updated to use this except, ironically, the module that introduced config forms in the first place. The actual `configforms` Python module and related JavaScript code is responsible for pages like the My Account page in Review Board, or the admin UI in RBCommons. This module was still using legacy naming, which meant we weren't able to get some of the benefits of newer styling, and were building UIs that needed workarounds for layout. This change moves this last remaining part of Djblets to the modern components.	019cefba68038e0af93eafff382e36f7f0a7d89b

Summary

Update the actual config forms page code to use modern config forms CSS.

Djblets 2.0 got a major update to config forms, moving to our modern CSS component model and fixing up a bunch of styling. Everything in Djblets was updated to use this except, ironically, the module that introduced config forms in the first place. The actual `configforms` Python module and related JavaScript code is responsible for pages like the My Account page in Review Board, or the admin UI in RBCommons. This module was still using legacy naming, which meant we weren't able to get some of the benefits of newer styling, and were building UIs that needed workarounds for layout. This change moves this last remaining part of Djblets to the modern components.

019cefba68038e0af93eafff382e36f7f0a7d89b

Files

flake8 passed.

JSHint passed.

Testing Done:

		Unit tests pass.

~		Tested the My Account page in Review Board, making sure all standard
	~	Tested each page in My Account
-		rendering (anything but our custom pages, which still need updates) are
-		correctly rendered and updated.

Added Files:

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (21067a1)